2011-06-10 22:27:21

by Hartley Sweeten

Subject: [PATCH] fs/partitions/check.c: make local symbols static

The symbols part_ro_show, part_alignment_offset_show, and
part_discard_alignment_show are not used outside this file and
should be marked static.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Yasuaki Ishimatsu <[email protected]>
Cc: Alexey Dobriyan <[email protected]>
Cc: Tejun Heo <[email protected]>

---

diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index d545e97..e3c63d1 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -237,22 +237,22 @@ ssize_t part_size_show(struct device *dev,
return sprintf(buf, "%llu\n",(unsigned long long)p->nr_sects);
}

-ssize_t part_ro_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t part_ro_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%d\n", p->policy ? 1 : 0);
}

-ssize_t part_alignment_offset_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t part_alignment_offset_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%llu\n", (unsigned long long)p->alignment_offset);
}

-ssize_t part_discard_alignment_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t part_discard_alignment_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct hd_struct *p = dev_to_part(dev);
return sprintf(buf, "%u\n", p->discard_alignment);

2011-06-11 12:22:23

by Tejun Heo

Subject: Re: [PATCH] fs/partitions/check.c: make local symbols static

On Fri, Jun 10, 2011 at 03:26:59PM -0700, H Hartley Sweeten wrote:
> The symbols part_ro_show, part_alignment_offset_show, and
> part_discard_alignment_show are not used outside this file and
> should be marked static.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: Yasuaki Ishimatsu <[email protected]>
> Cc: Alexey Dobriyan <[email protected]>
> Cc: Tejun Heo <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Thanks.

--
tejun

2011-06-13 09:48:10

by Jens Axboe

Subject: Re: [PATCH] fs/partitions/check.c: make local symbols static

On 2011-06-11 00:26, H Hartley Sweeten wrote:
> The symbols part_ro_show, part_alignment_offset_show, and
> part_discard_alignment_show are not used outside this file and
> should be marked static.

Applied, thanks.

--
Jens Axboe