2011-06-13 21:30:19

by Németh Márton

Subject: [PATCH 3/3] usbip: simplify port status saving

From: Márton Németh <[email protected]>

Use memcpy() function to save port status instead of
a handwritten for loop.

Signed-off-by: Márton Németh <[email protected]>
---
drivers/staging/usbip/vhci_hcd.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index d3ce569..ccb30e1 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -281,9 +281,8 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,

/* store old status and compare now and old later */
if (usbip_dbg_flag_vhci_rh) {
- int i = 0;
- for (i = 0; i < VHCI_NPORTS; i++)
- prev_port_status[i] = dum->port_status[i];
+ memcpy(prev_port_status, dum->port_status,
+ sizeof(prev_port_status));
}

switch (typeReq) {
--
1.7.2.5

2011-06-14 06:28:44

by Németh Márton

Subject: Re: [PATCH 3/3] usbip: simplify port status saving

From: Márton Németh <[email protected]>

Use memcpy() function to save port status instead of
a handwritten for loop.

Signed-off-by: Márton Németh <[email protected]>
---
drivers/staging/usbip/vhci_hcd.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index d3f11a3..878b5bf 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -287,9 +287,8 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,

/* store old status and compare now and old later */
if (usbip_dbg_flag_vhci_rh) {
- int i = 0;
- for (i = 0; i < VHCI_NPORTS; i++)
- prev_port_status[i] = dum->port_status[i];
+ memcpy(prev_port_status, dum->port_status,
+ sizeof(prev_port_status));
}

switch (typeReq) {
--
1.7.2.5