The 128-bit multiply in pvclock.h was missing an output constraint for
EDX which caused a register corruption to appear. Thanks to Ulrich for
diagnosing the EDX corruption and Avi for providing this fix (which now
I am sending back to you Avi..)
Zach
On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> The 128-bit multiply in pvclock.h was missing an output constraint for
> EDX which caused a register corruption to appear. Thanks to Ulrich
> for diagnosing the EDX corruption and Avi for providing this fix
> (which now I am sending back to you Avi..)
Applied and queued, thanks.
--
error compiling committee.c: too many arguments to function
On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote:
> On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> > The 128-bit multiply in pvclock.h was missing an output constraint for
> > EDX which caused a register corruption to appear.
Was there any particular symptom associated with corruption at that
particular point or just general badness?
> Thanks to Ulrich
> > for diagnosing the EDX corruption and Avi for providing this fix
> > (which now I am sending back to you Avi..)
>
> Applied and queued, thanks.
Seems like a stable candidate also?
Ian.
On 06/22/2011 12:35 PM, Ian Campbell wrote:
> On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote:
> > On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> > > The 128-bit multiply in pvclock.h was missing an output constraint for
> > > EDX which caused a register corruption to appear.
>
> Was there any particular symptom associated with corruption at that
> particular point or just general badness?
>
> > Thanks to Ulrich
> > > for diagnosing the EDX corruption and Avi for providing this fix
> > > (which now I am sending back to you Avi..)
> >
> > Applied and queued, thanks.
>
> Seems like a stable candidate also?
Yes. I see it's merged; Marcelo, can you backport it?
--
error compiling committee.c: too many arguments to function
On 06/22/2011 12:35 PM, Ian Campbell wrote:
> On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote:
> > On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> > > The 128-bit multiply in pvclock.h was missing an output constraint for
> > > EDX which caused a register corruption to appear.
>
> Was there any particular symptom associated with corruption at that
> particular point or just general badness?
>
Time went backwards and forwards as vcpus were migrated across cpus.
The problem was in the host, not the guest, so Xen should not be affected.
--
error compiling committee.c: too many arguments to function
On Wed, 2011-06-22 at 10:40 +0100, Avi Kivity wrote:
> On 06/22/2011 12:35 PM, Ian Campbell wrote:
> > On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote:
> > > On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> > > > The 128-bit multiply in pvclock.h was missing an output constraint for
> > > > EDX which caused a register corruption to appear.
> >
> > Was there any particular symptom associated with corruption at that
> > particular point or just general badness?
> >
>
> Time went backwards and forwards as vcpus were migrated across cpus.
Oops!
> The problem was in the host, not the guest, so Xen should not be affected.
Good to know, thanks!
Ian.