2011-06-20 10:48:03

by Mark Brown

Subject: [PATCH] mfd: Implement tps65910 IRQ cleanup

The tps65910_irq_exit() cleanup function was generating a warning from
sparse due to the lack of a prototype. This wasn't causing GCC warnings
as the driver wasn't cleaning up its IRQs on exit at all so there was no
use of an unprototyped function.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/tps65910.c | 1 +
include/linux/mfd/tps65910.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 2229e66..837f0e6 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -187,6 +187,7 @@ static int tps65910_i2c_remove(struct i2c_client *i2c)
struct tps65910 *tps65910 = i2c_get_clientdata(i2c);

mfd_remove_devices(tps65910->dev);
+ tps65910_irq_exit(tps65910);
kfree(tps65910);

return 0;
diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
index 8bb85b9..efcdb29 100644
--- a/include/linux/mfd/tps65910.h
+++ b/include/linux/mfd/tps65910.h
@@ -791,6 +791,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask);
void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base);
int tps65910_irq_init(struct tps65910 *tps65910, int irq,
struct tps65910_platform_data *pdata);
+int tps65910_irq_exit(struct tps65910 *tps65910);

static inline int tps65910_chip_id(struct tps65910 *tps65910)
{
--
1.7.5.4

2011-06-20 14:56:34

by Samuel Ortiz

Subject: Re: [PATCH] mfd: Implement tps65910 IRQ cleanup

Hi Mark,

On Mon, Jun 20, 2011 at 11:47:55AM +0100, Mark Brown wrote:
> The tps65910_irq_exit() cleanup function was generating a warning from
> sparse due to the lack of a prototype. This wasn't causing GCC warnings
> as the driver wasn't cleaning up its IRQs on exit at all so there was no
> use of an unprototyped function.
Patch applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2011-06-20 18:55:11

by Graeme Gregory

Subject: Re: [PATCH] mfd: Implement tps65910 IRQ cleanup

On 06/20/2011 12:47 PM, Mark Brown wrote:
> The tps65910_irq_exit() cleanup function was generating a warning from
> sparse due to the lack of a prototype. This wasn't causing GCC warnings
> as the driver wasn't cleaning up its IRQs on exit at all so there was no
> use of an unprototyped function.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/mfd/tps65910.c | 1 +
> include/linux/mfd/tps65910.h | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 2229e66..837f0e6 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -187,6 +187,7 @@ static int tps65910_i2c_remove(struct i2c_client *i2c)
> struct tps65910 *tps65910 = i2c_get_clientdata(i2c);
>
> mfd_remove_devices(tps65910->dev);
> + tps65910_irq_exit(tps65910);
> kfree(tps65910);
>
> return 0;
> diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
> index 8bb85b9..efcdb29 100644
> --- a/include/linux/mfd/tps65910.h
> +++ b/include/linux/mfd/tps65910.h
> @@ -791,6 +791,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask);
> void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base);
> int tps65910_irq_init(struct tps65910 *tps65910, int irq,
> struct tps65910_platform_data *pdata);
> +int tps65910_irq_exit(struct tps65910 *tps65910);
>
> static inline int tps65910_chip_id(struct tps65910 *tps65910)
> {
Acked-by: Graeme Gregory <[email protected]>

Thanks for that cleanup.

Graeme