2012-02-01 17:16:15

by Linus Walleij

Subject: [PATCH] pinctrl: restore pin naming

From: Linus Walleij <[email protected]>

Commit ca53c5f1ca5c936777caca46b7c716a40682ce83 made pins loose
their identity and only get autogenerated names.

Signed-off-by: Linus Walleij <[email protected]>
---
drivers/pinctrl/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 8fe15cf..894cd5e 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -189,7 +189,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev,
pindesc->pctldev = pctldev;

/* Copy basic pin info */
- if (pindesc->name) {
+ if (name) {
pindesc->name = name;
} else {
pindesc->name = kasprintf(GFP_KERNEL, "PIN%u", number);
--
1.7.8

2012-02-01 17:33:18

by Stephen Warren

Subject: RE: [PATCH] pinctrl: restore pin naming

Linus Walleij wrote at Wednesday, February 01, 2012 10:16 AM:
> Commit ca53c5f1ca5c936777caca46b7c716a40682ce83 made pins loose
> their identity and only get autogenerated names.

It might be nice to include that commit's subject for easy reference.
"Commit 234723... ("foo") made ..."

> Signed-off-by: Linus Walleij <[email protected]>

Acked-by: Stephen Warren <[email protected]>

--
nvpublic

2012-02-01 18:19:11

by Sergei Shtylyov

Subject: Re: [PATCH] pinctrl: restore pin naming

Hello.

On 02/01/2012 08:15 PM, Linus Walleij wrote:

> From: Linus Walleij<[email protected]>

> Commit ca53c5f1ca5c936777caca46b7c716a40682ce83

Please add that commit's summary in parens.

made pins loose

s/loose/lose/?

> their identity and only get autogenerated names.

> Signed-off-by: Linus Walleij<[email protected]>

WBR, Sergei