2012-02-05 06:28:37

by Al Viro

Subject: fsl-diu: enable_lcdc() takes a pointer, not struct...

A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...

Signed-off-by: Al Viro <[email protected]>

diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index acf292b..629ae00 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c
@@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
struct fsl_diu_data *data;

data = dev_get_drvdata(&ofdev->dev);
- disable_lcdc(data->fsl_diu_info[0]);
+ disable_lcdc(&data->fsl_diu_info[0]);

return 0;
}
@@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
struct fsl_diu_data *data;

data = dev_get_drvdata(&ofdev->dev);
- enable_lcdc(data->fsl_diu_info[0]);
+ enable_lcdc(&data->fsl_diu_info[0]);

return 0;
}

2012-02-05 15:12:25

by Timur Tabi

Subject: Re: fsl-diu: enable_lcdc() takes a pointer, not struct...

Al Viro wrote:
> A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...
>
> Signed-off-by: Al Viro<[email protected]>

This is already fixed in fbdev, although I can't find the patch in the
archives (http://marc.info/?l=linux-fbdev&r=3&b=201201&w=2).

>
> diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
> index acf292b..629ae00 100644
> --- a/drivers/video/fsl-diu-fb.c
> +++ b/drivers/video/fsl-diu-fb.c
> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
> struct fsl_diu_data *data;
>
> data = dev_get_drvdata(&ofdev->dev);
> - disable_lcdc(data->fsl_diu_info[0]);
> + disable_lcdc(&data->fsl_diu_info[0]);
>
> return 0;
> }
> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
> struct fsl_diu_data *data;
>
> data = dev_get_drvdata(&ofdev->dev);
> - enable_lcdc(data->fsl_diu_info[0]);
> + enable_lcdc(&data->fsl_diu_info[0]);
>
> return 0;
> }
>


--
Timur Tabi
Linux kernel developer at Freescale