Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
This is because of a missing include, which is added indirectly if
CONFIG_OF is defined. This problem was introduced in commit
2f31b51659c2d8315ea2888ba5b93076febe672b
Cc: Tero Kristo <[email protected]>
Signed-off-by: Luciano Coelho <[email protected]>
---
arch/arm/mach-omap2/prm44xx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
index 33dd655..f2e06ad 100644
--- a/arch/arm/mach-omap2/prm44xx.c
+++ b/arch/arm/mach-omap2/prm44xx.c
@@ -20,6 +20,7 @@
#include "common.h"
#include <plat/cpu.h>
#include <plat/prcm.h>
+#include <plat/irqs.h>
#include "vp.h"
#include "prm44xx.h"
--
1.7.5.4
On Wed, 2012-02-08 at 13:03 +0200, Felipe Balbi wrote:
> On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> > Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> >
> > arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> >
> > This is because of a missing include, which is added indirectly if
> > CONFIG_OF is defined. This problem was introduced in commit
> > 2f31b51659c2d8315ea2888ba5b93076febe672b
>
> same as previous patch. Abbreviated commit and commit subject.
Okay, I'll send v2 in a sec.
> > Cc: Tero Kristo <[email protected]>
> > Signed-off-by: Luciano Coelho <[email protected]>
>
> Reviewed-by: Felipe Balbi <[email protected]>
Thanks!
--
Cheers,
Luca.
On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
>
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
>
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined. This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b
same as previous patch. Abbreviated commit and commit subject.
> Cc: Tero Kristo <[email protected]>
> Signed-off-by: Luciano Coelho <[email protected]>
Reviewed-by: Felipe Balbi <[email protected]>
> ---
> arch/arm/mach-omap2/prm44xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
> #include "common.h"
> #include <plat/cpu.h>
> #include <plat/prcm.h>
> +#include <plat/irqs.h>
>
> #include "vp.h"
> #include "prm44xx.h"
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
Hello.
On 08-02-2012 14:59, Luciano Coelho wrote:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined. This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b
Please also specify the summary of that commit in parens.
> Cc: Tero Kristo<[email protected]>
> Signed-off-by: Luciano Coelho<[email protected]>
WBR, Sergei