2012-02-15 17:54:39

by Danny Kukawka

[permalink] [raw]
Subject: [PATCH] sdhci-tegra: fix linux/module.h included twice

Remove double include of linux/module.h.

Signed-off-by: Danny Kukawka <[email protected]>
---
drivers/mmc/host/sdhci-tegra.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index 78a36eb..cb34856 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -23,7 +23,6 @@
#include <linux/gpio.h>
#include <linux/mmc/card.h>
#include <linux/mmc/host.h>
-#include <linux/module.h>

#include <asm/gpio.h>

--
1.7.8.3


2012-02-15 18:38:18

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] sdhci-tegra: fix linux/module.h included twice

On Wed, Feb 15, 2012 at 9:54 AM, Danny Kukawka <[email protected]> wrote:
> Remove double include of linux/module.h.
>
> Signed-off-by: Danny Kukawka <[email protected]>

Obviously correct, not that Chris needs it but anyway:

Acked-by: Olof Johansson <[email protected]>


-Olof

2012-02-15 19:11:29

by Paul Gortmaker

[permalink] [raw]
Subject: Re: [PATCH] sdhci-tegra: fix linux/module.h included twice

On 12-02-15 12:54 PM, Danny Kukawka wrote:
> Remove double include of linux/module.h.
>
> Signed-off-by: Danny Kukawka <[email protected]>

Hi Danny,

We've already got these covered all in one go.

https://lkml.org/lkml/2012/2/4/134

Thanks,
Paul.

---

> ---
> drivers/mmc/host/sdhci-tegra.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 78a36eb..cb34856 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -23,7 +23,6 @@
> #include <linux/gpio.h>
> #include <linux/mmc/card.h>
> #include <linux/mmc/host.h>
> -#include <linux/module.h>
>
> #include <asm/gpio.h>
>

2012-02-15 20:46:49

by Danny Kukawka

[permalink] [raw]
Subject: Re: [PATCH] sdhci-tegra: fix linux/module.h included twice

On Mittwoch, 15. Februar 2012, Paul Gortmaker wrote:
> On 12-02-15 12:54 PM, Danny Kukawka wrote:
> > Remove double include of linux/module.h.
> >
> > Signed-off-by: Danny Kukawka <[email protected]>
>
> Hi Danny,
>
> We've already got these covered all in one go.
>
> https://lkml.org/lkml/2012/2/4/134

Okay, I checked mainline and linux-next and did a fast search over the Subject
on the ML and couldn't find these fixes.

Where they already applied to a tree?

Then you may want to ignore these of my mails:
- [PATCH] sdhci-tegra: fix linux/module.h included twice
- [PATCH] dwc3: linux/module.h included twice
-> https://lkml.org/lkml/2012/2/15/309
- [PATCH] drivers/dma: linux/module.h included twice
-> https://lkml.org/lkml/2012/2/15/351
- [PATCH] adp1653: included linux/module.h twice
-> https://lkml.org/lkml/2012/2/15/352
- [PATCH] Staging: sm7xx/smtcfb.c included linux/module.h twice
-> https://lkml.org/lkml/2012/2/15/355

Danny