2012-02-21 13:46:01

by Matthieu CASTET

[permalink] [raw]
Subject: re : PROBLEM: Data corruption when pasting large data to terminal

Hi,

> - I couldn't reproduce with cat-like applications, I have a feeling
> perhaps the bug only occurs in raw terminal mode, but I'm really not
> sure about this.

We saw in our case a possible data corruption in the tty layer :
in n_tty the n_tty_receive_buf can drop characters if it can't copy all of them
in the tty circular buffer.

A fix should be to remove tty->receive_room and make n_tty_receive_buf return
the number of bytes copied.

A patch to correct this was done in b1c43f82c5aa265442f82dba31ce985ebb7aa71c,
but it was reverted because it was buggy.

May be you should check that this is not your problem.


Matthieu