2012-02-24 06:41:08

by Meng Zhang (张萌)

Subject: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

from: Meng Zhang <[email protected]>

1. This patch is based on kernel 3.0.0
2. To declare the product IDs in option.c

Signed-off-by: Meng Zhang <[email protected]>
---------------------------------------------------------------------------------------

--- option.c 2012-02-23 10:42:40.635138657 +0800
+++ option.c.orig 2011-10-07 22:50:04.000000000 +0800
@@ -416,9 +416,6 @@ static void option_instat_callback(struc
#define SAMSUNG_VENDOR_ID 0x04e8
#define SAMSUNG_PRODUCT_GT_B3730 0x6889

-/* MediaTek products */
-#define MEDIATEK_VENDOR_ID 0x0e8d
-
/* some devices interfaces need special handling due to a number of reasons */
enum option_blacklist_reason {
OPTION_BLACKLIST_NONE = 0,
@@ -1008,10 +1005,6 @@ static const struct usb_device_id option
{ USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
CDMA 450 1xEVDO modem */
{ USB_DEVICE(ONDA_VENDOR_ID, ONDA_MT825UP) }, /* ONDA MT825UP modem */
{ USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /*
Samsung GT-B3730 LTE USB modem.*/
- { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
0x00, 0x00) },
- { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
0x02, 0x01) },
- { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
0x00, 0x00) },
- { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
0x02, 0x01) }, /* MediaTek MT6276M modem & app port */
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, option_ids);

2012-02-24 11:32:54

by Sergei Shtylyov

Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

Hello.

On 24-02-2012 10:41, meng zhang wrote:

> from: Meng Zhang<[email protected]>

> 1. This patch is based on kernel 3.0.0

You should base on the recent kernel instead.

> 2. To declare the product IDs in option.c

> Signed-off-by: Meng Zhang<[email protected]>
> ---------------------------------------------------------------------------------------

This line is not needed here.

> --- option.c 2012-02-23 10:42:40.635138657 +0800
> +++ option.c.orig 2011-10-07 22:50:04.000000000 +0800

The patch should be applicablke with -p1 switch, i.e. based on the linux
source root.

[...]
> @@ -1008,10 +1005,6 @@ static const struct usb_device_id option
> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> CDMA 450 1xEVDO modem */
> { USB_DEVICE(ONDA_VENDOR_ID, ONDA_MT825UP) }, /* ONDA MT825UP modem */
> { USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
> SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /*
> Samsung GT-B3730 LTE USB modem.*/
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x00, 0x00) },

You're not adding the device IDs, you're removing them.

> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x02, 0x01) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x00, 0x00) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x02, 0x01) }, /* MediaTek MT6276M modem& app port */

The patch is line wrapped.

WBR, Sergei

2012-02-24 15:45:40

by Greg KH

Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

On Fri, Feb 24, 2012 at 02:41:04PM +0800, meng zhang wrote:
> from: Meng Zhang <[email protected]>
>
> 1. This patch is based on kernel 3.0.0

That is quite old, please make it against Linus's latest git tree if
possible, and if not, against 3.3-rc4. And if not that, how about 3.3?

> 2. To declare the product IDs in option.c
>
> Signed-off-by: Meng Zhang <[email protected]>
> ---------------------------------------------------------------------------------------
>
> --- option.c 2012-02-23 10:42:40.635138657 +0800
> +++ option.c.orig 2011-10-07 22:50:04.000000000 +0800

Hm, I think you didn't read Documentation/SubmittingPatches for the
correct patch level to send things. Please fix this as our automated
tools can not handle this patch

> @@ -416,9 +416,6 @@ static void option_instat_callback(struc
> #define SAMSUNG_VENDOR_ID 0x04e8
> #define SAMSUNG_PRODUCT_GT_B3730 0x6889
>
> -/* MediaTek products */
> -#define MEDIATEK_VENDOR_ID 0x0e8d
> -
> /* some devices interfaces need special handling due to a number of reasons */
> enum option_blacklist_reason {
> OPTION_BLACKLIST_NONE = 0,
> @@ -1008,10 +1005,6 @@ static const struct usb_device_id option
> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> CDMA 450 1xEVDO modem */

Your patch is also linewrapped, making it impossible to apply :(

Care to try this again after fixing it?

greg k-h