(4/29/12 10:04 AM), Ulrich Drepper wrote:
> No one has definitely commented on this patch nor is it applied. Christoph at first said it shouldn't be done but I think he had to retract his objection. The interface is already out there. It's also IMO the right choice to go with a binary interface since there is so much data involved and the format is not tied directly to kernel-internal data structures.
>
> Could either the patch please be applied or a reason given why not?
>
>
> Signed-off-by: Ulrich Drepper<[email protected]>
>
linux/Documentation/vm/page-type.c has redundant definition of KPF_*. then, this exporting will solve it.
I'm going to ack if you can fix two things.
1) your current changelog looks like a chat log style. Please write formal changelog.
2) Please fix page-type.c too.
and pelase cc Wu Fengguang <[email protected]>. His last commit explicitly says kernel-page-flags.h
was intentionally made for user space tools. see below.
commit 1a9b5b7fe0c5dad8a635288882d36785dea742f9
Author: Wu Fengguang <[email protected]>
Date: Wed Dec 16 12:19:59 2009 +0100
mm: export stable page flags
Rename get_uflags() to stable_page_flags() and make it a global function
for use in the hwpoison page flags filter, which need to compare user
page flags with the value provided by user space.
Also move KPF_* to kernel-page-flags.h for use by user space tools.
Acked-by: Matt Mackall <[email protected]>
Signed-off-by: Andi Kleen <[email protected]>
CC: Nick Piggin <[email protected]>
CC: Christoph Lameter <[email protected]>
Signed-off-by: Wu Fengguang <[email protected]>
Signed-off-by: Andi Kleen <[email protected]>
On Tue, May 1, 2012 at 8:09 PM, KOSAKI Motohiro
<[email protected]> wrote:
> I'm going to ack if you can fix two things.
> 1) your current changelog looks like a chat log style. Please write formal changelog.
> 2) Please fix page-type.c too.
OK, done.
I've also sent a second patch to clean up page-type.c to compile more
cleanly with recent compilers. One more set of patches needed to
clean it up completely.