I've been seeing the following compile issue for a few -rcs now:
drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
'cpu_is_omap3430'
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
'omap_rev'
drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared
(first use in this function)
drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is
reported only once
drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
This still isn't fixed in Linus' HEAD. Any plans here?
thanks
-john
On Tue, May 1, 2012 at 11:33 PM, John Stultz <[email protected]> wrote:
> I've been seeing the following compile issue for a few -rcs now:
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'omap_rev'
> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared
> (first use in this function)
> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is
> reported only once
> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
>
> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
>
> This still isn't fixed in Linus' HEAD. Any plans here?
in fact the problem is related to this part of 1fcb57d0f6
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 95a2e54..c8aae66 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -25,7 +25,6 @@
#include <linux/clk.h>
#include <linux/dma-mapping.h>
#include <linux/spinlock.h>
-#include <linux/gpio.h>
#include <plat/usb.h>
#include <linux/pm_runtime.h>
by removing linux/gpio.h, we remove the inclusion of plat/cpu.h which
has the definition of cpu_is_omap3430()
On Tue, 01 May 2012 14:33:21 -0700 John Stultz <[email protected]> wrote:
>
> I've been seeing the following compile issue for a few -rcs now:
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'omap_rev'
> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared
> (first use in this function)
> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is
> reported only once
> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
>
> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
>
> This still isn't fixed in Linus' HEAD. Any plans here?
>
> thanks
> -john
Following fixes it for me.
NeilBrown
Author: NeilBrown <[email protected]>
Date: Wed Apr 25 10:52:05 2012 +1000
omap-usb-host: add include plat/cpu.h
Need this for a version comparison.
Signed-off-by: NeilBrown <[email protected]>
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index c8aae66..7da9496 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -26,6 +26,7 @@
#include <linux/dma-mapping.h>
#include <linux/spinlock.h>
#include <plat/usb.h>
+#include <plat/cpu.h>
#include <linux/pm_runtime.h>
#define USBHS_DRIVER_NAME "usbhs_omap"
Hi John,
On Tue, May 01, 2012 at 02:33:21PM -0700, John Stultz wrote:
>
> I've been seeing the following compile issue for a few -rcs now:
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of
> function 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of
> function 'omap_rev'
> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1'
> undeclared (first use in this function)
> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier
> is reported only once
> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
>
> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
>
> This still isn't fixed in Linus' HEAD. Any plans here?
I pushed the fixed to my for-linus branch yesterday. I'll send a pull request
to Linus in time for rc6.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
On 05/02/2012 12:46 AM, Samuel Ortiz wrote:
> Hi John,
>
> On Tue, May 01, 2012 at 02:33:21PM -0700, John Stultz wrote:
>> I've been seeing the following compile issue for a few -rcs now:
>> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
>> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of
>> function 'cpu_is_omap3430'
>> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of
>> function 'omap_rev'
>> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1'
>> undeclared (first use in this function)
>> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier
>> is reported only once
>> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
>>
>> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
>>
>> This still isn't fixed in Linus' HEAD. Any plans here?
> I pushed the fixed to my for-linus branch yesterday. I'll send a pull request
> to Linus in time for rc6.
>
Thanks!
-john