2012-05-03 00:08:51

by Hartley Sweeten

Subject: [PATCH] vme: vme_tsi148.c: local functions should not be exposed globally

Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.

Quiets the sparse warnings:

warning: symbol 'tsi148_alloc_consistent' was not declared. Should it be static?
warning: symbol 'tsi148_free_consistent' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Martyn Welch <[email protected]>

---

diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
index 081e9c4..f6385f7 100644
--- a/drivers/vme/bridges/vme_tsi148.c
+++ b/drivers/vme/bridges/vme_tsi148.c
@@ -2141,7 +2141,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)
return (int)slot;
}

-void *tsi148_alloc_consistent(struct device *parent, size_t size,
+static void *tsi148_alloc_consistent(struct device *parent, size_t size,
dma_addr_t *dma)
{
struct pci_dev *pdev;
@@ -2152,8 +2152,8 @@ void *tsi148_alloc_consistent(struct device *parent, size_t size,
return pci_alloc_consistent(pdev, size, dma);
}

-void tsi148_free_consistent(struct device *parent, size_t size, void *vaddr,
- dma_addr_t dma)
+static void tsi148_free_consistent(struct device *parent, size_t size,
+ void *vaddr, dma_addr_t dma)
{
struct pci_dev *pdev;

2012-05-03 15:55:43

by Martyn Welch

Subject: Re: [PATCH] vme: vme_tsi148.c: local functions should not be exposed globally

On 03/05/12 01:08, H Hartley Sweeten lin wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warnings:
>
> warning: symbol 'tsi148_alloc_consistent' was not declared. Should it be static?
> warning: symbol 'tsi148_free_consistent' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Martyn Welch <[email protected]>
>

Good catch,

Acked-by: Martyn Welch <[email protected]>

Martyn

> ---
>
> diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
> index 081e9c4..f6385f7 100644
> --- a/drivers/vme/bridges/vme_tsi148.c
> +++ b/drivers/vme/bridges/vme_tsi148.c
> @@ -2141,7 +2141,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)
> return (int)slot;
> }
>
> -void *tsi148_alloc_consistent(struct device *parent, size_t size,
> +static void *tsi148_alloc_consistent(struct device *parent, size_t size,
> dma_addr_t *dma)
> {
> struct pci_dev *pdev;
> @@ -2152,8 +2152,8 @@ void *tsi148_alloc_consistent(struct device *parent, size_t size,
> return pci_alloc_consistent(pdev, size, dma);
> }
>
> -void tsi148_free_consistent(struct device *parent, size_t size, void *vaddr,
> - dma_addr_t dma)
> +static void tsi148_free_consistent(struct device *parent, size_t size,
> + void *vaddr, dma_addr_t dma)
> {
> struct pci_dev *pdev;
>


--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E [email protected] | VAT:GB 927559189