2012-05-07 22:47:39

by Richard Weinberger

[permalink] [raw]
Subject: [PATCH] MTD: UBI: remove superfluous "!!" operation

!!(x < y) and (x < y) are identical expressions.

Signed-off-by: Richard Weinberger <[email protected]>
---
drivers/mtd/ubi/scan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/scan.c b/drivers/mtd/ubi/scan.c
index 12c43b4..8d24435 100644
--- a/drivers/mtd/ubi/scan.c
+++ b/drivers/mtd/ubi/scan.c
@@ -337,7 +337,7 @@ static int compare_lebs(struct ubi_device *ubi, const struct ubi_scan_leb *seb,
}

/* Obviously the LEB with lower sequence counter is older */
- second_is_newer = !!(sqnum2 > seb->sqnum);
+ second_is_newer = (sqnum2 > seb->sqnum);

/*
* Now we know which copy is newer. If the copy flag of the PEB with
--
1.7.7.3


2012-05-08 07:29:38

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH] MTD: UBI: remove superfluous "!!" operation

On Tue, 2012-05-08 at 00:47 +0200, Richard Weinberger wrote:
> !!(x < y) and (x < y) are identical expressions.
>
> Signed-off-by: Richard Weinberger <[email protected]>

Thanks, pushed to l2-mtd.git.

Since you are submitting often, you may save me a bit of editing if you
prefix UBI patches with just "UBI:" :-) But I do not mind amending
patches if you don't.

Thanks!

--
Best Regards,
Artem Bityutskiy


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part

2012-05-08 07:31:20

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH] MTD: UBI: remove superfluous "!!" operation

Am 08.05.2012 09:32, schrieb Artem Bityutskiy:
> Since you are submitting often, you may save me a bit of editing if you
> prefix UBI patches with just "UBI:" :-) But I do not mind amending
> patches if you don't.
>

Will do. :)

Thanks,
//richard


Attachments:
signature.asc (490.00 B)
OpenPGP digital signature