2012-05-03 00:17:42

by Hartley Sweeten

[permalink] [raw]
Subject: [PATCH] video: smscufx.c: local functions should not be exposed globally

Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.

Quiets the sparse warnings:

warning: symbol 'ufx_handle_damage' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Steve Glendinning <[email protected]>
Cc: Florian Tobias Schandinat <[email protected]>

---

diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c
index 9985785..af3ef27 100644
--- a/drivers/video/smscufx.c
+++ b/drivers/video/smscufx.c
@@ -846,7 +846,7 @@ static void ufx_raw_rect(struct ufx_data *dev, u16 *cmd, int x, int y,
}
}

-int ufx_handle_damage(struct ufx_data *dev, int x, int y,
+static int ufx_handle_damage(struct ufx_data *dev, int x, int y,
int width, int height)
{
size_t packed_line_len = ALIGN((width * 2), 4);


Subject: Re: [PATCH] video: smscufx.c: local functions should not be exposed globally

On 05/03/2012 12:17 AM, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warnings:
>
> warning: symbol 'ufx_handle_damage' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Steve Glendinning <[email protected]>
> Cc: Florian Tobias Schandinat <[email protected]>

Applied.


Thanks,

Florian Tobias Schandinat

>
> ---
>
> diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c
> index 9985785..af3ef27 100644
> --- a/drivers/video/smscufx.c
> +++ b/drivers/video/smscufx.c
> @@ -846,7 +846,7 @@ static void ufx_raw_rect(struct ufx_data *dev, u16 *cmd, int x, int y,
> }
> }
>
> -int ufx_handle_damage(struct ufx_data *dev, int x, int y,
> +static int ufx_handle_damage(struct ufx_data *dev, int x, int y,
> int width, int height)
> {
> size_t packed_line_len = ALIGN((width * 2), 4);
>