2012-05-03 00:23:47

by Hartley Sweeten

[permalink] [raw]
Subject: [PATCH] video: fb_defio.c: local functions should not be exposed globally

Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.

Quiets the sparse warning:

warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Jaya Kumar <[email protected]>
Cc: Florian Tobias Schandinat <[email protected]>

---

diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index 070f26f..1ddeb11 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -23,7 +23,7 @@
#include <linux/rmap.h>
#include <linux/pagemap.h>

-struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
{
void *screen_base = (void __force *) info->screen_base;
struct page *page;


Subject: Re: [PATCH] video: fb_defio.c: local functions should not be exposed globally

On 05/03/2012 12:23 AM, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warning:
>
> warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Jaya Kumar <[email protected]>
> Cc: Florian Tobias Schandinat <[email protected]>

Applied.


Thanks,

Florian Tobias Schandinat

>
> ---
>
> diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
> index 070f26f..1ddeb11 100644
> --- a/drivers/video/fb_defio.c
> +++ b/drivers/video/fb_defio.c
> @@ -23,7 +23,7 @@
> #include <linux/rmap.h>
> #include <linux/pagemap.h>
>
> -struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
> +static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
> {
> void *screen_base = (void __force *) info->screen_base;
> struct page *page;
>