From: Xiao Jiang <[email protected]>
commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
which possibly use "usb%d" names, add this flag to make sure pandaboard
can mount nfs with smsc95xx NIC.
Signed-off-by: Xiao Jiang <[email protected]>
---
drivers/net/usb/smsc95xx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 94ae669..e158288 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -1192,7 +1192,8 @@ static const struct driver_info smsc95xx_info = {
.rx_fixup = smsc95xx_rx_fixup,
.tx_fixup = smsc95xx_tx_fixup,
.status = smsc95xx_status,
- .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
+ .flags = FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_SEND_ZLP |
+ FLAG_LINK_INTR,
};
static const struct usb_device_id products[] = {
--
1.7.3
On Wed, 2012-05-16 at 16:01 +0800, [email protected] wrote:
> From: Xiao Jiang <[email protected]>
>
> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
> which possibly use "usb%d" names, add this flag to make sure pandaboard
> can mount nfs with smsc95xx NIC.
These are normal Ethernet interfaces, whereas FLAG_POINTTOPOINT is for
devices that use non-standard short physical links.
Ben.
> Signed-off-by: Xiao Jiang <[email protected]>
> ---
> drivers/net/usb/smsc95xx.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 94ae669..e158288 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1192,7 +1192,8 @@ static const struct driver_info smsc95xx_info = {
> .rx_fixup = smsc95xx_rx_fixup,
> .tx_fixup = smsc95xx_tx_fixup,
> .status = smsc95xx_status,
> - .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
> + .flags = FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_SEND_ZLP |
> + FLAG_LINK_INTR,
> };
>
> static const struct usb_device_id products[] = {
--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.
On Wed, May 16, 2012 at 4:01 PM, <[email protected]> wrote:
> From: Xiao Jiang <[email protected]>
>
> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
> which possibly use "usb%d" names, add this flag to make sure pandaboard
> can mount nfs with smsc95xx NIC.
Without the flag, I also can mount nfs successfully on my Pandaboard...
>
> Signed-off-by: Xiao Jiang <[email protected]>
> ---
> ?drivers/net/usb/smsc95xx.c | ? ?3 ++-
> ?1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 94ae669..e158288 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1192,7 +1192,8 @@ static const struct driver_info smsc95xx_info = {
> ? ? ? ?.rx_fixup ? ? ? = smsc95xx_rx_fixup,
> ? ? ? ?.tx_fixup ? ? ? = smsc95xx_tx_fixup,
> ? ? ? ?.status ? ? ? ? = smsc95xx_status,
> - ? ? ? .flags ? ? ? ? ?= FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
> + ? ? ? .flags ? ? ? ? ?= FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_SEND_ZLP |
> + ? ? ? ? ? ? ? ? ? ? ? ? FLAG_LINK_INTR,
> ?};
>
> ?static const struct usb_device_id products[] = {
> --
> 1.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/
Thanks,
--
Ming Lei
Hello.
On 16-05-2012 12:01, [email protected] wrote:
> From: Xiao Jiang<[email protected]>
> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
Please also specify that commit's summary in parens.
> which possibly use "usb%d" names, add this flag to make sure pandaboard
> can mount nfs with smsc95xx NIC.
> Signed-off-by: Xiao Jiang<[email protected]>
WBR, Sergei
Ming Lei wrote:
> On Wed, May 16, 2012 at 4:01 PM, <[email protected]> wrote:
>
>> From: Xiao Jiang <[email protected]>
>>
>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>> can mount nfs with smsc95xx NIC.
>>
>
> Without the flag, I also can mount nfs successfully on my Pandaboard...
>
>
I have pulled latest tree
(git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
commit 0e93b4b304ae052ba1bc73f6d34a68556fe93429), and enable related
options (USB_NET_SMSC95XX,
USB_EHCI_HCD and USB_EHCI_HCD_OMAP) with omap2plus_config, However the
kernel still can't mount
nfs, pls see below infos.
[ 3.114105] smsc95xx v1.0.4
[ 4.533752] smsc95xx 1-1.1:1.0: *eth0*: register 'smsc95xx' at
usb-ehci-omap.0-1.1, smsc95xx USB 2.0 Ethernet, fe:b9:1b:07:8e:d1
[ 108.854217] VFS: Unable to mount root fs via NFS, trying floppy.
[ 108.861114] VFS: Cannot open root device "nfs" or unknown-block(2,0):
error -6
[ 108.868713] Please append a correct "root=" boot option; here are the
available partitions:
[ 108.877655] b300 7761920 mmcblk0 driver: mmcblk
[ 108.883239] b301 40131 mmcblk0p1
00000000-0000-0000-0000-000000000mmcblk0p1
[ 108.891662] b302 7719232 mmcblk0p2
00000000-0000-0000-0000-000000000mmcblk0p2
[ 108.900146] Kernel panic - not syncing: VFS: Unable to mount root fs
on unknown-block(2,0)
BTW: I tested it with OMAP4430 ES2.2 pandaboard, the issue can be solved
with apply the patch.
Is there something which I missed? thanks.
Regards,
Xiao
>> Signed-off-by: Xiao Jiang <[email protected]>
>> ---
>> drivers/net/usb/smsc95xx.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
>> index 94ae669..e158288 100644
>> --- a/drivers/net/usb/smsc95xx.c
>> +++ b/drivers/net/usb/smsc95xx.c
>> @@ -1192,7 +1192,8 @@ static const struct driver_info smsc95xx_info = {
>> .rx_fixup = smsc95xx_rx_fixup,
>> .tx_fixup = smsc95xx_tx_fixup,
>> .status = smsc95xx_status,
>> - .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
>> + .flags = FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_SEND_ZLP |
>> + FLAG_LINK_INTR,
>> };
>>
>> static const struct usb_device_id products[] = {
>> --
>> 1.7.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
>
> Thanks,
>
Sergei Shtylyov wrote:
> Hello.
>
> On 16-05-2012 12:01, [email protected] wrote:
>
>> From: Xiao Jiang<[email protected]>
>
>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>
> Please also specify that commit's summary in parens.
Thanks, will add the summary if this patch does make sense.
Regards,
Xiao
>
>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>> can mount nfs with smsc95xx NIC.
>
>> Signed-off-by: Xiao Jiang<[email protected]>
>
> WBR, Sergei
Ben Hutchings wrote:
> On Wed, 2012-05-16 at 16:01 +0800, [email protected] wrote:
>
>> From: Xiao Jiang <[email protected]>
>>
>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>> can mount nfs with smsc95xx NIC.
>>
>
> These are normal Ethernet interfaces, whereas FLAG_POINTTOPOINT is for
> devices that use non-standard short physical links.
>
>
This flag is used by some usb NICs, I amn't familiar with those cards
perhaps those are
non-standard short physical links as you said.
But smsc95xx seems need this flag to use "usb%d" name, at least my
pandaboard can't
mount nfs with eth0 name, is there other ways to avoid nfs issue with
keep smsc95xx's
name unchange? thanks.
-bash-3.2$ grep FLAG_POINTTOPOINT * -r
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/cdc_ncm.c: .flags = FLAG_POINTTOPOINT |
FLAG_NO_SETINT | FLAG_MULTI_PACKET,
drivers/net/usb/gl620a.c: .flags = FLAG_POINTTOPOINT |
FLAG_FRAMING_GL | FLAG_NO_SETINT,
drivers/net/usb/plusb.c: .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT,
drivers/net/usb/usbnet.c: ((dev->driver_info->flags &
FLAG_POINTTOPOINT) == 0 ||
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_eem.c: .flags = FLAG_ETHER | FLAG_POINTTOPOINT,
drivers/net/usb/rndis_host.c: .flags = FLAG_ETHER |
FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
drivers/net/usb/rndis_host.c: .flags = FLAG_ETHER |
FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
drivers/net/usb/cdc_ether.c: .flags = FLAG_ETHER | FLAG_POINTTOPOINT,
drivers/net/usb/net1080.c: .flags = FLAG_POINTTOPOINT |
FLAG_FRAMING_NC,
include/linux/usb/usbnet.h:#define FLAG_POINTTOPOINT 0x1000 /*
possibly use "usb%d" names */
Regards,
Xiao
> Ben.
>
>
>> Signed-off-by: Xiao Jiang <[email protected]>
>> ---
>> drivers/net/usb/smsc95xx.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
>> index 94ae669..e158288 100644
>> --- a/drivers/net/usb/smsc95xx.c
>> +++ b/drivers/net/usb/smsc95xx.c
>> @@ -1192,7 +1192,8 @@ static const struct driver_info smsc95xx_info = {
>> .rx_fixup = smsc95xx_rx_fixup,
>> .tx_fixup = smsc95xx_tx_fixup,
>> .status = smsc95xx_status,
>> - .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
>> + .flags = FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_SEND_ZLP |
>> + FLAG_LINK_INTR,
>> };
>>
>> static const struct usb_device_id products[] = {
>>
>
>
On Thu, May 17, 2012 at 10:23 AM, Xiao Jiang <[email protected]> wrote:
> Ming Lei wrote:
>>
>> On Wed, May 16, 2012 at 4:01 PM, ?<[email protected]> wrote:
>>
>>>
>>> From: Xiao Jiang <[email protected]>
>>>
>>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>>> can mount nfs with smsc95xx NIC.
>>>
>>
>>
>> Without the flag, I also can mount nfs successfully on my Pandaboard...
I always mount nfs in console, and not tried to mount nfs as root fs.
>>
>>
>
> I have pulled latest tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> commit 0e93b4b304ae052ba1bc73f6d34a68556fe93429), and enable related options
> (USB_NET_SMSC95XX,
> USB_EHCI_HCD and USB_EHCI_HCD_OMAP) with omap2plus_config, However the
> kernel still can't mount
> nfs, pls see below infos.
>
> [ ? ?3.114105] smsc95xx v1.0.4
> [ ? ?4.533752] smsc95xx 1-1.1:1.0: *eth0*: register 'smsc95xx' at
> usb-ehci-omap.0-1.1, smsc95xx USB 2.0 Ethernet, fe:b9:1b:07:8e:d1
> [ ?108.854217] VFS: Unable to mount root fs via NFS, trying floppy.
> [ ?108.861114] VFS: Cannot open root device "nfs" or unknown-block(2,0):
> error -6
> [ ?108.868713] Please append a correct "root=" boot option; here are the
> available partitions:
> [ ?108.877655] b300 ? ? ? ? 7761920 mmcblk0 ?driver: mmcblk
> [ ?108.883239] ? b301 ? ? ? ? ? 40131 mmcblk0p1
> 00000000-0000-0000-0000-000000000mmcblk0p1
> [ ?108.891662] ? b302 ? ? ? ? 7719232 mmcblk0p2
> 00000000-0000-0000-0000-000000000mmcblk0p2
> [ ?108.900146] Kernel panic - not syncing: VFS: Unable to mount root fs on
> unknown-block(2,0)
>
> BTW: I tested it with OMAP4430 ES2.2 pandaboard, the issue can be solved
> with apply the patch.
>
> Is there something which I missed? thanks.
What is your kernel parameter? Maybe you use 'usb%d' in kernel parameter for
mounting nfs as root fs. If so, could you try 'eth%d' in kernel cmd?
In fact, smsc95xx is a real LAN interface, and 'eth%d' should be prefered name
as described in changelog of commit
c261344d3ce3edac781f9d3c7eabe2e96d8e8fe8(usbnet:use eth%d name for
known ethernet devices)
Thanks,
--
Ming Lei
Ming Lei wrote:
> On Thu, May 17, 2012 at 10:23 AM, Xiao Jiang <[email protected]> wrote:
>
>> Ming Lei wrote:
>>
>>> On Wed, May 16, 2012 at 4:01 PM, <[email protected]> wrote:
>>>
>>>
>>>> From: Xiao Jiang <[email protected]>
>>>>
>>>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>>>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>>>> can mount nfs with smsc95xx NIC.
>>>>
>>>>
>>> Without the flag, I also can mount nfs successfully on my Pandaboard...
>>>
>
> I always mount nfs in console, and not tried to mount nfs as root fs.
>
>
>>>
>> I have pulled latest tree
>> (git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> commit 0e93b4b304ae052ba1bc73f6d34a68556fe93429), and enable related options
>> (USB_NET_SMSC95XX,
>> USB_EHCI_HCD and USB_EHCI_HCD_OMAP) with omap2plus_config, However the
>> kernel still can't mount
>> nfs, pls see below infos.
>>
>> [ 3.114105] smsc95xx v1.0.4
>> [ 4.533752] smsc95xx 1-1.1:1.0: *eth0*: register 'smsc95xx' at
>> usb-ehci-omap.0-1.1, smsc95xx USB 2.0 Ethernet, fe:b9:1b:07:8e:d1
>> [ 108.854217] VFS: Unable to mount root fs via NFS, trying floppy.
>> [ 108.861114] VFS: Cannot open root device "nfs" or unknown-block(2,0):
>> error -6
>> [ 108.868713] Please append a correct "root=" boot option; here are the
>> available partitions:
>> [ 108.877655] b300 7761920 mmcblk0 driver: mmcblk
>> [ 108.883239] b301 40131 mmcblk0p1
>> 00000000-0000-0000-0000-000000000mmcblk0p1
>> [ 108.891662] b302 7719232 mmcblk0p2
>> 00000000-0000-0000-0000-000000000mmcblk0p2
>> [ 108.900146] Kernel panic - not syncing: VFS: Unable to mount root fs on
>> unknown-block(2,0)
>>
>> BTW: I tested it with OMAP4430 ES2.2 pandaboard, the issue can be solved
>> with apply the patch.
>>
>> Is there something which I missed? thanks.
>>
>
> What is your kernel parameter? Maybe you use 'usb%d' in kernel parameter for
> mounting nfs as root fs. If so, could you try 'eth%d' in kernel cmd?
>
> In fact, smsc95xx is a real LAN interface, and 'eth%d' should be prefered name
> as described in changelog of commit
> c261344d3ce3edac781f9d3c7eabe2e96d8e8fe8(usbnet:use eth%d name for
> known ethernet devices)
>
>
Thanks for your notice, I used wrong kernel parameter.
Regards,
Xiao
> Thanks,
>
On Thu, 2012-05-17 at 16:40 +0800, Xiao Jiang wrote:
> Ben Hutchings wrote:
> > On Wed, 2012-05-16 at 16:01 +0800, [email protected] wrote:
> >
> >> From: Xiao Jiang <[email protected]>
> >>
> >> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
> >> which possibly use "usb%d" names, add this flag to make sure pandaboard
> >> can mount nfs with smsc95xx NIC.
> >>
> >
> > These are normal Ethernet interfaces, whereas FLAG_POINTTOPOINT is for
> > devices that use non-standard short physical links.
> >
> >
> This flag is used by some usb NICs, I amn't familiar with those cards
> perhaps those are
> non-standard short physical links as you said.
> But smsc95xx seems need this flag to use "usb%d" name,
But this is a regular Ethernet interface and should be named
accordingly.
> at least my
> pandaboard can't
> mount nfs with eth0 name, is there other ways to avoid nfs issue with
> keep smsc95xx's
> name unchange? thanks.
[...]
I don't know what this NFS issue is, but I don't see how this can be the
correct solution.
Ben.
--
Ben Hutchings
Every program is either trivial or else contains at least one bug