2012-05-21 21:22:13

by Alex Buell

Subject: 3.4: Build failure for lpfc_scsi driver

cc1: warnings being treated as errors
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl’:
drivers/scsi/lpfc/lpfc_scsi.c:1900:11: error: unused variable ‘rc’
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl_prot’:
drivers/scsi/lpfc/lpfc_scsi.c:2037:11: error: unused variable ‘rc’
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl’:
drivers/scsi/lpfc/lpfc_scsi.c:2256:11: error: unused variable ‘rc’
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl_prot’:
drivers/scsi/lpfc/lpfc_scsi.c:2386:11: error: unused variable ‘rc’

Easily fixed though but all the other warnings previously seen were fine
yet this module was compiled with warnings being treated as errors?
--
Tactical Nuclear Kittens

2012-05-21 21:31:43

by Tobias Klausmann

Subject: Re: 3.4: Build failure for lpfc_scsi driver

On 21.05.2012 23:16, Alex Buell wrote:
> cc1: warnings being treated as errors
> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl’:
> drivers/scsi/lpfc/lpfc_scsi.c:1900:11: error: unused variable ‘rc’
> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_bpl_prot’:
> drivers/scsi/lpfc/lpfc_scsi.c:2037:11: error: unused variable ‘rc’
> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl’:
> drivers/scsi/lpfc/lpfc_scsi.c:2256:11: error: unused variable ‘rc’
> drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bg_setup_sgl_prot’:
> drivers/scsi/lpfc/lpfc_scsi.c:2386:11: error: unused variable ‘rc’
>
> Easily fixed though but all the other warnings previously seen were fine
> yet this module was compiled with warnings being treated as errors?
Had this reported already. The flag in the Makefile for this driver was
introduced between v3.3 and v3.4-rc1, in earlier versions it was
compiled without it. If you don't actually need it just remove the flag
and it will compile just fine!