2012-05-25 20:59:13

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: linux-next: triage for April 19, 2012

On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
<[email protected]> wrote:
> The parisc got borked by some kvm header shuffle it seems?
> Now complaining about "file 'asm-generic/kvm_para.h' is not exported"
> [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]

Not only parisc.

This breakage has now entered mainline:

parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
m68k allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


2012-05-25 22:08:22

by Paul Gortmaker

[permalink] [raw]
Subject: Re: linux-next: triage for April 19, 2012

On 12-05-25 04:59 PM, Geert Uytterhoeven wrote:
> On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
> <[email protected]> wrote:
>> The parisc got borked by some kvm header shuffle it seems?
>> Now complaining about "file 'asm-generic/kvm_para.h' is not exported"
>> [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]
>
> Not only parisc.
>
> This breakage has now entered mainline:
>
> parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
> m68k allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/

See also this thread:

http://www.spinics.net/lists/kvm/msg72785.html

Paul.


>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

2012-05-26 09:39:11

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: linux-next: triage for April 19, 2012

Hi Paul,

On Sat, May 26, 2012 at 12:08 AM, Paul Gortmaker
<[email protected]> wrote:
> On 12-05-25 04:59 PM, Geert Uytterhoeven wrote:
>> On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
>> <[email protected]> wrote:
>>> The parisc got borked by some kvm header shuffle it seems?
>>> Now complaining about "file 'asm-generic/kvm_para.h' is not exported"
>>> [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]
>>
>> Not only parisc.
>>
>> This breakage has now entered mainline:
>>
>> parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
>> m68k allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/
>
> See also this thread:
>
> http://www.spinics.net/lists/kvm/msg72785.html

I saw it. But it doesn't contain a fix for this, does it?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

2012-05-28 14:37:56

by Avi Kivity

[permalink] [raw]
Subject: Re: linux-next: triage for April 19, 2012

On 05/25/2012 11:59 PM, Geert Uytterhoeven wrote:
> On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
> <[email protected]> wrote:
>> The parisc got borked by some kvm header shuffle it seems?
>> Now complaining about "file 'asm-generic/kvm_para.h' is not exported"
>> [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]
>
> Not only parisc.
>
> This breakage has now entered mainline:
>
> parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
> m68k allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/


Does the following patch help?

I was unable to find a cross compiler, so I can't test it myself.


From: Avi Kivity <[email protected]>
Date: Mon, 28 May 2012 17:35:22 +0300
Subject: [PATCH] KVM: Export asm-generic/kvm_para.h

Prevents build failures on non-KVM archs.

Signed-off-by: Avi Kivity <[email protected]>
---
include/asm-generic/Kbuild | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
index 53f91b1..2c85a0f 100644
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -8,6 +8,7 @@ header-y += int-ll64.h
header-y += ioctl.h
header-y += ioctls.h
header-y += ipcbuf.h
+header-y += kvm_para.h
header-y += mman-common.h
header-y += mman.h
header-y += msgbuf.h

--
error compiling committee.c: too many arguments to function

2012-05-28 15:04:24

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: linux-next: triage for April 19, 2012

Hi Avi,

On Mon, May 28, 2012 at 4:37 PM, Avi Kivity <[email protected]> wrote:
> On 05/25/2012 11:59 PM, Geert Uytterhoeven wrote:
>> On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
>> <[email protected]> wrote:
>>> The parisc got borked by some kvm header shuffle it seems?
>>> Now complaining about "file 'asm-generic/kvm_para.h' is not exported"
>>> [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]
>>
>> Not only parisc.
>>
>> This breakage has now entered mainline:
>>
>> parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
>> m68k allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/
>
>
> Does the following patch help?

Thanks, that fixes it!

Tested-by: Geert Uytterhoeven <[email protected]>

> From: Avi Kivity <[email protected]>
> Date: Mon, 28 May 2012 17:35:22 +0300
> Subject: [PATCH] KVM: Export asm-generic/kvm_para.h
>
> Prevents build failures on non-KVM archs.
>
> Signed-off-by: Avi Kivity <[email protected]>
> ---
>  include/asm-generic/Kbuild |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
> index 53f91b1..2c85a0f 100644
> --- a/include/asm-generic/Kbuild
> +++ b/include/asm-generic/Kbuild
> @@ -8,6 +8,7 @@ header-y += int-ll64.h
>  header-y += ioctl.h
>  header-y += ioctls.h
>  header-y += ipcbuf.h
> +header-y += kvm_para.h
>  header-y += mman-common.h
>  header-y += mman.h
>  header-y += msgbuf.h
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

2012-05-30 08:52:18

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: linux-next: triage for April 19, 2012

Hi Kbuild people,

On Mon, May 28, 2012 at 5:04 PM, Geert Uytterhoeven
<[email protected]> wrote:
> On Mon, May 28, 2012 at 4:37 PM, Avi Kivity <[email protected]> wrote:
>> On 05/25/2012 11:59 PM, Geert Uytterhoeven wrote:
>>> On Fri, Apr 20, 2012 at 4:00 AM, Paul Gortmaker
>>> <[email protected]> wrote:
>>>> The parisc got borked by some kvm header shuffle it seems?
>>>> Now complaining about "file 'asm-generic/kvm_para.h' is not exported"
>>>> [ http://kisskb.ellerman.id.au/kisskb/buildresult/6137786/ ]
>>>
>>> Not only parisc.
>>>
>>> This breakage has now entered mainline:
>>>
>>> parisc deconfig http://kisskb.ellerman.id.au/kisskb/buildresult/6365677/
>>> m68k allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/6365681/
>>
>>
>> Does the following patch help?
>
> Thanks, that fixes it!
>
> Tested-by: Geert Uytterhoeven <[email protected]>
>
>> From: Avi Kivity <[email protected]>
>> Date: Mon, 28 May 2012 17:35:22 +0300
>> Subject: [PATCH] KVM: Export asm-generic/kvm_para.h
>>
>> Prevents build failures on non-KVM archs.
>>
>> Signed-off-by: Avi Kivity <[email protected]>
>> ---
>>  include/asm-generic/Kbuild |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
>> index 53f91b1..2c85a0f 100644
>> --- a/include/asm-generic/Kbuild
>> +++ b/include/asm-generic/Kbuild
>> @@ -8,6 +8,7 @@ header-y += int-ll64.h
>>  header-y += ioctl.h
>>  header-y += ioctls.h
>>  header-y += ipcbuf.h
>> +header-y += kvm_para.h
>>  header-y += mman-common.h
>>  header-y += mman.h
>>  header-y += msgbuf.h

I just noticed include/asm-generic/Kbuild.asm already had

ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
$(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
header-y += kvm_para.h
endif

but this doesn't seem to work.

Kbuild people: which one is correct?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds