2012-05-30 01:39:50

by Asai Thambi SP

Subject: [PATCH 00/11] mtip32xx: Number of small tweaks and a new sysfs entry

This patchset includes number of small tweaks and adds a new sysfs entry 'flags'

Asai Thambi S P (11):
mtip32xx: fix clearing an incorrect register in mtip_init_port
mtip32xx: Set custom timeouts for PIO commands
mtip32xx: Change HDIO_GET_IDENTITY to return stored data
mtip32xx: Fix to handle TFE for PIO(IOCTL/internal) commands
mtip32xx: Set block queue boundary variables
mtip32xx: Use plain spinlock for 'cmd_issue_lock'
mtip32xx: Fix to support more than one sector in exec_drive_command()
mtip32xx: minor performance tweak
mtip32xx: Convert macro definitions for flag bits to enum
mtip32xx: Changes to sysfs entries
mtip32xx: Change disk capacity unit from MB to MiB

Documentation/ABI/testing/sysfs-block-rssd | 12 +-
drivers/block/mtip32xx/mtip32xx.c | 279 +++++++++++++++++-----------
drivers/block/mtip32xx/mtip32xx.h | 48 +++---
3 files changed, 209 insertions(+), 130 deletions(-)

2012-05-31 06:46:24

by Jens Axboe

Subject: Re: [PATCH 00/11] mtip32xx: Number of small tweaks and a new sysfs entry

On 05/30/2012 03:39 AM, Asai Thambi S P wrote:
> This patchset includes number of small tweaks and adds a new sysfs entry 'flags'
>
> Asai Thambi S P (11):
> mtip32xx: fix clearing an incorrect register in mtip_init_port
> mtip32xx: Set custom timeouts for PIO commands
> mtip32xx: Change HDIO_GET_IDENTITY to return stored data
> mtip32xx: Fix to handle TFE for PIO(IOCTL/internal) commands
> mtip32xx: Set block queue boundary variables
> mtip32xx: Use plain spinlock for 'cmd_issue_lock'
> mtip32xx: Fix to support more than one sector in exec_drive_command()
> mtip32xx: minor performance tweak
> mtip32xx: Convert macro definitions for flag bits to enum
> mtip32xx: Changes to sysfs entries
> mtip32xx: Change disk capacity unit from MB to MiB

Looks fine, only real issue was with 5/5. I've fixed up that patch and
applied all 11, thanks.

--
Jens Axboe

2012-05-31 15:59:48

by Asai Thambi SP

Subject: Re: [PATCH 00/11] mtip32xx: Number of small tweaks and a new sysfs entry

On 5/30/2012 11:45 PM, Jens Axboe wrote:

> On 05/30/2012 03:39 AM, Asai Thambi S P wrote:
>> This patchset includes number of small tweaks and adds a new sysfs entry 'flags'
>>
>> Asai Thambi S P (11):
>> mtip32xx: fix clearing an incorrect register in mtip_init_port
>> mtip32xx: Set custom timeouts for PIO commands
>> mtip32xx: Change HDIO_GET_IDENTITY to return stored data
>> mtip32xx: Fix to handle TFE for PIO(IOCTL/internal) commands
>> mtip32xx: Set block queue boundary variables
>> mtip32xx: Use plain spinlock for 'cmd_issue_lock'
>> mtip32xx: Fix to support more than one sector in exec_drive_command()
>> mtip32xx: minor performance tweak
>> mtip32xx: Convert macro definitions for flag bits to enum
>> mtip32xx: Changes to sysfs entries
>> mtip32xx: Change disk capacity unit from MB to MiB
>
> Looks fine, only real issue was with 5/5. I've fixed up that patch and
> applied all 11, thanks.
>


Thanks.