Set the following block queue boundary variables
* max_hw_sectors
* max_segment_size
* nr_requests
Signed-off-by: Asai Thambi S P <[email protected]>
---
drivers/block/mtip32xx/mtip32xx.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 9fe897d..801e70c 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3631,7 +3631,11 @@ skip_create_disk:
set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
blk_queue_physical_block_size(dd->queue, 4096);
+ blk_queue_max_hw_sectors(dd->queue, 0xffff);
+ blk_queue_max_segment_size(dd->queue, 0x400000);
blk_queue_io_min(dd->queue, 4096);
+ dd->queue->nr_requests = 255;
+
/*
* write back cache is not supported in the device. FUA depends on
* write back cache support, hence setting flush support to zero.
--
1.7.1
On 05/30/2012 03:42 AM, Asai Thambi S P wrote:
>
> Set the following block queue boundary variables
> * max_hw_sectors
> * max_segment_size
> * nr_requests
>
> Signed-off-by: Asai Thambi S P <[email protected]>
> ---
> drivers/block/mtip32xx/mtip32xx.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 9fe897d..801e70c 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -3631,7 +3631,11 @@ skip_create_disk:
> set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
> blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
> blk_queue_physical_block_size(dd->queue, 4096);
> + blk_queue_max_hw_sectors(dd->queue, 0xffff);
> + blk_queue_max_segment_size(dd->queue, 0x400000);
> blk_queue_io_min(dd->queue, 4096);
> + dd->queue->nr_requests = 255;
->nr_requests isn't a boundary variable you set for the queue. It's set
by the core bits, or by the user via the sysfs interface.
So you should not touch that from the driver.
--
Jens Axboe
On 5/30/2012 11:43 PM, Jens Axboe wrote:
> On 05/30/2012 03:42 AM, Asai Thambi S P wrote:
>>
>> Set the following block queue boundary variables
>> * max_hw_sectors
>> * max_segment_size
>> * nr_requests
>>
>> Signed-off-by: Asai Thambi S P <[email protected]>
>> ---
>> drivers/block/mtip32xx/mtip32xx.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
>> index 9fe897d..801e70c 100644
>> --- a/drivers/block/mtip32xx/mtip32xx.c
>> +++ b/drivers/block/mtip32xx/mtip32xx.c
>> @@ -3631,7 +3631,11 @@ skip_create_disk:
>> set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
>> blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
>> blk_queue_physical_block_size(dd->queue, 4096);
>> + blk_queue_max_hw_sectors(dd->queue, 0xffff);
>> + blk_queue_max_segment_size(dd->queue, 0x400000);
>> blk_queue_io_min(dd->queue, 4096);
>> + dd->queue->nr_requests = 255;
>
> ->nr_requests isn't a boundary variable you set for the queue. It's set
> by the core bits, or by the user via the sysfs interface.
>
> So you should not touch that from the driver.
>
Ok.
I saw scsi lib module changing it, so thought of changing the value close to
device queue depth.
--
Regards,
Asai Thambi
Asai Thambi S P <[email protected]> writes:
> On 5/30/2012 11:43 PM, Jens Axboe wrote:
>
>> On 05/30/2012 03:42 AM, Asai Thambi S P wrote:
>>>
>>> Set the following block queue boundary variables
>>> * max_hw_sectors
>>> * max_segment_size
>>> * nr_requests
>>>
>>> Signed-off-by: Asai Thambi S P <[email protected]>
>>> ---
>>> drivers/block/mtip32xx/mtip32xx.c | 4 ++++
>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
>>> index 9fe897d..801e70c 100644
>>> --- a/drivers/block/mtip32xx/mtip32xx.c
>>> +++ b/drivers/block/mtip32xx/mtip32xx.c
>>> @@ -3631,7 +3631,11 @@ skip_create_disk:
>>> set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
>>> blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
>>> blk_queue_physical_block_size(dd->queue, 4096);
>>> + blk_queue_max_hw_sectors(dd->queue, 0xffff);
>>> + blk_queue_max_segment_size(dd->queue, 0x400000);
>>> blk_queue_io_min(dd->queue, 4096);
>>> + dd->queue->nr_requests = 255;
>>
>> ->nr_requests isn't a boundary variable you set for the queue. It's set
>> by the core bits, or by the user via the sysfs interface.
>>
>> So you should not touch that from the driver.
>>
>
> Ok.
>
> I saw scsi lib module changing it, so thought of changing the value close to
> device queue depth.
That's actually a fair point. What is the device queue depth for this
card?
Cheers,
Jeff
On 5/31/2012 10:12 AM, Jeff Moyer wrote:
> Asai Thambi S P <[email protected]> writes:
>
>> On 5/30/2012 11:43 PM, Jens Axboe wrote:
>>
>>> On 05/30/2012 03:42 AM, Asai Thambi S P wrote:
>>>>
>>>> Set the following block queue boundary variables
>>>> * max_hw_sectors
>>>> * max_segment_size
>>>> * nr_requests
>>>>
>>>> Signed-off-by: Asai Thambi S P <[email protected]>
>>>> ---
>>>> drivers/block/mtip32xx/mtip32xx.c | 4 ++++
>>>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
>>>> index 9fe897d..801e70c 100644
>>>> --- a/drivers/block/mtip32xx/mtip32xx.c
>>>> +++ b/drivers/block/mtip32xx/mtip32xx.c
>>>> @@ -3631,7 +3631,11 @@ skip_create_disk:
>>>> set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
>>>> blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
>>>> blk_queue_physical_block_size(dd->queue, 4096);
>>>> + blk_queue_max_hw_sectors(dd->queue, 0xffff);
>>>> + blk_queue_max_segment_size(dd->queue, 0x400000);
>>>> blk_queue_io_min(dd->queue, 4096);
>>>> + dd->queue->nr_requests = 255;
>>>
>>> ->nr_requests isn't a boundary variable you set for the queue. It's set
>>> by the core bits, or by the user via the sysfs interface.
>>>
>>> So you should not touch that from the driver.
>>>
>>
>> Ok.
>>
>> I saw scsi lib module changing it, so thought of changing the value close to
>> device queue depth.
>
> That's actually a fair point. What is the device queue depth for this
> card?
>
256
>>>>> @@ -3631,7 +3631,11 @@ skip_create_disk:
>>>>> set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
>>>>> blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
>>>>> blk_queue_physical_block_size(dd->queue, 4096);
>>>>> + blk_queue_max_hw_sectors(dd->queue, 0xffff);
>>>>> + blk_queue_max_segment_size(dd->queue, 0x400000);
>>>>> blk_queue_io_min(dd->queue, 4096);
>>>>> + dd->queue->nr_requests = 255;
>>>>
>>>> ->nr_requests isn't a boundary variable you set for the queue. It's set
>>>> by the core bits, or by the user via the sysfs interface.
>>>>
>>>> So you should not touch that from the driver.
>>>>
>>>
>>> Ok.
>>>
>>> I saw scsi lib module changing it, so thought of changing the value close to
>>> device queue depth.
>>
>> That's actually a fair point. What is the device queue depth for this
>> card?
>>
> 256
Jens, I actually think changing nr_requests makes sense; the only
question in my mind is where to do it. (There's no point in artificially
limiting the device by default.) IIRC, your general rule was to set this
value to 2x the device's queue depth. So, given that this driver
doesn't use the blk-tag interfaces, what do you think would be the
cleanest way to bump nr_requests in this (and the more general) case?
Cheers,
Jeff
On 05/31/2012 08:40 PM, Jeff Moyer wrote:
>>>>>> @@ -3631,7 +3631,11 @@ skip_create_disk:
>>>>>> set_bit(QUEUE_FLAG_NONROT, &dd->queue->queue_flags);
>>>>>> blk_queue_max_segments(dd->queue, MTIP_MAX_SG);
>>>>>> blk_queue_physical_block_size(dd->queue, 4096);
>>>>>> + blk_queue_max_hw_sectors(dd->queue, 0xffff);
>>>>>> + blk_queue_max_segment_size(dd->queue, 0x400000);
>>>>>> blk_queue_io_min(dd->queue, 4096);
>>>>>> + dd->queue->nr_requests = 255;
>>>>>
>>>>> ->nr_requests isn't a boundary variable you set for the queue. It's set
>>>>> by the core bits, or by the user via the sysfs interface.
>>>>>
>>>>> So you should not touch that from the driver.
>>>>>
>>>>
>>>> Ok.
>>>>
>>>> I saw scsi lib module changing it, so thought of changing the value close to
>>>> device queue depth.
>>>
>>> That's actually a fair point. What is the device queue depth for this
>>> card?
>>>
>> 256
>
> Jens, I actually think changing nr_requests makes sense; the only
> question in my mind is where to do it. (There's no point in artificially
> limiting the device by default.) IIRC, your general rule was to set this
> value to 2x the device's queue depth. So, given that this driver
> doesn't use the blk-tag interfaces, what do you think would be the
> cleanest way to bump nr_requests in this (and the more general) case?
But it doesn't matter for this case, the driver isn't consuming request
structures, hence the value set doesn't make any difference. So the only
limiter of queue depth is the driver itself.
--
Jens Axboe
Jens Axboe <[email protected]> writes:
>> Jens, I actually think changing nr_requests makes sense; the only
>> question in my mind is where to do it. (There's no point in artificially
>> limiting the device by default.) IIRC, your general rule was to set this
>> value to 2x the device's queue depth. So, given that this driver
>> doesn't use the blk-tag interfaces, what do you think would be the
>> cleanest way to bump nr_requests in this (and the more general) case?
>
> But it doesn't matter for this case, the driver isn't consuming request
> structures, hence the value set doesn't make any difference. So the only
> limiter of queue depth is the driver itself.
Good point. Nevermind. ;-)
Cheers,
Jeff