2012-06-08 08:54:34

by Peter Ujfalusi

Subject: [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage

twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in

Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e129c82..92144ed 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -286,6 +286,7 @@ config TWL6040_CORE
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
+ select IRQ_DOMAIN
default n
help
Say yes here if you want support for Texas Instruments TWL6040 audio
--
1.7.8.6

2012-06-08 16:58:05

by Randy Dunlap

Subject: Re: [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage

On 06/08/2012 01:54 AM, Peter Ujfalusi wrote:

> twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
> drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
> drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
> drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
> drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in
>
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Peter Ujfalusi <[email protected]>


Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/mfd/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index e129c82..92144ed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -286,6 +286,7 @@ config TWL6040_CORE
> depends on I2C=y && GENERIC_HARDIRQS
> select MFD_CORE
> select REGMAP_I2C
> + select IRQ_DOMAIN
> default n
> help
> Say yes here if you want support for Texas Instruments TWL6040 audio



--
~Randy

2012-06-29 16:19:20

by Samuel Ortiz

Subject: Re: [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage

Hi Peter,

On Fri, Jun 08, 2012 at 11:54:21AM +0300, Peter Ujfalusi wrote:
> twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
> drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
> drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
> drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
> drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in
>
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Patch applied to my for-linus branch, sorry for the delay.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/