2023-12-28 03:51:46

by ChiYuan Huang

Subject: [PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family

From: ChiYuan Huang <[email protected]>

Add compatible support for RTQ6053 and RTQ6059.

Signed-off-by: ChiYuan Huang <[email protected]>
---
.../devicetree/bindings/iio/adc/richtek,rtq6056.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
index 88e008629ea8..d1e1f36d1972 100644
--- a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
@@ -25,7 +25,10 @@ description: |

properties:
compatible:
- const: richtek,rtq6056
+ enum:
+ - richtek,rtq6053
+ - richtek,rtq6056
+ - richtek,rtq6059

reg:
maxItems: 1
--
2.34.1

2023-12-28 07:16:08

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family

On 28/12/2023 04:51, [email protected] wrote:
> From: ChiYuan Huang <[email protected]>
>
> Add compatible support for RTQ6053 and RTQ6059.
>
> Signed-off-by: ChiYuan Huang <[email protected]>

Why do you resend the same patches after two days ignoring the feedback?
No versioning, no changelog?

NAK.

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof