2023-04-21 22:33:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: nuvoton: add missing cache properties

As all level 2 and level 3 caches are unified, add required
cache-unified and cache-level properties to fix warnings like:

nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Please take the patch via sub-arch SoC tree.
---
arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
index 12118b75c0e6..383938dcd3ce 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
@@ -49,6 +49,8 @@ cpu3: cpu@3 {

l2: l2-cache {
compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
};
};

--
2.34.1


2023-05-16 16:34:06

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: nuvoton: add missing cache properties

On 22/04/2023 00:31, Krzysztof Kozlowski wrote:
> As all level 2 and level 3 caches are unified, add required
> cache-unified and cache-level properties to fix warnings like:
>
> nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
> nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Please take the patch via sub-arch SoC tree.
> ---

Hi Tomer, Tali, Patrick and others,

Anyone picking this up?

Best regards,
Krzysztof


2023-06-01 09:27:11

by Tomer Maimon

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: nuvoton: add missing cache properties

Hi Krzysztof,

Sorry for the late reply and thanks for your patch.

On Tue, 16 May 2023 at 19:30, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 22/04/2023 00:31, Krzysztof Kozlowski wrote:
> > As all level 2 and level 3 caches are unified, add required
> > cache-unified and cache-level properties to fix warnings like:
> >
> > nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
> > nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property
I didn't get these warnings in kernel 6.4-rc4, but still, the patch
has been tested on EVB-NPCM8XX and everything looks good.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >
> > ---
> >
> > Please take the patch via sub-arch SoC tree.
> > ---
>
> Hi Tomer, Tali, Patrick and others,
>
> Anyone picking this up?
>
> Best regards,
> Krzysztof
>
Reviewed-by: Tomer Maimon <[email protected]>

Best regards,

Tomer

2023-07-13 07:24:46

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: nuvoton: add missing cache properties


On Sat, 22 Apr 2023 00:31:54 +0200, Krzysztof Kozlowski wrote:
> As all level 2 and level 3 caches are unified, add required
> cache-unified and cache-level properties to fix warnings like:
>
> nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
> nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property
>
>
> [...]

This was waiting on the list for long time, so I am picking it up. If someone
else prefers to take it, let me know.

Applied, thanks!

[1/1] arm64: dts: nuvoton: add missing cache properties
https://git.kernel.org/krzk/linux-dt/c/a8cf500c42c751b992f5480c390d6ad2419472e0

Best regards,
--
Krzysztof Kozlowski <[email protected]>