2023-06-18 11:48:02

by Krzysztof Kozlowski

Subject: [PATCH 1/7] arm64: dts: qcom: sm8350-hdk: correct FSA4480 port

FSA4480 has only one port according to bindings:

sm8350-hdk.dtb: typec-mux@42: 'port' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index b182f4cf06cc..95a2a42ccb9e 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -349,16 +349,9 @@ typec-mux@42 {
mode-switch;
orientation-switch;

- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
-
- fsa4480_sbu_mux: endpoint {
- remote-endpoint = <&pmic_glink_sbu>;
- };
+ port {
+ fsa4480_sbu_mux: endpoint {
+ remote-endpoint = <&pmic_glink_sbu>;
};
};
};
--
2.34.1

2023-06-18 11:48:25

by Krzysztof Kozlowski

Subject: [PATCH 2/7] arm64: dts: qcom: sm8450-hdk: correct FSA4480 port

FSA4480 has only one port according to bindings:

sm8450-hdk.dtb: typec-mux@42: 'port' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index d7975b3cf064..e5cbea92e07a 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -518,16 +518,9 @@ typec-mux@42 {
mode-switch;
orientation-switch;

- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
-
- fsa4480_sbu_mux: endpoint {
- remote-endpoint = <&pmic_glink_sbu>;
- };
+ port {
+ fsa4480_sbu_mux: endpoint {
+ remote-endpoint = <&pmic_glink_sbu>;
};
};
};
--
2.34.1

2023-06-18 11:51:10

by Krzysztof Kozlowski

Subject: [PATCH 5/7] arm64: dts: qcom: sm6350: correct ramoops pmsg-size

There is no 'msg-size' property in ramoops, so assume intention was for
'pmsg-size':

sm6350-sony-xperia-lena-pdx213.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 30e77010aed5..698171bda9fa 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -673,7 +673,7 @@ ramoops: ramoops@ffc00000 {
reg = <0 0xffc00000 0 0x100000>;
record-size = <0x1000>;
console-size = <0x40000>;
- msg-size = <0x20000 0x20000>;
+ pmsg-size = <0x20000>;
ecc-size = <16>;
no-map;
};
--
2.34.1

2023-06-18 11:51:51

by Krzysztof Kozlowski

Subject: [PATCH 7/7] arm64: dts: qcom: sm8250-edo: correct ramoops pmsg-size

There is no 'msg-size' property in ramoops, so assume intention was for
'pmsg-size':

sm8250-sony-xperia-edo-pdx206.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index 8ab82bacba81..9f3ea8d8d798 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -112,7 +112,7 @@ ramoops@ffc00000 {
reg = <0x0 0xffc00000 0x0 0x100000>;
record-size = <0x1000>;
console-size = <0x40000>;
- msg-size = <0x20000 0x20000>;
+ pmsg-size = <0x20000>;
ecc-size = <16>;
no-map;
};
--
2.34.1

2023-06-18 12:38:29

by Krzysztof Kozlowski

Subject: [PATCH 3/7] arm64: dts: qcom: sm6125-pdx201: correct ramoops pmsg-size

There is no 'msg-size' property in ramoops, so assume intention was for
'pmsg-size':

sm6125-sony-xperia-seine-pdx201.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
index 2b4840446cb0..9e44ac229619 100644
--- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
+++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
@@ -79,7 +79,7 @@ pstore_mem: ramoops@ffc00000 {
reg = <0x0 0xffc40000 0x0 0xc0000>;
record-size = <0x1000>;
console-size = <0x40000>;
- msg-size = <0x20000 0x20000>;
+ pmsg-size = <0x20000>;
};

cmdline_mem: memory@ffd00000 {
--
2.34.1

2023-06-18 12:38:29

by Krzysztof Kozlowski

Subject: [PATCH 6/7] arm64: dts: qcom: sm8150-kumano: correct ramoops pmsg-size

There is no 'msg-size' property in ramoops, so assume intention was for
'pmsg-size':

sm8150-sony-xperia-kumano-griffin.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
index baafea53770b..ae0ca48b89a5 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
@@ -222,7 +222,7 @@ ramoops@ffc00000 {
reg = <0x0 0xffc00000 0x0 0x100000>;
record-size = <0x1000>;
console-size = <0x40000>;
- msg-size = <0x20000 0x20000>;
+ pmsg-size = <0x20000>;
ecc-size = <16>;
no-map;
};
--
2.34.1

2023-06-18 12:38:43

by Krzysztof Kozlowski

Subject: [PATCH 4/7] arm64: dts: qcom: sm6125-sprout: correct ramoops pmsg-size

There is no 'msg-size' property in ramoops, so assume intention was for
'pmsg-size':

sm6125-xiaomi-laurel-sprout.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
index a7f4aeae9c1a..7c58d1299a60 100644
--- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
+++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
@@ -52,7 +52,7 @@ pstore_mem: ramoops@ffc00000 {
reg = <0x0 0xffc40000 0x0 0xc0000>;
record-size = <0x1000>;
console-size = <0x40000>;
- msg-size = <0x20000 0x20000>;
+ pmsg-size = <0x20000>;
};

cmdline_mem: memory@ffd00000 {
--
2.34.1

2023-06-19 08:31:48

by Neil Armstrong

Subject: Re: [PATCH 1/7] arm64: dts: qcom: sm8350-hdk: correct FSA4480 port

On 18/06/2023 13:44, Krzysztof Kozlowski wrote:
> FSA4480 has only one port according to bindings:
>
> sm8350-hdk.dtb: typec-mux@42: 'port' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index b182f4cf06cc..95a2a42ccb9e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -349,16 +349,9 @@ typec-mux@42 {
> mode-switch;
> orientation-switch;
>
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> - fsa4480_sbu_mux: endpoint {
> - remote-endpoint = <&pmic_glink_sbu>;
> - };
> + port {
> + fsa4480_sbu_mux: endpoint {
> + remote-endpoint = <&pmic_glink_sbu>;
> };
> };
> };

Reviewed-by: Neil Armstrong <[email protected]>

2023-06-19 08:34:23

by Neil Armstrong

Subject: Re: [PATCH 2/7] arm64: dts: qcom: sm8450-hdk: correct FSA4480 port

On 18/06/2023 13:44, Krzysztof Kozlowski wrote:
> FSA4480 has only one port according to bindings:
>
> sm8450-hdk.dtb: typec-mux@42: 'port' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index d7975b3cf064..e5cbea92e07a 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -518,16 +518,9 @@ typec-mux@42 {
> mode-switch;
> orientation-switch;
>
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> - fsa4480_sbu_mux: endpoint {
> - remote-endpoint = <&pmic_glink_sbu>;
> - };
> + port {
> + fsa4480_sbu_mux: endpoint {
> + remote-endpoint = <&pmic_glink_sbu>;
> };
> };
> };

Reviewed-by: Neil Armstrong <[email protected]>

2023-06-19 10:01:12

by Konrad Dybcio

Subject: Re: [PATCH 3/7] arm64: dts: qcom: sm6125-pdx201: correct ramoops pmsg-size

On 18.06.2023 13:44, Krzysztof Kozlowski wrote:
> There is no 'msg-size' property in ramoops, so assume intention was for
> 'pmsg-size':
>
> sm6125-sony-xperia-seine-pdx201.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Downstream copypasta

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
> index 2b4840446cb0..9e44ac229619 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
> @@ -79,7 +79,7 @@ pstore_mem: ramoops@ffc00000 {
> reg = <0x0 0xffc40000 0x0 0xc0000>;
> record-size = <0x1000>;
> console-size = <0x40000>;
> - msg-size = <0x20000 0x20000>;
> + pmsg-size = <0x20000>;
> };
>
> cmdline_mem: memory@ffd00000 {

2023-06-19 10:02:26

by Konrad Dybcio

Subject: Re: [PATCH 4/7] arm64: dts: qcom: sm6125-sprout: correct ramoops pmsg-size

On 18.06.2023 13:44, Krzysztof Kozlowski wrote:
> There is no 'msg-size' property in ramoops, so assume intention was for
> 'pmsg-size':
>
> sm6125-xiaomi-laurel-sprout.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
> index a7f4aeae9c1a..7c58d1299a60 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
> @@ -52,7 +52,7 @@ pstore_mem: ramoops@ffc00000 {
> reg = <0x0 0xffc40000 0x0 0xc0000>;
> record-size = <0x1000>;
> console-size = <0x40000>;
> - msg-size = <0x20000 0x20000>;
> + pmsg-size = <0x20000>;
> };
>
> cmdline_mem: memory@ffd00000 {

2023-06-19 10:08:16

by Konrad Dybcio

Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8250-edo: correct ramoops pmsg-size

On 18.06.2023 13:44, Krzysztof Kozlowski wrote:
> There is no 'msg-size' property in ramoops, so assume intention was for
> 'pmsg-size':
>
> sm8250-sony-xperia-edo-pdx206.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index 8ab82bacba81..9f3ea8d8d798 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -112,7 +112,7 @@ ramoops@ffc00000 {
> reg = <0x0 0xffc00000 0x0 0x100000>;
> record-size = <0x1000>;
> console-size = <0x40000>;
> - msg-size = <0x20000 0x20000>;
> + pmsg-size = <0x20000>;
> ecc-size = <16>;
> no-map;
> };

2023-06-19 10:10:30

by Konrad Dybcio

Subject: Re: [PATCH 6/7] arm64: dts: qcom: sm8150-kumano: correct ramoops pmsg-size

On 18.06.2023 13:44, Krzysztof Kozlowski wrote:
> There is no 'msg-size' property in ramoops, so assume intention was for
> 'pmsg-size':
>
> sm8150-sony-xperia-kumano-griffin.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> index baafea53770b..ae0ca48b89a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> @@ -222,7 +222,7 @@ ramoops@ffc00000 {
> reg = <0x0 0xffc00000 0x0 0x100000>;
> record-size = <0x1000>;
> console-size = <0x40000>;
> - msg-size = <0x20000 0x20000>;
> + pmsg-size = <0x20000>;
> ecc-size = <16>;
> no-map;
> };

2023-06-19 10:11:31

by Konrad Dybcio

Subject: Re: [PATCH 5/7] arm64: dts: qcom: sm6350: correct ramoops pmsg-size

On 18.06.2023 13:44, Krzysztof Kozlowski wrote:
> There is no 'msg-size' property in ramoops, so assume intention was for
> 'pmsg-size':
>
> sm6350-sony-xperia-lena-pdx213.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 30e77010aed5..698171bda9fa 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -673,7 +673,7 @@ ramoops: ramoops@ffc00000 {
> reg = <0 0xffc00000 0 0x100000>;
> record-size = <0x1000>;
> console-size = <0x40000>;
> - msg-size = <0x20000 0x20000>;
> + pmsg-size = <0x20000>;
> ecc-size = <16>;
> no-map;
> };

2023-07-10 05:28:14

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/7] arm64: dts: qcom: sm8350-hdk: correct FSA4480 port

On Sun, 18 Jun 2023 13:44:36 +0200, Krzysztof Kozlowski wrote:
> FSA4480 has only one port according to bindings:
>
> sm8350-hdk.dtb: typec-mux@42: 'port' is a required property
>
>

Applied, thanks!

[1/7] arm64: dts: qcom: sm8350-hdk: correct FSA4480 port
commit: 44f2f74df42910ae3a2289f1020788a348089718
[2/7] arm64: dts: qcom: sm8450-hdk: correct FSA4480 port
commit: dea98746f90ab368ec51dc7a070090165560a5de
[3/7] arm64: dts: qcom: sm6125-pdx201: correct ramoops pmsg-size
commit: c42f5452de6ad2599c6e5e2a64c180a4ac835d27
[4/7] arm64: dts: qcom: sm6125-sprout: correct ramoops pmsg-size
commit: 2951e7e7611a3ea04de98d0f1bfc4e7ec609ef29
[5/7] arm64: dts: qcom: sm6350: correct ramoops pmsg-size
commit: c86b97a72065e06eacb993dc71fa9febc93422af
[6/7] arm64: dts: qcom: sm8150-kumano: correct ramoops pmsg-size
commit: 4e6b942f092653ebcdbbc0819b2d1f08ab415bdc
[7/7] arm64: dts: qcom: sm8250-edo: correct ramoops pmsg-size
commit: 7dc3606f91427414d00a2fb09e6e0e32c14c2093

Best regards,
--
Bjorn Andersson <[email protected]>