2021-08-31 11:50:18

by CGEL

Subject: [PATCH] scsi: lpfc: remove unneeded variable

From: Chi Minghao <[email protected]>

Fix the following coccicheck REVIEW:
./drivers/scsi/lpfc/lpfc_scsi.c:1498:9-12 REVIEW Unneeded variable

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Chi Minghao <[email protected]>
---
drivers/scsi/lpfc/lpfc_scsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 0fde1e874c7a..08a6ad79ceef 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -1495,7 +1495,6 @@ static int
lpfc_bg_err_opcodes(struct lpfc_hba *phba, struct scsi_cmnd *sc,
uint8_t *txop, uint8_t *rxop)
{
- uint8_t ret = 0;

if (sc->prot_flags & SCSI_PROT_IP_CHECKSUM) {
switch (scsi_get_prot_op(sc)) {
@@ -1548,7 +1547,7 @@ lpfc_bg_err_opcodes(struct lpfc_hba *phba, struct scsi_cmnd *sc,
}
}

- return ret;
+ return 0;
}
#endif

--
2.25.1

2021-09-03 00:42:37

by James Smart

Subject: Re: [PATCH] scsi: lpfc: remove unneeded variable

On 8/31/2021 4:40 AM, [email protected] wrote:
> From: Chi Minghao <[email protected]>
>
> Fix the following coccicheck REVIEW:
> ./drivers/scsi/lpfc/lpfc_scsi.c:1498:9-12 REVIEW Unneeded variable
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Chi Minghao <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_scsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Looks Good - Thanks!

Reviewed-by: James Smart <[email protected]>

-- james

2021-09-14 03:46:00

by Martin K. Petersen

Subject: Re: [PATCH] scsi: lpfc: remove unneeded variable

On Tue, 31 Aug 2021 04:40:58 -0700, [email protected] wrote:

> From: Chi Minghao <[email protected]>
>
> Fix the following coccicheck REVIEW:
> ./drivers/scsi/lpfc/lpfc_scsi.c:1498:9-12 REVIEW Unneeded variable
>
>

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: lpfc: remove unneeded variable
https://git.kernel.org/mkp/scsi/c/5d1e15108b8d

--
Martin K. Petersen Oracle Linux Engineering