2019-09-11 09:33:49

by Colin King

Subject: [PATCH] dtc: fix spelling mistake "mmory" -> "memory"

From: Colin Ian King <[email protected]>

There is a spelling mistake in an error message. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
---
scripts/dtc/fdtput.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dtc/fdtput.c b/scripts/dtc/fdtput.c
index a363c3cabc59..3755e5f68a5a 100644
--- a/scripts/dtc/fdtput.c
+++ b/scripts/dtc/fdtput.c
@@ -84,7 +84,7 @@ static int encode_value(struct display_info *disp, char **arg, int arg_count,
value_size = (upto + len) + 500;
value = realloc(value, value_size);
if (!value) {
- fprintf(stderr, "Out of mmory: cannot alloc "
+ fprintf(stderr, "Out of memory: cannot alloc "
"%d bytes\n", value_size);
return -1;
}
--
2.20.1

2019-10-18 22:17:30

by Frank Rowand

Subject: Re: [PATCH] dtc: fix spelling mistake "mmory" -> "memory"

Hi Rob,


On 09/11/2019 04:31, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There is a spelling mistake in an error message. Fix it.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> scripts/dtc/fdtput.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dtc/fdtput.c b/scripts/dtc/fdtput.c
> index a363c3cabc59..3755e5f68a5a 100644
> --- a/scripts/dtc/fdtput.c
> +++ b/scripts/dtc/fdtput.c
> @@ -84,7 +84,7 @@ static int encode_value(struct display_info *disp, char **arg, int arg_count,
> value_size = (upto + len) + 500;
> value = realloc(value, value_size);
> if (!value) {
> - fprintf(stderr, "Out of mmory: cannot alloc "
> + fprintf(stderr, "Out of memory: cannot alloc "
> "%d bytes\n", value_size);
> return -1;
> }
>

This is a very old version of the upstream file. update-dtc-source.sh does
not pull new versions of this file.

We don't actually build fdtput, is there any reason to not just remove
scripts/dtc/fdtput.c?

-Frank

2019-10-20 18:59:35

by Rob Herring

Subject: Re: [PATCH] dtc: fix spelling mistake "mmory" -> "memory"

On Thu, Oct 17, 2019 at 2:08 PM Frank Rowand <[email protected]> wrote:
>
> Hi Rob,
>
>
> On 09/11/2019 04:31, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > There is a spelling mistake in an error message. Fix it.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
> > ---
> > scripts/dtc/fdtput.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/dtc/fdtput.c b/scripts/dtc/fdtput.c
> > index a363c3cabc59..3755e5f68a5a 100644
> > --- a/scripts/dtc/fdtput.c
> > +++ b/scripts/dtc/fdtput.c
> > @@ -84,7 +84,7 @@ static int encode_value(struct display_info *disp, char **arg, int arg_count,
> > value_size = (upto + len) + 500;
> > value = realloc(value, value_size);
> > if (!value) {
> > - fprintf(stderr, "Out of mmory: cannot alloc "
> > + fprintf(stderr, "Out of memory: cannot alloc "
> > "%d bytes\n", value_size);
> > return -1;
> > }
> >
>
> This is a very old version of the upstream file. update-dtc-source.sh does
> not pull new versions of this file.
>
> We don't actually build fdtput, is there any reason to not just remove
> scripts/dtc/fdtput.c?

Yes, we should just remove it.

Rob