2022-06-11 08:28:32

by yekai (A)

[permalink] [raw]
Subject: [PATCH 0/2] crypto: hisilicon - supports device isolation feature

Add the hardware error isolation feature for ACC. Defines a driver debugfs
node that used to configures the hardware error frequency. When the error
frequency is exceeded, the device will be isolated. The isolation strategy
can be defined in each driver module. e.g. Defining the isolation strategy
for ACC, if the AER error frequency exceeds the value of setting for a
certain period of time, The device will not be available in user space. The
VF device use the PF device isolation strategy. as well as the isolation
strategy should not be set during device use.

Kai Ye (2):
uacce: supports device isolation feature
crypto: hisilicon/qm - defining the device isolation strategy

drivers/crypto/hisilicon/qm.c | 149 +++++++++++++++++++++++++++++++---
drivers/misc/uacce/uacce.c | 76 +++++++++++++++++
include/linux/hisi_acc_qm.h | 8 ++
include/linux/uacce.h | 21 ++++-
4 files changed, 241 insertions(+), 13 deletions(-)

--
2.33.0


2022-06-11 09:08:48

by yekai (A)

[permalink] [raw]
Subject: [PATCH 2/2] crypto: hisilicon/qm - defining the device isolation strategy

Define the device isolation strategy by the device driver. if the
AER error frequency exceeds the value of setting for a certain
period of time, The device will not be available in user space. The VF
device use the PF device isolation strategy. All the hardware errors
are processed by PF driver.

Signed-off-by: Kai Ye <[email protected]>
---
drivers/crypto/hisilicon/qm.c | 149 +++++++++++++++++++++++++++++++---
include/linux/hisi_acc_qm.h | 8 ++
2 files changed, 145 insertions(+), 12 deletions(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index b4ca2eb034d7..73c12714a36b 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -12,7 +12,6 @@
#include <linux/pm_runtime.h>
#include <linux/seq_file.h>
#include <linux/slab.h>
-#include <linux/uacce.h>
#include <linux/uaccess.h>
#include <uapi/misc/uacce/hisi_qm.h>
#include <linux/hisi_acc_qm.h>
@@ -417,6 +416,16 @@ struct hisi_qm_resource {
struct list_head list;
};

+/**
+ * struct qm_hw_err - structure of describes the device err
+ * @list: hardware error list
+ * @tick_stamp: timestamp when the error occurred
+ */
+struct qm_hw_err {
+ struct list_head list;
+ unsigned long long tick_stamp;
+};
+
struct hisi_qm_hw_ops {
int (*get_vft)(struct hisi_qm *qm, u32 *base, u32 *number);
void (*qm_db)(struct hisi_qm *qm, u16 qn,
@@ -3397,6 +3406,99 @@ static long hisi_qm_uacce_ioctl(struct uacce_queue *q, unsigned int cmd,
return 0;
}

+/**
+ * qm_hw_err_isolate() - Try to isolate the uacce device with its VFs
+ * @qm: The qm which we want to configure.
+ *
+ * according to user's configuration of isolation strategy. Warning: this
+ * API should be called while there is no user on the device, or the users
+ * on this device are suspended by slot resetting preparation of PCI AER.
+ */
+static int qm_hw_err_isolate(struct hisi_qm *qm)
+{
+ struct qm_hw_err *err, *tmp, *hw_err;
+ struct qm_err_isolate *isolate;
+ u32 count = 0;
+
+ isolate = &qm->isolate_data;
+
+#define SECONDS_PER_HOUR 3600
+
+ /* All the hw errs are processed by PF driver */
+ if (qm->uacce->is_vf || atomic_read(&isolate->is_isolate) ||
+ !isolate->hw_err_isolate_hz)
+ return 0;
+
+ hw_err = kzalloc(sizeof(*hw_err), GFP_ATOMIC);
+ if (!hw_err)
+ return -ENOMEM;
+ hw_err->tick_stamp = jiffies;
+ list_for_each_entry_safe(err, tmp, &qm->uacce_hw_errs, list) {
+ if ((hw_err->tick_stamp - err->tick_stamp) / HZ >
+ SECONDS_PER_HOUR) {
+ list_del(&err->list);
+ kfree(err);
+ } else {
+ count++;
+ }
+ }
+ list_add(&hw_err->list, &qm->uacce_hw_errs);
+
+ if (count >= isolate->hw_err_isolate_hz)
+ atomic_set(&isolate->is_isolate, 1);
+
+ return 0;
+}
+
+static void qm_hw_err_destroy(struct hisi_qm *qm)
+{
+ struct qm_hw_err *err, *tmp;
+
+ list_for_each_entry_safe(err, tmp, &qm->uacce_hw_errs, list) {
+ list_del(&err->list);
+ kfree(err);
+ }
+}
+
+static enum uacce_dev_state hisi_qm_get_isolate_state(struct uacce_device *uacce)
+{
+ struct hisi_qm *qm = uacce->priv;
+ struct hisi_qm *pf_qm;
+
+ if (uacce->is_vf) {
+ pf_qm = pci_get_drvdata(pci_physfn(qm->pdev));
+ qm->isolate_data.is_isolate = pf_qm->isolate_data.is_isolate;
+ }
+
+ return atomic_read(&qm->isolate_data.is_isolate) ?
+ UACCE_DEV_ISOLATE : UACCE_DEV_NORMAL;
+}
+
+static int hisi_qm_isolate_strategy_write(struct uacce_device *uacce,
+ const char *buf)
+{
+ struct hisi_qm *qm = uacce->priv;
+ unsigned long val = 0;
+
+#define MAX_ISOLATE_STRATEGY 65535
+
+ /* must be set by PF */
+ if (atomic_read(&qm->isolate_data.is_isolate) || uacce->is_vf)
+ return -EINVAL;
+
+ if (kstrtoul(buf, 0, &val) < 0)
+ return -EINVAL;
+
+ if (val > MAX_ISOLATE_STRATEGY)
+ return -EINVAL;
+
+ qm->isolate_data.hw_err_isolate_hz = val;
+ dev_info(&qm->pdev->dev,
+ "the value of isolate_strategy is set to %lu.\n", val);
+
+ return 0;
+}
+
static const struct uacce_ops uacce_qm_ops = {
.get_available_instances = hisi_qm_get_available_instances,
.get_queue = hisi_qm_uacce_get_queue,
@@ -3405,9 +3507,22 @@ static const struct uacce_ops uacce_qm_ops = {
.stop_queue = hisi_qm_uacce_stop_queue,
.mmap = hisi_qm_uacce_mmap,
.ioctl = hisi_qm_uacce_ioctl,
+ .get_isolate_state = hisi_qm_get_isolate_state,
.is_q_updated = hisi_qm_is_q_updated,
+ .isolate_strategy_write = hisi_qm_isolate_strategy_write,
};

+static void qm_remove_uacce(struct hisi_qm *qm)
+{
+ struct uacce_device *uacce = qm->uacce;
+
+ if (qm->use_sva) {
+ qm_hw_err_destroy(qm);
+ uacce_remove(uacce);
+ qm->uacce = NULL;
+ }
+}
+
static int qm_alloc_uacce(struct hisi_qm *qm)
{
struct pci_dev *pdev = qm->pdev;
@@ -3420,6 +3535,7 @@ static int qm_alloc_uacce(struct hisi_qm *qm)
};
int ret;

+ INIT_LIST_HEAD(&qm->uacce_hw_errs);
ret = strscpy(interface.name, dev_driver_string(&pdev->dev),
sizeof(interface.name));
if (ret < 0)
@@ -3433,8 +3549,7 @@ static int qm_alloc_uacce(struct hisi_qm *qm)
qm->use_sva = true;
} else {
/* only consider sva case */
- uacce_remove(uacce);
- qm->uacce = NULL;
+ qm_remove_uacce(qm);
return -EINVAL;
}

@@ -5074,6 +5189,12 @@ static int qm_controller_reset_prepare(struct hisi_qm *qm)
return ret;
}

+ if (qm->use_sva) {
+ ret = qm_hw_err_isolate(qm);
+ if (ret)
+ pci_err(pdev, "failed to isolate hw err!\n");
+ }
+
ret = qm_wait_vf_prepare_finish(qm);
if (ret)
pci_err(pdev, "failed to stop by vfs in soft reset!\n");
@@ -5401,19 +5522,24 @@ static int qm_controller_reset(struct hisi_qm *qm)
ret = qm_soft_reset(qm);
if (ret) {
pci_err(pdev, "Controller reset failed (%d)\n", ret);
- qm_reset_bit_clear(qm);
- return ret;
+ goto err_reset;
}

ret = qm_controller_reset_done(qm);
- if (ret) {
- qm_reset_bit_clear(qm);
- return ret;
- }
+ if (ret)
+ goto err_reset;

pci_info(pdev, "Controller reset complete\n");
-
return 0;
+
+err_reset:
+ pci_err(pdev, "Controller reset failed (%d)\n", ret);
+ qm_reset_bit_clear(qm);
+
+ /* if resetting fails, isolate the device */
+ if (qm->use_sva && !qm->uacce->is_vf)
+ atomic_set(&qm->isolate_data.is_isolate, 1);
+ return ret;
}

/**
@@ -6186,8 +6312,7 @@ int hisi_qm_init(struct hisi_qm *qm)

err_alloc_uacce:
if (qm->use_sva) {
- uacce_remove(qm->uacce);
- qm->uacce = NULL;
+ qm_remove_uacce(qm);
}
err_irq_register:
qm_irq_unregister(qm);
diff --git a/include/linux/hisi_acc_qm.h b/include/linux/hisi_acc_qm.h
index 6cabafffd0dd..757bb8df385e 100644
--- a/include/linux/hisi_acc_qm.h
+++ b/include/linux/hisi_acc_qm.h
@@ -8,6 +8,7 @@
#include <linux/iopoll.h>
#include <linux/module.h>
#include <linux/pci.h>
+#include <linux/uacce.h>

#define QM_QNUM_V1 4096
#define QM_QNUM_V2 1024
@@ -265,6 +266,11 @@ struct hisi_qm_list {
void (*unregister_from_crypto)(struct hisi_qm *qm);
};

+struct qm_err_isolate {
+ u32 hw_err_isolate_hz; /* user cfg freq which triggers isolation */
+ atomic_t is_isolate;
+};
+
struct hisi_qm {
enum qm_hw_ver ver;
enum qm_fun_type fun_type;
@@ -329,6 +335,8 @@ struct hisi_qm {
struct qm_shaper_factor *factor;
u32 mb_qos;
u32 type_rate;
+ struct list_head uacce_hw_errs;
+ struct qm_err_isolate isolate_data;
};

struct hisi_qp_status {
--
2.33.0

2022-06-11 09:32:51

by yekai (A)

[permalink] [raw]
Subject: [PATCH 1/2] uacce: supports device isolation feature

UACCE add the hardware error isolation API. Users can configure
the error frequency threshold by this vfs node. This API interface
certainly supports the configuration of user protocol strategy. Then
parse it inside the device driver. UACCE only reports the device
isolate state. When the error frequency is exceeded, the device
will be isolated. The isolation strategy should be defined in each
driver module.

Signed-off-by: Kai Ye <[email protected]>
Reviewed-by: Zhou Wang <[email protected]>
---
drivers/misc/uacce/uacce.c | 76 ++++++++++++++++++++++++++++++++++++++
include/linux/uacce.h | 21 ++++++++++-
2 files changed, 96 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index b6219c6bfb48..26c07f6f2f7c 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -12,6 +12,38 @@ static dev_t uacce_devt;
static DEFINE_MUTEX(uacce_mutex);
static DEFINE_XARRAY_ALLOC(uacce_xa);

+static int cdev_get(struct device *dev, void *data)
+{
+ struct uacce_device *uacce;
+ struct device **t_dev = data;
+
+ uacce = container_of(dev, struct uacce_device, dev);
+ if (uacce->parent == *t_dev) {
+ *t_dev = dev;
+ return 1;
+ }
+
+ return 0;
+}
+
+/**
+ * dev_to_uacce - Get structure uacce device from its parent device
+ * @dev: the device
+ */
+struct uacce_device *dev_to_uacce(struct device *dev)
+{
+ struct device **tdev = &dev;
+ int ret;
+
+ ret = class_for_each_device(uacce_class, NULL, tdev, cdev_get);
+ if (ret) {
+ dev = *tdev;
+ return container_of(dev, struct uacce_device, dev);
+ }
+ return NULL;
+}
+EXPORT_SYMBOL_GPL(dev_to_uacce);
+
static int uacce_start_queue(struct uacce_queue *q)
{
int ret = 0;
@@ -54,6 +86,7 @@ static int uacce_put_queue(struct uacce_queue *q)
uacce->ops->put_queue(q);

q->state = UACCE_Q_ZOMBIE;
+ atomic_dec(&uacce->ref);
out:
mutex_unlock(&uacce_mutex);

@@ -155,6 +188,7 @@ static int uacce_fops_open(struct inode *inode, struct file *filep)
goto out_with_bond;
}

+ atomic_inc(&uacce->ref);
init_waitqueue_head(&q->wait);
filep->private_data = q;
uacce->inode = inode;
@@ -346,12 +380,52 @@ static ssize_t region_dus_size_show(struct device *dev,
uacce->qf_pg_num[UACCE_QFRT_DUS] << PAGE_SHIFT);
}

+static ssize_t isolate_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct uacce_device *uacce = to_uacce_device(dev);
+
+ return sysfs_emit(buf, "%d\n", uacce->ops->get_isolate_state(uacce));
+}
+
+static ssize_t isolate_strategy_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct uacce_device *uacce = to_uacce_device(dev);
+
+ return sysfs_emit(buf, "%s\n", uacce->isolate_strategy);
+}
+
+static ssize_t isolate_strategy_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct uacce_device *uacce = to_uacce_device(dev);
+ int ret;
+
+ if (atomic_read(&uacce->ref))
+ return -EBUSY;
+
+ if (!buf || sizeof(buf) > UACCE_MAX_ISOLATE_STRATEGY_LEN)
+ return -EINVAL;
+
+ memcpy(uacce->isolate_strategy, buf, strlen(buf));
+
+ ret = uacce->ops->isolate_strategy_write(uacce, buf);
+ if (ret)
+ return -EINVAL;
+
+ return count;
+}
+
static DEVICE_ATTR_RO(api);
static DEVICE_ATTR_RO(flags);
static DEVICE_ATTR_RO(available_instances);
static DEVICE_ATTR_RO(algorithms);
static DEVICE_ATTR_RO(region_mmio_size);
static DEVICE_ATTR_RO(region_dus_size);
+static DEVICE_ATTR_RO(isolate);
+static DEVICE_ATTR_RW(isolate_strategy);

static struct attribute *uacce_dev_attrs[] = {
&dev_attr_api.attr,
@@ -360,6 +434,8 @@ static struct attribute *uacce_dev_attrs[] = {
&dev_attr_algorithms.attr,
&dev_attr_region_mmio_size.attr,
&dev_attr_region_dus_size.attr,
+ &dev_attr_isolate.attr,
+ &dev_attr_isolate_strategy.attr,
NULL,
};

diff --git a/include/linux/uacce.h b/include/linux/uacce.h
index 48e319f40275..30b1595b3f85 100644
--- a/include/linux/uacce.h
+++ b/include/linux/uacce.h
@@ -8,6 +8,7 @@
#define UACCE_NAME "uacce"
#define UACCE_MAX_REGION 2
#define UACCE_MAX_NAME_SIZE 64
+#define UACCE_MAX_ISOLATE_STRATEGY_LEN 256

struct uacce_queue;
struct uacce_device;
@@ -30,6 +31,8 @@ struct uacce_qfile_region {
* @is_q_updated: check whether the task is finished
* @mmap: mmap addresses of queue to user space
* @ioctl: ioctl for user space users of the queue
+ * @get_isolate_state: get the device state after set the isolate strategy
+ * @isolate_strategy_store: stored the isolate strategy to the device
*/
struct uacce_ops {
int (*get_available_instances)(struct uacce_device *uacce);
@@ -43,6 +46,8 @@ struct uacce_ops {
struct uacce_qfile_region *qfr);
long (*ioctl)(struct uacce_queue *q, unsigned int cmd,
unsigned long arg);
+ enum uacce_dev_state (*get_isolate_state)(struct uacce_device *uacce);
+ int (*isolate_strategy_write)(struct uacce_device *uacce, const char *buf);
};

/**
@@ -57,6 +62,12 @@ struct uacce_interface {
const struct uacce_ops *ops;
};

+enum uacce_dev_state {
+ UACCE_DEV_ERR = -1,
+ UACCE_DEV_NORMAL,
+ UACCE_DEV_ISOLATE,
+};
+
enum uacce_q_state {
UACCE_Q_ZOMBIE = 0,
UACCE_Q_INIT,
@@ -99,6 +110,7 @@ struct uacce_queue {
* @dev: dev of the uacce
* @priv: private pointer of the uacce
* @queues: list of queues
+ * @ref: reference of the uacce
* @queues_lock: lock for queues list
* @inode: core vfs
*/
@@ -114,9 +126,11 @@ struct uacce_device {
struct cdev *cdev;
struct device dev;
void *priv;
+ atomic_t ref;
struct list_head queues;
struct mutex queues_lock;
struct inode *inode;
+ char isolate_strategy[UACCE_MAX_ISOLATE_STRATEGY_LEN];
};

#if IS_ENABLED(CONFIG_UACCE)
@@ -125,7 +139,7 @@ struct uacce_device *uacce_alloc(struct device *parent,
struct uacce_interface *interface);
int uacce_register(struct uacce_device *uacce);
void uacce_remove(struct uacce_device *uacce);
-
+struct uacce_device *dev_to_uacce(struct device *dev);
#else /* CONFIG_UACCE */

static inline
@@ -142,6 +156,11 @@ static inline int uacce_register(struct uacce_device *uacce)

static inline void uacce_remove(struct uacce_device *uacce) {}

+static inline struct uacce_device *dev_to_uacce(struct device *dev)
+{
+ return NULL;
+}
+
#endif /* CONFIG_UACCE */

#endif /* _LINUX_UACCE_H */
--
2.33.0

2022-06-13 09:27:40

by zhangfei

[permalink] [raw]
Subject: Re: [PATCH 1/2] uacce: supports device isolation feature



On 2022/6/11 下午3:08, Kai Ye via Linux-accelerators wrote:
> UACCE add the hardware error isolation API. Users can configure
> the error frequency threshold by this vfs node. This API interface
> certainly supports the configuration of user protocol strategy. Then
> parse it inside the device driver. UACCE only reports the device
> isolate state. When the error frequency is exceeded, the device
> will be isolated. The isolation strategy should be defined in each
> driver module.
>
> Signed-off-by: Kai Ye <[email protected]>
> Reviewed-by: Zhou Wang <[email protected]>
> ---
> drivers/misc/uacce/uacce.c | 76 ++++++++++++++++++++++++++++++++++++++
> include/linux/uacce.h | 21 ++++++++++-
> 2 files changed, 96 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index b6219c6bfb48..26c07f6f2f7c 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -12,6 +12,38 @@ static dev_t uacce_devt;
> static DEFINE_MUTEX(uacce_mutex);
> static DEFINE_XARRAY_ALLOC(uacce_xa);
>
> +static int cdev_get(struct device *dev, void *data)
> +{
> + struct uacce_device *uacce;
> + struct device **t_dev = data;
> +
> + uacce = container_of(dev, struct uacce_device, dev);
> + if (uacce->parent == *t_dev) {
> + *t_dev = dev;
> + return 1;
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * dev_to_uacce - Get structure uacce device from its parent device
> + * @dev: the device
> + */
> +struct uacce_device *dev_to_uacce(struct device *dev)
> +{
> + struct device **tdev = &dev;
> + int ret;
> +
> + ret = class_for_each_device(uacce_class, NULL, tdev, cdev_get);
> + if (ret) {
> + dev = *tdev;
> + return container_of(dev, struct uacce_device, dev);
> + }
> + return NULL;
> +}
> +EXPORT_SYMBOL_GPL(dev_to_uacce);
Not find dev_to_uacce user.
> +
> static int uacce_start_queue(struct uacce_queue *q)
> {
> int ret = 0;
> @@ -54,6 +86,7 @@ static int uacce_put_queue(struct uacce_queue *q)
> uacce->ops->put_queue(q);
>
> q->state = UACCE_Q_ZOMBIE;
> + atomic_dec(&uacce->ref);
> out:
> mutex_unlock(&uacce_mutex);
>
> @@ -155,6 +188,7 @@ static int uacce_fops_open(struct inode *inode, struct file *filep)
> goto out_with_bond;
> }
>
> + atomic_inc(&uacce->ref);
Use uacce->ref is strange here, also no dec in release.
How about hidden this in driver itself, like via qm->state, to make
uacce itslef clean.

> init_waitqueue_head(&q->wait);
> filep->private_data = q;
> uacce->inode = inode;
> @@ -346,12 +380,52 @@ static ssize_t region_dus_size_show(struct device *dev,
> uacce->qf_pg_num[UACCE_QFRT_DUS] << PAGE_SHIFT);
> }
>
> +static ssize_t isolate_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct uacce_device *uacce = to_uacce_device(dev);
> +
> + return sysfs_emit(buf, "%d\n", uacce->ops->get_isolate_state(uacce));
> +}
> +
> +static ssize_t isolate_strategy_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct uacce_device *uacce = to_uacce_device(dev);
> +
> + return sysfs_emit(buf, "%s\n", uacce->isolate_strategy);
> +}
> +
> +static ssize_t isolate_strategy_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct uacce_device *uacce = to_uacce_device(dev);
> + int ret;
> +
> + if (atomic_read(&uacce->ref))
> + return -EBUSY;
> +
> + if (!buf || sizeof(buf) > UACCE_MAX_ISOLATE_STRATEGY_LEN)
> + return -EINVAL;
> +
> + memcpy(uacce->isolate_strategy, buf, strlen(buf));
> +
> + ret = uacce->ops->isolate_strategy_write(uacce, buf);
> + if (ret)
> + return -EINVAL;
> +
> + return count;
> +}
> +
> static DEVICE_ATTR_RO(api);
> static DEVICE_ATTR_RO(flags);
> static DEVICE_ATTR_RO(available_instances);
> static DEVICE_ATTR_RO(algorithms);
> static DEVICE_ATTR_RO(region_mmio_size);
> static DEVICE_ATTR_RO(region_dus_size);
> +static DEVICE_ATTR_RO(isolate);
> +static DEVICE_ATTR_RW(isolate_strategy);
Need update Documentation/ABI/testing/sysfs-driver-uacce as well.

isolate_strategy is confusing, what strategy can be chosen, need doc.

Thanks


>
> static struct attribute *uacce_dev_attrs[] = {
> &dev_attr_api.attr,
> @@ -360,6 +434,8 @@ static struct attribute *uacce_dev_attrs[] = {
> &dev_attr_algorithms.attr,
> &dev_attr_region_mmio_size.attr,
> &dev_attr_region_dus_size.attr,
> + &dev_attr_isolate.attr,
> + &dev_attr_isolate_strategy.attr,
> NULL,
> };
>
> diff --git a/include/linux/uacce.h b/include/linux/uacce.h
> index 48e319f40275..30b1595b3f85 100644
> --- a/include/linux/uacce.h
> +++ b/include/linux/uacce.h
> @@ -8,6 +8,7 @@
> #define UACCE_NAME "uacce"
> #define UACCE_MAX_REGION 2
> #define UACCE_MAX_NAME_SIZE 64
> +#define UACCE_MAX_ISOLATE_STRATEGY_LEN 256
>
> struct uacce_queue;
> struct uacce_device;
> @@ -30,6 +31,8 @@ struct uacce_qfile_region {
> * @is_q_updated: check whether the task is finished
> * @mmap: mmap addresses of queue to user space
> * @ioctl: ioctl for user space users of the queue
> + * @get_isolate_state: get the device state after set the isolate strategy
> + * @isolate_strategy_store: stored the isolate strategy to the device
> */
> struct uacce_ops {
> int (*get_available_instances)(struct uacce_device *uacce);
> @@ -43,6 +46,8 @@ struct uacce_ops {
> struct uacce_qfile_region *qfr);
> long (*ioctl)(struct uacce_queue *q, unsigned int cmd,
> unsigned long arg);
> + enum uacce_dev_state (*get_isolate_state)(struct uacce_device *uacce);
> + int (*isolate_strategy_write)(struct uacce_device *uacce, const char *buf);
> };
>
> /**
> @@ -57,6 +62,12 @@ struct uacce_interface {
> const struct uacce_ops *ops;
> };
>
> +enum uacce_dev_state {
> + UACCE_DEV_ERR = -1,
> + UACCE_DEV_NORMAL,
> + UACCE_DEV_ISOLATE,
> +};
> +
> enum uacce_q_state {
> UACCE_Q_ZOMBIE = 0,
> UACCE_Q_INIT,
> @@ -99,6 +110,7 @@ struct uacce_queue {
> * @dev: dev of the uacce
> * @priv: private pointer of the uacce
> * @queues: list of queues
> + * @ref: reference of the uacce
> * @queues_lock: lock for queues list
> * @inode: core vfs
> */
> @@ -114,9 +126,11 @@ struct uacce_device {
> struct cdev *cdev;
> struct device dev;
> void *priv;
> + atomic_t ref;
> struct list_head queues;
> struct mutex queues_lock;
> struct inode *inode;
> + char isolate_strategy[UACCE_MAX_ISOLATE_STRATEGY_LEN];
> };
>
> #if IS_ENABLED(CONFIG_UACCE)
> @@ -125,7 +139,7 @@ struct uacce_device *uacce_alloc(struct device *parent,
> struct uacce_interface *interface);
> int uacce_register(struct uacce_device *uacce);
> void uacce_remove(struct uacce_device *uacce);
> -
> +struct uacce_device *dev_to_uacce(struct device *dev);
> #else /* CONFIG_UACCE */
>
> static inline
> @@ -142,6 +156,11 @@ static inline int uacce_register(struct uacce_device *uacce)
>
> static inline void uacce_remove(struct uacce_device *uacce) {}
>
> +static inline struct uacce_device *dev_to_uacce(struct device *dev)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_UACCE */
>
> #endif /* _LINUX_UACCE_H */