2017-12-31 22:16:55

by Darren Stevens

[permalink] [raw]
Subject: [RESEND PATCH] i2c/busses/pasemi: Remove hardcoded bus numbers on smbus

The pasemi smbus controller uses PCI_FUNC(dev->devfn) to define which
number bus to attach to, however this fails when something else is
probed first, for example an ATI Radeon graphics card will claim 9 or
10 busses, including the ones the pasemi wants.
Patch the driver to call i2c_add_adapter rather than
i2c_add_numbered_adapter.

Signed-off-by: Darren Stevens <[email protected]>

---


Attachments:
i2c.patch (826.00 B)

2018-08-20 09:08:52

by Wolfram Sang

[permalink] [raw]
Subject: Re: [RESEND PATCH] i2c/busses/pasemi: Remove hardcoded bus numbers on smbus

On Sun, Dec 31, 2017 at 08:53:55PM +0000, Darren Stevens wrote:
> The pasemi smbus controller uses PCI_FUNC(dev->devfn) to define which
> number bus to attach to, however this fails when something else is
> probed first, for example an ATI Radeon graphics card will claim 9 or
> 10 busses, including the ones the pasemi wants.
> Patch the driver to call i2c_add_adapter rather than
> i2c_add_numbered_adapter.
>
> Signed-off-by: Darren Stevens <[email protected]>
>

Applied to for-next, thanks!

Disclaimer: I usually do not like to change the bus numbering because
some people may rely on that. But numbering based on PCI functions seems
really weak and all known users of pasemi seem to have issues here, so I
make an exception.

Thanks to Michael Ellerman for the additional info.


Attachments:
(No filename) (815.00 B)
signature.asc (849.00 B)
Download all attachments