2020-10-08 14:03:46

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver

Hi,

some super high level questions:

> different controllers according to their needs. A backend
> example can be found in the device model of the open source
> project ACRN. For more information, please refer to
> https://projectacrn.org.

Could you provide a link directly to the backend, please?

> The device ID request:
> https://github.com/oasis-tcs/virtio-spec/issues/85

Shall we wait for this to be approved? Or will it get only approved once
the driver here is upstream?

> + If you say yes to this option, support will be included for the virtio
> + I2C adapter driver. The hardware can be emulated by any device model
> + software according to the virtio protocol.

That means stuff like "limiting which devices on a given bus can be
accessed" will be handled by the backends, or?

What kind of testing has been done with this on which setup?

Thanks and happy hacking,

Wolfram


Attachments:
(No filename) (941.00 B)
signature.asc (849.00 B)
Download all attachments

2020-10-12 05:38:04

by Jie Deng

[permalink] [raw]
Subject: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver


On 2020/10/8 22:01, Wolfram Sang wrote:
> Hi,
>
> some super high level questions:
>
>> different controllers according to their needs. A backend
>> example can be found in the device model of the open source
>> project ACRN. For more information, please refer to
>> https://projectacrn.org.
> Could you provide a link directly to the backend, please?
Sure. Here is the link.
https://raw.githubusercontent.com/projectacrn/acrn-hypervisor/master/devicemodel/hw/pci/virtio/virtio_i2c.c
>> The device ID request:
>> https://github.com/oasis-tcs/virtio-spec/issues/85
> Shall we wait for this to be approved? Or will it get only approved once
> the driver here is upstream?
That's what I want to know also.
So hi Michael, what's the upstream flow for this patch ?

Thanks.


>> + If you say yes to this option, support will be included for the virtio
>> + I2C adapter driver. The hardware can be emulated by any device model
>> + software according to the virtio protocol.
> That means stuff like "limiting which devices on a given bus can be
> accessed" will be handled by the backends, or?
>
> What kind of testing has been done with this on which setup?
>
> Thanks and happy hacking,
>
> Wolfram
Yes, you can configure what devices can be seen by the guest.
This provides a way to flexibly organize and manage I2C slave devices
from the guest.

We tested it on Intel APL MRB. There are some docs for you reference.
https://projectacrn.github.io/latest/developer-guides/hld/virtio-i2c.html?highlight=i2c

Regards.