Denis,
In the rule proposing kzfree_sensitive, I think it would be helpful to
also highlight the memset line.
julia
Hi,
On 10/2/20 5:01 PM, Julia Lawall wrote:
> Denis,
>
> In the rule proposing kzfree_sensitive, I think it would be helpful to
> also highlight the memset line.
What do you mean? It's "highlighted" in context mode. Do you mean adding
position argument to memset call and showing this position in the warning
messages?
Thanks,
Denis
On Fri, 2 Oct 2020, Denis Efremov wrote:
> Hi,
>
> On 10/2/20 5:01 PM, Julia Lawall wrote:
> > Denis,
> >
> > In the rule proposing kzfree_sensitive, I think it would be helpful to
> > also highlight the memset line.
>
> What do you mean? It's "highlighted" in context mode. Do you mean adding
> position argument to memset call and showing this position in the warning
> messages?
Yes, that seems to be what I mean. 0-day generated a message from the
script, and I had to hunt around for the reason why it was doing that. So
it would be nice to have the memset highlighted. It seems that the
non-patch 0-day messages are generated from the report mode.
thanks,
julia
On 10/2/20 5:13 PM, Julia Lawall wrote:
>
>
> On Fri, 2 Oct 2020, Denis Efremov wrote:
>
>> Hi,
>>
>> On 10/2/20 5:01 PM, Julia Lawall wrote:
>>> Denis,
>>>
>>> In the rule proposing kzfree_sensitive, I think it would be helpful to
>>> also highlight the memset line.
>>
>> What do you mean? It's "highlighted" in context mode. Do you mean adding
>> position argument to memset call and showing this position in the warning
>> messages?
>
> Yes, that seems to be what I mean. 0-day generated a message from the
> script, and I had to hunt around for the reason why it was doing that. So
> it would be nice to have the memset highlighted. It seems that the
> non-patch 0-day messages are generated from the report mode.
>
Ok, I will send a patch for it.
Thanks,
Denis