2023-04-21 06:08:21

by Daniel Wagner

[permalink] [raw]
Subject: [PATCH REPOST blktests v2 5/9] nvme: Make test image size configurable

The reduce the overall runtime of the testsuite by making the default
size of the test image small. For verification jobs, the default can be
overwriten via the newly introduced nvme_img_size environment variable.

The default size of 350M is the minimum requirement of nvme/012 and
nvme/013. These tests rely on an xfs filesystem which requires this
minimum size.

Signed-off-by: Daniel Wagner <[email protected]>
---
tests/nvme/004 | 2 +-
tests/nvme/005 | 2 +-
tests/nvme/006 | 2 +-
tests/nvme/007 | 2 +-
tests/nvme/008 | 2 +-
tests/nvme/009 | 2 +-
tests/nvme/010 | 5 +++--
tests/nvme/011 | 5 +++--
tests/nvme/012 | 2 +-
tests/nvme/013 | 2 +-
tests/nvme/014 | 2 +-
tests/nvme/015 | 2 +-
tests/nvme/017 | 2 +-
tests/nvme/018 | 2 +-
tests/nvme/019 | 2 +-
tests/nvme/020 | 2 +-
tests/nvme/021 | 2 +-
tests/nvme/022 | 2 +-
tests/nvme/023 | 2 +-
tests/nvme/024 | 2 +-
tests/nvme/025 | 2 +-
tests/nvme/026 | 2 +-
tests/nvme/027 | 2 +-
tests/nvme/028 | 2 +-
tests/nvme/029 | 3 ++-
tests/nvme/031 | 2 +-
tests/nvme/032 | 2 +-
tests/nvme/034 | 2 +-
tests/nvme/035 | 2 +-
tests/nvme/040 | 4 ++--
tests/nvme/041 | 2 +-
tests/nvme/042 | 2 +-
tests/nvme/043 | 2 +-
tests/nvme/044 | 2 +-
tests/nvme/045 | 2 +-
tests/nvme/047 | 2 +-
tests/nvme/048 | 2 +-
tests/nvme/rc | 1 +
38 files changed, 44 insertions(+), 40 deletions(-)

diff --git a/tests/nvme/004 b/tests/nvme/004
index 9dda538b1ac0..cab98ff44326 100755
--- a/tests/nvme/004
+++ b/tests/nvme/004
@@ -25,7 +25,7 @@ test() {
local port
port="$(_create_nvmet_port "${nvme_trtype}")"

- truncate -s 1G "$TMPDIR/img"
+ truncate -s "${nvme_img_size}" "$TMPDIR/img"

local loop_dev
loop_dev="$(losetup -f --show "$TMPDIR/img")"
diff --git a/tests/nvme/005 b/tests/nvme/005
index de567a74a891..8e15a13f3794 100755
--- a/tests/nvme/005
+++ b/tests/nvme/005
@@ -24,7 +24,7 @@ test() {
local port
port="$(_create_nvmet_port "${nvme_trtype}")"

- truncate -s 1G "$TMPDIR/img"
+ truncate -s "${nvme_img_size}" "$TMPDIR/img"

local loop_dev
loop_dev="$(losetup -f --show "$TMPDIR/img")"
diff --git a/tests/nvme/006 b/tests/nvme/006
index d993861c06ba..ea0db93791a7 100755
--- a/tests/nvme/006
+++ b/tests/nvme/006
@@ -24,7 +24,7 @@ test() {

_setup_nvmet

- truncate -s 1G "$TMPDIR/img"
+ truncate -s "${nvme_img_size}" "$TMPDIR/img"

loop_dev="$(losetup -f --show "$TMPDIR/img")"

diff --git a/tests/nvme/007 b/tests/nvme/007
index d53100f3ff7b..243a79f5a254 100755
--- a/tests/nvme/007
+++ b/tests/nvme/007
@@ -25,7 +25,7 @@ test() {

file_path="${TMPDIR}/img"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/008 b/tests/nvme/008
index 5568fe46e463..5abc4240ca46 100755
--- a/tests/nvme/008
+++ b/tests/nvme/008
@@ -26,7 +26,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/009 b/tests/nvme/009
index 2814c79164ee..491d3c809ab0 100755
--- a/tests/nvme/009
+++ b/tests/nvme/009
@@ -24,7 +24,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/010 b/tests/nvme/010
index b7b1d5188e9b..805f80d40620 100755
--- a/tests/nvme/010
+++ b/tests/nvme/010
@@ -26,7 +26,7 @@ test() {
local file_path="${TMPDIR}/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

@@ -41,7 +41,8 @@ test() {
cat "/sys/block/${nvmedev}n1/uuid"
cat "/sys/block/${nvmedev}n1/wwid"

- _run_fio_verify_io --size=950m --filename="/dev/${nvmedev}n1"
+ _run_fio_verify_io --size=${nvme_img_size} \
+ --filename="/dev/${nvmedev}n1"

_nvme_disconnect_subsys "${subsys_name}"

diff --git a/tests/nvme/011 b/tests/nvme/011
index 4bfe9af084e4..da8cbac11124 100755
--- a/tests/nvme/011
+++ b/tests/nvme/011
@@ -26,7 +26,7 @@ test() {
local file_path="${TMPDIR}/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
@@ -39,7 +39,8 @@ test() {
cat "/sys/block/${nvmedev}n1/uuid"
cat "/sys/block/${nvmedev}n1/wwid"

- _run_fio_verify_io --size=950m --filename="/dev/${nvmedev}n1"
+ _run_fio_verify_io --size="${nvme_img_size}" \
+ --filename="/dev/${nvmedev}n1"

_nvme_disconnect_subsys "${subsys_name}"

diff --git a/tests/nvme/012 b/tests/nvme/012
index c9d24388306d..ecf44fcb5a51 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -29,7 +29,7 @@ test() {
local file_path="${TMPDIR}/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/013 b/tests/nvme/013
index 265b6968fd34..e249add46295 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -28,7 +28,7 @@ test() {

local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/014 b/tests/nvme/014
index 28913641ae40..2d00ed392ea8 100755
--- a/tests/nvme/014
+++ b/tests/nvme/014
@@ -29,7 +29,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/015 b/tests/nvme/015
index 2f7957caac88..3755cdee00c9 100755
--- a/tests/nvme/015
+++ b/tests/nvme/015
@@ -28,7 +28,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/017 b/tests/nvme/017
index f2a95cf276cb..0248aee9bc41 100755
--- a/tests/nvme/017
+++ b/tests/nvme/017
@@ -25,7 +25,7 @@ test() {

file_path="${TMPDIR}/img"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/018 b/tests/nvme/018
index 315e79534348..78e9b2bb94d8 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -26,7 +26,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/019 b/tests/nvme/019
index 4cb3509a12b2..9fff8ccaac9c 100755
--- a/tests/nvme/019
+++ b/tests/nvme/019
@@ -28,7 +28,7 @@ test() {
local nblk_range="10,10,10,10,10,10,10,10,10,10"
local sblk_range="100,200,300,400,500,600,700,800,900,1000"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/020 b/tests/nvme/020
index 16fdfcc94918..1966d5925213 100755
--- a/tests/nvme/020
+++ b/tests/nvme/020
@@ -26,7 +26,7 @@ test() {
local nblk_range="10,10,10,10,10,10,10,10,10,10"
local sblk_range="100,200,300,400,500,600,700,800,900,1000"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/021 b/tests/nvme/021
index 6ee0af1fe158..1fefc0fbca00 100755
--- a/tests/nvme/021
+++ b/tests/nvme/021
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/022 b/tests/nvme/022
index 1d76ffa44178..1ff915786f86 100755
--- a/tests/nvme/022
+++ b/tests/nvme/022
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/023 b/tests/nvme/023
index b65be07edc38..90316230a3d7 100755
--- a/tests/nvme/023
+++ b/tests/nvme/023
@@ -26,7 +26,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/024 b/tests/nvme/024
index f756797d6f29..384a8266e741 100755
--- a/tests/nvme/024
+++ b/tests/nvme/024
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/025 b/tests/nvme/025
index 941bf36f67fb..815223d1c28d 100755
--- a/tests/nvme/025
+++ b/tests/nvme/025
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/026 b/tests/nvme/026
index c3f06c2a377c..d2203f19f026 100755
--- a/tests/nvme/026
+++ b/tests/nvme/026
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/027 b/tests/nvme/027
index 0ad663ace811..97fe70e78344 100755
--- a/tests/nvme/027
+++ b/tests/nvme/027
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/028 b/tests/nvme/028
index 7de977a81213..c539620bee28 100755
--- a/tests/nvme/028
+++ b/tests/nvme/028
@@ -25,7 +25,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
diff --git a/tests/nvme/029 b/tests/nvme/029
index f8b4cbbb9156..1808b7b0edf1 100755
--- a/tests/nvme/029
+++ b/tests/nvme/029
@@ -14,6 +14,7 @@ requires() {
_nvme_requires
_have_loop
_require_nvme_trtype_is_fabrics
+ _require_test_dev_size 1M
}

test_user_io()
@@ -59,7 +60,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/031 b/tests/nvme/031
index 4e1798246db1..e70898819a86 100755
--- a/tests/nvme/031
+++ b/tests/nvme/031
@@ -33,7 +33,7 @@ test() {

_setup_nvmet

- truncate -s 1G "$TMPDIR/img"
+ truncate -s "${nvme_img_size}" "$TMPDIR/img"

loop_dev="$(losetup -f --show "$TMPDIR/img")"

diff --git a/tests/nvme/032 b/tests/nvme/032
index 81e074cc11bc..9f9756b0f959 100755
--- a/tests/nvme/032
+++ b/tests/nvme/032
@@ -38,7 +38,7 @@ test_device() {
sysfs="/sys/bus/pci/devices/${pdev}"

# start fio job
- _run_fio_rand_io --filename="$TEST_DEV" --size=1g \
+ _run_fio_rand_io --filename="$TEST_DEV" --size="${nvme_img_size}" \
--group_reporting --time_based --runtime=1m &> /dev/null &

sleep 5
diff --git a/tests/nvme/034 b/tests/nvme/034
index f92e5e20865b..e0ede717c373 100755
--- a/tests/nvme/034
+++ b/tests/nvme/034
@@ -26,7 +26,7 @@ test_device() {
port=$(_nvmet_passthru_target_setup "${subsys}")
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")

- _run_fio_verify_io --size=950m --filename="${nsdev}"
+ _run_fio_verify_io --size="${nvme_img_size}" --filename="${nsdev}"

_nvme_disconnect_subsys "${subsys}"
_nvmet_passthru_target_cleanup "${port}" "${subsys}"
diff --git a/tests/nvme/035 b/tests/nvme/035
index 8b485bc8e682..2c4a25f82937 100755
--- a/tests/nvme/035
+++ b/tests/nvme/035
@@ -17,7 +17,7 @@ requires() {
}

device_requires() {
- _require_test_dev_size 1024m
+ _require_test_dev_size "${nvme_img_size}"
}

test_device() {
diff --git a/tests/nvme/040 b/tests/nvme/040
index 8d29f905adb5..31b7cafef4be 100755
--- a/tests/nvme/040
+++ b/tests/nvme/040
@@ -25,7 +25,7 @@ test() {
echo "Running ${TEST_NAME}"

_setup_nvmet
- truncate -s 1G "$TMPDIR/img"
+ truncate -s "${nvme_img_size}" "$TMPDIR/img"
loop_dev="$(losetup -f --show "$TMPDIR/img")"

port="$(_create_nvmet_port "${nvme_trtype}")"
@@ -37,7 +37,7 @@ test() {

# start fio job
echo "starting background fio"
- _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size=1g \
+ _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size="${nvme_img_size}" \
--group_reporting --ramp_time=5 \
--time_based --runtime=1m &> /dev/null &
sleep 5
diff --git a/tests/nvme/041 b/tests/nvme/041
index 03e2dab25918..308655dd6090 100755
--- a/tests/nvme/041
+++ b/tests/nvme/041
@@ -44,7 +44,7 @@ test() {

_setup_nvmet

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"b92842df-a394-44b1-84a4-92ae7d112861"
diff --git a/tests/nvme/042 b/tests/nvme/042
index 4ad726f72f5a..fed2efead013 100755
--- a/tests/nvme/042
+++ b/tests/nvme/042
@@ -41,7 +41,7 @@ test() {

_setup_nvmet

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}"
port="$(_create_nvmet_port "${nvme_trtype}")"
diff --git a/tests/nvme/043 b/tests/nvme/043
index c031cecf34a5..a030884aa4ed 100755
--- a/tests/nvme/043
+++ b/tests/nvme/043
@@ -42,7 +42,7 @@ test() {

_setup_nvmet

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}"
port="$(_create_nvmet_port "${nvme_trtype}")"
diff --git a/tests/nvme/044 b/tests/nvme/044
index f2406ecadf7d..9928bcc55397 100755
--- a/tests/nvme/044
+++ b/tests/nvme/044
@@ -53,7 +53,7 @@ test() {

_setup_nvmet

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}"
port="$(_create_nvmet_port "${nvme_trtype}")"
diff --git a/tests/nvme/045 b/tests/nvme/045
index 612e5f168e3c..7c51da27b5f1 100755
--- a/tests/nvme/045
+++ b/tests/nvme/045
@@ -55,7 +55,7 @@ test() {

_setup_nvmet

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}"
port="$(_create_nvmet_port "${nvme_trtype}")"
diff --git a/tests/nvme/047 b/tests/nvme/047
index d56d3be185b0..b5a8d469a983 100755
--- a/tests/nvme/047
+++ b/tests/nvme/047
@@ -28,7 +28,7 @@ test() {
local file_path="$TMPDIR/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/048 b/tests/nvme/048
index b4ee7371eb68..08fdee16c811 100755
--- a/tests/nvme/048
+++ b/tests/nvme/048
@@ -84,7 +84,7 @@ test() {
fi
hostnqn="nqn.2014-08.org.nvmexpress:uuid:${hostid}"

- truncate -s 512M "${file_path}"
+ truncate -s "${nvme_img_size}" "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"b92842df-a394-44b1-84a4-92ae7d112861"
diff --git a/tests/nvme/rc b/tests/nvme/rc
index 41f196b037d6..e5ba9a6d5f54 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -17,6 +17,7 @@ def_local_wwpn="0x20001100aa000002"
def_hostnqn="$(cat /etc/nvme/hostnqn 2> /dev/null)"
def_hostid="$(cat /etc/nvme/hostid 2> /dev/null)"
nvme_trtype=${nvme_trtype:-"loop"}
+nvme_img_size=${nvme_img_size:-"350M"}

_nvme_requires() {
_have_program nvme
--
2.40.0


2023-04-21 06:41:20

by Hannes Reinecke

[permalink] [raw]
Subject: Re: [PATCH REPOST blktests v2 5/9] nvme: Make test image size configurable

On 4/21/23 08:05, Daniel Wagner wrote:
> The reduce the overall runtime of the testsuite by making the default
> size of the test image small. For verification jobs, the default can be
> overwriten via the newly introduced nvme_img_size environment variable.
>
> The default size of 350M is the minimum requirement of nvme/012 and
> nvme/013. These tests rely on an xfs filesystem which requires this
> minimum size.
>
> Signed-off-by: Daniel Wagner <[email protected]>
> ---
> tests/nvme/004 | 2 +-
> tests/nvme/005 | 2 +-
> tests/nvme/006 | 2 +-
> tests/nvme/007 | 2 +-
> tests/nvme/008 | 2 +-
> tests/nvme/009 | 2 +-
> tests/nvme/010 | 5 +++--
> tests/nvme/011 | 5 +++--
> tests/nvme/012 | 2 +-
> tests/nvme/013 | 2 +-
> tests/nvme/014 | 2 +-
> tests/nvme/015 | 2 +-
> tests/nvme/017 | 2 +-
> tests/nvme/018 | 2 +-
> tests/nvme/019 | 2 +-
> tests/nvme/020 | 2 +-
> tests/nvme/021 | 2 +-
> tests/nvme/022 | 2 +-
> tests/nvme/023 | 2 +-
> tests/nvme/024 | 2 +-
> tests/nvme/025 | 2 +-
> tests/nvme/026 | 2 +-
> tests/nvme/027 | 2 +-
> tests/nvme/028 | 2 +-
> tests/nvme/029 | 3 ++-
> tests/nvme/031 | 2 +-
> tests/nvme/032 | 2 +-
> tests/nvme/034 | 2 +-
> tests/nvme/035 | 2 +-
> tests/nvme/040 | 4 ++--
> tests/nvme/041 | 2 +-
> tests/nvme/042 | 2 +-
> tests/nvme/043 | 2 +-
> tests/nvme/044 | 2 +-
> tests/nvme/045 | 2 +-
> tests/nvme/047 | 2 +-
> tests/nvme/048 | 2 +-
> tests/nvme/rc | 1 +
> 38 files changed, 44 insertions(+), 40 deletions(-)
>
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman

2023-04-28 03:09:05

by Shinichiro Kawasaki

[permalink] [raw]
Subject: Re: [PATCH REPOST blktests v2 5/9] nvme: Make test image size configurable

On Apr 21, 2023 / 08:05, Daniel Wagner wrote:
> The reduce the overall runtime of the testsuite by making the default
> size of the test image small. For verification jobs, the default can be
> overwriten via the newly introduced nvme_img_size environment variable.

Could you add descripion of nvme_img_size in Documentation/runnning-test.md?

I've noticed that tcp and fc of nvme_trtype are not described, but this is a
different topic :)

>
> The default size of 350M is the minimum requirement of nvme/012 and
> nvme/013. These tests rely on an xfs filesystem which requires this
> minimum size.

I read back discurrions on the v1 series, and I'm not sure if it is agreed to
decrease the default size from 1G to smaller value. My understanding is that
Chaitanya's points are:

- Let's keep 1GB default size for consistency for blktests users.
- Introduce nvme_img_size so that those who needs faster test run can
set smaller size.

>
> Signed-off-by: Daniel Wagner <[email protected]>
> ---
> tests/nvme/004 | 2 +-
> tests/nvme/005 | 2 +-
> tests/nvme/006 | 2 +-
> tests/nvme/007 | 2 +-
> tests/nvme/008 | 2 +-
> tests/nvme/009 | 2 +-
> tests/nvme/010 | 5 +++--
> tests/nvme/011 | 5 +++--
> tests/nvme/012 | 2 +-
> tests/nvme/013 | 2 +-
> tests/nvme/014 | 2 +-
> tests/nvme/015 | 2 +-
> tests/nvme/017 | 2 +-
> tests/nvme/018 | 2 +-
> tests/nvme/019 | 2 +-
> tests/nvme/020 | 2 +-
> tests/nvme/021 | 2 +-
> tests/nvme/022 | 2 +-
> tests/nvme/023 | 2 +-
> tests/nvme/024 | 2 +-
> tests/nvme/025 | 2 +-
> tests/nvme/026 | 2 +-
> tests/nvme/027 | 2 +-
> tests/nvme/028 | 2 +-
> tests/nvme/029 | 3 ++-
> tests/nvme/031 | 2 +-
> tests/nvme/032 | 2 +-
> tests/nvme/034 | 2 +-
> tests/nvme/035 | 2 +-
> tests/nvme/040 | 4 ++--
> tests/nvme/041 | 2 +-
> tests/nvme/042 | 2 +-
> tests/nvme/043 | 2 +-
> tests/nvme/044 | 2 +-
> tests/nvme/045 | 2 +-
> tests/nvme/047 | 2 +-
> tests/nvme/048 | 2 +-
> tests/nvme/rc | 1 +
> 38 files changed, 44 insertions(+), 40 deletions(-)
>
> diff --git a/tests/nvme/004 b/tests/nvme/004
> index 9dda538b1ac0..cab98ff44326 100755
> --- a/tests/nvme/004
> +++ b/tests/nvme/004
> @@ -25,7 +25,7 @@ test() {
> local port
> port="$(_create_nvmet_port "${nvme_trtype}")"
>
> - truncate -s 1G "$TMPDIR/img"
> + truncate -s "${nvme_img_size}" "$TMPDIR/img"
>
> local loop_dev
> loop_dev="$(losetup -f --show "$TMPDIR/img")"
> diff --git a/tests/nvme/005 b/tests/nvme/005
> index de567a74a891..8e15a13f3794 100755
> --- a/tests/nvme/005
> +++ b/tests/nvme/005
> @@ -24,7 +24,7 @@ test() {
> local port
> port="$(_create_nvmet_port "${nvme_trtype}")"
>
> - truncate -s 1G "$TMPDIR/img"
> + truncate -s "${nvme_img_size}" "$TMPDIR/img"
>
> local loop_dev
> loop_dev="$(losetup -f --show "$TMPDIR/img")"
> diff --git a/tests/nvme/006 b/tests/nvme/006
> index d993861c06ba..ea0db93791a7 100755
> --- a/tests/nvme/006
> +++ b/tests/nvme/006
> @@ -24,7 +24,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 1G "$TMPDIR/img"
> + truncate -s "${nvme_img_size}" "$TMPDIR/img"
>
> loop_dev="$(losetup -f --show "$TMPDIR/img")"
>
> diff --git a/tests/nvme/007 b/tests/nvme/007
> index d53100f3ff7b..243a79f5a254 100755
> --- a/tests/nvme/007
> +++ b/tests/nvme/007
> @@ -25,7 +25,7 @@ test() {
>
> file_path="${TMPDIR}/img"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/008 b/tests/nvme/008
> index 5568fe46e463..5abc4240ca46 100755
> --- a/tests/nvme/008
> +++ b/tests/nvme/008
> @@ -26,7 +26,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/009 b/tests/nvme/009
> index 2814c79164ee..491d3c809ab0 100755
> --- a/tests/nvme/009
> +++ b/tests/nvme/009
> @@ -24,7 +24,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/010 b/tests/nvme/010
> index b7b1d5188e9b..805f80d40620 100755
> --- a/tests/nvme/010
> +++ b/tests/nvme/010
> @@ -26,7 +26,7 @@ test() {
> local file_path="${TMPDIR}/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> @@ -41,7 +41,8 @@ test() {
> cat "/sys/block/${nvmedev}n1/uuid"
> cat "/sys/block/${nvmedev}n1/wwid"
>
> - _run_fio_verify_io --size=950m --filename="/dev/${nvmedev}n1"
> + _run_fio_verify_io --size=${nvme_img_size} \
> + --filename="/dev/${nvmedev}n1"
>
> _nvme_disconnect_subsys "${subsys_name}"
>
> diff --git a/tests/nvme/011 b/tests/nvme/011
> index 4bfe9af084e4..da8cbac11124 100755
> --- a/tests/nvme/011
> +++ b/tests/nvme/011
> @@ -26,7 +26,7 @@ test() {
> local file_path="${TMPDIR}/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> @@ -39,7 +39,8 @@ test() {
> cat "/sys/block/${nvmedev}n1/uuid"
> cat "/sys/block/${nvmedev}n1/wwid"
>
> - _run_fio_verify_io --size=950m --filename="/dev/${nvmedev}n1"
> + _run_fio_verify_io --size="${nvme_img_size}" \
> + --filename="/dev/${nvmedev}n1"
>
> _nvme_disconnect_subsys "${subsys_name}"
>
> diff --git a/tests/nvme/012 b/tests/nvme/012
> index c9d24388306d..ecf44fcb5a51 100755
> --- a/tests/nvme/012
> +++ b/tests/nvme/012
> @@ -29,7 +29,7 @@ test() {
> local file_path="${TMPDIR}/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/013 b/tests/nvme/013
> index 265b6968fd34..e249add46295 100755
> --- a/tests/nvme/013
> +++ b/tests/nvme/013
> @@ -28,7 +28,7 @@ test() {
>
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/014 b/tests/nvme/014
> index 28913641ae40..2d00ed392ea8 100755
> --- a/tests/nvme/014
> +++ b/tests/nvme/014
> @@ -29,7 +29,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/015 b/tests/nvme/015
> index 2f7957caac88..3755cdee00c9 100755
> --- a/tests/nvme/015
> +++ b/tests/nvme/015
> @@ -28,7 +28,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/017 b/tests/nvme/017
> index f2a95cf276cb..0248aee9bc41 100755
> --- a/tests/nvme/017
> +++ b/tests/nvme/017
> @@ -25,7 +25,7 @@ test() {
>
> file_path="${TMPDIR}/img"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/018 b/tests/nvme/018
> index 315e79534348..78e9b2bb94d8 100755
> --- a/tests/nvme/018
> +++ b/tests/nvme/018
> @@ -26,7 +26,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/019 b/tests/nvme/019
> index 4cb3509a12b2..9fff8ccaac9c 100755
> --- a/tests/nvme/019
> +++ b/tests/nvme/019
> @@ -28,7 +28,7 @@ test() {
> local nblk_range="10,10,10,10,10,10,10,10,10,10"
> local sblk_range="100,200,300,400,500,600,700,800,900,1000"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/020 b/tests/nvme/020
> index 16fdfcc94918..1966d5925213 100755
> --- a/tests/nvme/020
> +++ b/tests/nvme/020
> @@ -26,7 +26,7 @@ test() {
> local nblk_range="10,10,10,10,10,10,10,10,10,10"
> local sblk_range="100,200,300,400,500,600,700,800,900,1000"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/021 b/tests/nvme/021
> index 6ee0af1fe158..1fefc0fbca00 100755
> --- a/tests/nvme/021
> +++ b/tests/nvme/021
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/022 b/tests/nvme/022
> index 1d76ffa44178..1ff915786f86 100755
> --- a/tests/nvme/022
> +++ b/tests/nvme/022
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/023 b/tests/nvme/023
> index b65be07edc38..90316230a3d7 100755
> --- a/tests/nvme/023
> +++ b/tests/nvme/023
> @@ -26,7 +26,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/024 b/tests/nvme/024
> index f756797d6f29..384a8266e741 100755
> --- a/tests/nvme/024
> +++ b/tests/nvme/024
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/025 b/tests/nvme/025
> index 941bf36f67fb..815223d1c28d 100755
> --- a/tests/nvme/025
> +++ b/tests/nvme/025
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/026 b/tests/nvme/026
> index c3f06c2a377c..d2203f19f026 100755
> --- a/tests/nvme/026
> +++ b/tests/nvme/026
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/027 b/tests/nvme/027
> index 0ad663ace811..97fe70e78344 100755
> --- a/tests/nvme/027
> +++ b/tests/nvme/027
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/028 b/tests/nvme/028
> index 7de977a81213..c539620bee28 100755
> --- a/tests/nvme/028
> +++ b/tests/nvme/028
> @@ -25,7 +25,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "91fdba0d-f87b-4c25-b80f-db7be1418b9e"
> diff --git a/tests/nvme/029 b/tests/nvme/029
> index f8b4cbbb9156..1808b7b0edf1 100755
> --- a/tests/nvme/029
> +++ b/tests/nvme/029
> @@ -14,6 +14,7 @@ requires() {
> _nvme_requires
> _have_loop
> _require_nvme_trtype_is_fabrics
> + _require_test_dev_size 1M
> }
>
> test_user_io()
> @@ -59,7 +60,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 1G "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/031 b/tests/nvme/031
> index 4e1798246db1..e70898819a86 100755
> --- a/tests/nvme/031
> +++ b/tests/nvme/031
> @@ -33,7 +33,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 1G "$TMPDIR/img"
> + truncate -s "${nvme_img_size}" "$TMPDIR/img"
>
> loop_dev="$(losetup -f --show "$TMPDIR/img")"
>
> diff --git a/tests/nvme/032 b/tests/nvme/032
> index 81e074cc11bc..9f9756b0f959 100755
> --- a/tests/nvme/032
> +++ b/tests/nvme/032
> @@ -38,7 +38,7 @@ test_device() {
> sysfs="/sys/bus/pci/devices/${pdev}"
>
> # start fio job
> - _run_fio_rand_io --filename="$TEST_DEV" --size=1g \
> + _run_fio_rand_io --filename="$TEST_DEV" --size="${nvme_img_size}" \
> --group_reporting --time_based --runtime=1m &> /dev/null &
>
> sleep 5
> diff --git a/tests/nvme/034 b/tests/nvme/034
> index f92e5e20865b..e0ede717c373 100755
> --- a/tests/nvme/034
> +++ b/tests/nvme/034
> @@ -26,7 +26,7 @@ test_device() {
> port=$(_nvmet_passthru_target_setup "${subsys}")
> nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
>
> - _run_fio_verify_io --size=950m --filename="${nsdev}"
> + _run_fio_verify_io --size="${nvme_img_size}" --filename="${nsdev}"
>
> _nvme_disconnect_subsys "${subsys}"
> _nvmet_passthru_target_cleanup "${port}" "${subsys}"
> diff --git a/tests/nvme/035 b/tests/nvme/035
> index 8b485bc8e682..2c4a25f82937 100755
> --- a/tests/nvme/035
> +++ b/tests/nvme/035
> @@ -17,7 +17,7 @@ requires() {
> }
>
> device_requires() {
> - _require_test_dev_size 1024m
> + _require_test_dev_size "${nvme_img_size}"
> }
>

This change looks weird for me. The required size of TEST_DEV can vary depending
on user's configuration. I think nvme_img_size specify the device size that each
test case prepares, isn't it?

> test_device() {
> diff --git a/tests/nvme/040 b/tests/nvme/040
> index 8d29f905adb5..31b7cafef4be 100755
> --- a/tests/nvme/040
> +++ b/tests/nvme/040
> @@ -25,7 +25,7 @@ test() {
> echo "Running ${TEST_NAME}"
>
> _setup_nvmet
> - truncate -s 1G "$TMPDIR/img"
> + truncate -s "${nvme_img_size}" "$TMPDIR/img"
> loop_dev="$(losetup -f --show "$TMPDIR/img")"
>
> port="$(_create_nvmet_port "${nvme_trtype}")"
> @@ -37,7 +37,7 @@ test() {
>
> # start fio job
> echo "starting background fio"
> - _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size=1g \
> + _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size="${nvme_img_size}" \
> --group_reporting --ramp_time=5 \
> --time_based --runtime=1m &> /dev/null &
> sleep 5
> diff --git a/tests/nvme/041 b/tests/nvme/041
> index 03e2dab25918..308655dd6090 100755
> --- a/tests/nvme/041
> +++ b/tests/nvme/041
> @@ -44,7 +44,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "b92842df-a394-44b1-84a4-92ae7d112861"
> diff --git a/tests/nvme/042 b/tests/nvme/042
> index 4ad726f72f5a..fed2efead013 100755
> --- a/tests/nvme/042
> +++ b/tests/nvme/042
> @@ -41,7 +41,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}"
> port="$(_create_nvmet_port "${nvme_trtype}")"
> diff --git a/tests/nvme/043 b/tests/nvme/043
> index c031cecf34a5..a030884aa4ed 100755
> --- a/tests/nvme/043
> +++ b/tests/nvme/043
> @@ -42,7 +42,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}"
> port="$(_create_nvmet_port "${nvme_trtype}")"
> diff --git a/tests/nvme/044 b/tests/nvme/044
> index f2406ecadf7d..9928bcc55397 100755
> --- a/tests/nvme/044
> +++ b/tests/nvme/044
> @@ -53,7 +53,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}"
> port="$(_create_nvmet_port "${nvme_trtype}")"
> diff --git a/tests/nvme/045 b/tests/nvme/045
> index 612e5f168e3c..7c51da27b5f1 100755
> --- a/tests/nvme/045
> +++ b/tests/nvme/045
> @@ -55,7 +55,7 @@ test() {
>
> _setup_nvmet
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}"
> port="$(_create_nvmet_port "${nvme_trtype}")"
> diff --git a/tests/nvme/047 b/tests/nvme/047
> index d56d3be185b0..b5a8d469a983 100755
> --- a/tests/nvme/047
> +++ b/tests/nvme/047
> @@ -28,7 +28,7 @@ test() {
> local file_path="$TMPDIR/img"
> local subsys_name="blktests-subsystem-1"
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> loop_dev="$(losetup -f --show "${file_path}")"
>
> diff --git a/tests/nvme/048 b/tests/nvme/048
> index b4ee7371eb68..08fdee16c811 100755
> --- a/tests/nvme/048
> +++ b/tests/nvme/048
> @@ -84,7 +84,7 @@ test() {
> fi
> hostnqn="nqn.2014-08.org.nvmexpress:uuid:${hostid}"
>
> - truncate -s 512M "${file_path}"
> + truncate -s "${nvme_img_size}" "${file_path}"
>
> _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> "b92842df-a394-44b1-84a4-92ae7d112861"
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 41f196b037d6..e5ba9a6d5f54 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -17,6 +17,7 @@ def_local_wwpn="0x20001100aa000002"
> def_hostnqn="$(cat /etc/nvme/hostnqn 2> /dev/null)"
> def_hostid="$(cat /etc/nvme/hostid 2> /dev/null)"
> nvme_trtype=${nvme_trtype:-"loop"}
> +nvme_img_size=${nvme_img_size:-"350M"}
>
> _nvme_requires() {
> _have_program nvme
> --
> 2.40.0
>