2020-12-31 18:10:05

by Xie He

Subject: [PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

In lapb_device_event, lapb_devtostruct is called to get a reference to
an object of "struct lapb_cb". lapb_devtostruct increases the refcount
of the object and returns a pointer to it. However, we didn't decrease
the refcount after we finished using the pointer. This patch fixes this
problem.

Fixes: a4989fa91110 ("net/lapb: support netdev events")
Cc: Martin Schiller <[email protected]>
Signed-off-by: Xie He <[email protected]>
---
net/lapb/lapb_iface.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c
index 213ea7abc9ab..40961889e9c0 100644
--- a/net/lapb/lapb_iface.c
+++ b/net/lapb/lapb_iface.c
@@ -489,6 +489,7 @@ static int lapb_device_event(struct notifier_block *this, unsigned long event,
break;
}

+ lapb_put(lapb);
return NOTIFY_DONE;
}

--
2.27.0

2021-01-04 21:53:31

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 31 Dec 2020 09:43:31 -0800 you wrote:
> In lapb_device_event, lapb_devtostruct is called to get a reference to
> an object of "struct lapb_cb". lapb_devtostruct increases the refcount
> of the object and returns a pointer to it. However, we didn't decrease
> the refcount after we finished using the pointer. This patch fixes this
> problem.
>
> Fixes: a4989fa91110 ("net/lapb: support netdev events")
> Cc: Martin Schiller <[email protected]>
> Signed-off-by: Xie He <[email protected]>
>
> [...]

Here is the summary with links:
- [net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event
https://git.kernel.org/netdev/net/c/b40f97b91a3b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2021-01-06 07:40:56

by Martin Schiller

Subject: Re: [PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

On 2020-12-31 18:43, Xie He wrote:
> In lapb_device_event, lapb_devtostruct is called to get a reference to
> an object of "struct lapb_cb". lapb_devtostruct increases the refcount
> of the object and returns a pointer to it. However, we didn't decrease
> the refcount after we finished using the pointer. This patch fixes this
> problem.
>
> Fixes: a4989fa91110 ("net/lapb: support netdev events")
> Cc: Martin Schiller <[email protected]>
> Signed-off-by: Xie He <[email protected]>
> ---
> net/lapb/lapb_iface.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c
> index 213ea7abc9ab..40961889e9c0 100644
> --- a/net/lapb/lapb_iface.c
> +++ b/net/lapb/lapb_iface.c
> @@ -489,6 +489,7 @@ static int lapb_device_event(struct notifier_block
> *this, unsigned long event,
> break;
> }
>
> + lapb_put(lapb);
> return NOTIFY_DONE;
> }

Well, I guess I missed that one. Thank you!

Acked-by: Martin Schiller <[email protected]>