2021-04-22 14:18:31

by Benjamin Gaignard

Subject: [PATCH v2 2/4] dt-bindings: iommu: rockchip: Add compatible for v2

Add compatible for the second version of IOMMU hardware block.
RK356x IOMMU can also be link to a power domain.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
version 2:
- Add power-domains property

.../devicetree/bindings/iommu/rockchip,iommu.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
index 0db208cf724a..e54353ccd1ec 100644
--- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
@@ -19,7 +19,9 @@ description: |+

properties:
compatible:
- const: rockchip,iommu
+ enum:
+ - rockchip,iommu
+ - rockchip,iommu-v2

reg:
minItems: 1
@@ -46,6 +48,9 @@ properties:
"#iommu-cells":
const: 0

+ power-domains:
+ maxItems: 1
+
rockchip,disable-mmu-reset:
$ref: /schemas/types.yaml#/definitions/flag
description: |
--
2.25.1

2021-05-01 01:37:05

by Rob Herring (Arm)

Subject: Re: [PATCH v2 2/4] dt-bindings: iommu: rockchip: Add compatible for v2

On Thu, Apr 22, 2021 at 04:16:00PM +0200, Benjamin Gaignard wrote:
> Add compatible for the second version of IOMMU hardware block.
> RK356x IOMMU can also be link to a power domain.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> version 2:
> - Add power-domains property
>
> .../devicetree/bindings/iommu/rockchip,iommu.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> index 0db208cf724a..e54353ccd1ec 100644
> --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> @@ -19,7 +19,9 @@ description: |+
>
> properties:
> compatible:
> - const: rockchip,iommu
> + enum:
> + - rockchip,iommu
> + - rockchip,iommu-v2

This should be SoC specific.

>
> reg:
> minItems: 1
> @@ -46,6 +48,9 @@ properties:
> "#iommu-cells":
> const: 0
>
> + power-domains:
> + maxItems: 1
> +
> rockchip,disable-mmu-reset:
> $ref: /schemas/types.yaml#/definitions/flag
> description: |
> --
> 2.25.1
>

2021-05-04 10:17:56

by Ezequiel Garcia

Subject: Re: [PATCH v2 2/4] dt-bindings: iommu: rockchip: Add compatible for v2

Hi Rob,

On Friday, April 30, 2021 22:34 -03, Rob Herring <[email protected]> wrote:

> On Thu, Apr 22, 2021 at 04:16:00PM +0200, Benjamin Gaignard wrote:
> > Add compatible for the second version of IOMMU hardware block.
> > RK356x IOMMU can also be link to a power domain.
> >
> > Signed-off-by: Benjamin Gaignard <[email protected]>
> > ---
> > version 2:
> > - Add power-domains property
> >
> > .../devicetree/bindings/iommu/rockchip,iommu.yaml | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> > index 0db208cf724a..e54353ccd1ec 100644
> > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> > @@ -19,7 +19,9 @@ description: |+
> >
> > properties:
> > compatible:
> > - const: rockchip,iommu
> > + enum:
> > + - rockchip,iommu
> > + - rockchip,iommu-v2
>
> This should be SoC specific.
>

It seems iommu-v2 is really the name Rockchip gives to this IOMMU IP core.
Can we keep the "rockchip,iommu-v2" compatible, and add SoC-specific ones, as we normally do:

compatible = "rockchip,rk3568-iommu", "rockchip,iommu-v2";

Just like we'd do with any peripheral:

compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";

Thanks!
Ezequiel