2020-01-27 16:24:57

by Shiping Ji

[permalink] [raw]
Subject: [PATCH v11 1/2] dt-bindings: edac: dmc-520.yaml

This is the device tree bindings for new EDAC driver dmc520_edac.c.

From: Lei Wang <[email protected]>

Signed-off-by: Lei Wang <[email protected]>
Signed-off-by: Shiping Ji <[email protected]>
Reviewed-by: James Morse <[email protected]>

---
Changes in v11:
- Fix issues reported by make dt_binding_check

---
.../devicetree/bindings/edac/dmc-520.yaml | 59 +++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/edac/dmc-520.yaml

diff --git a/Documentation/devicetree/bindings/edac/dmc-520.yaml b/Documentation/devicetree/bindings/edac/dmc-520.yaml
new file mode 100644
index 000000000000..9272d2bd8634
--- /dev/null
+++ b/Documentation/devicetree/bindings/edac/dmc-520.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/edac/dmc-520.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM DMC-520 EDAC bindings
+
+maintainers:
+ - Lei Wang <[email protected]>
+
+description: |+
+ DMC-520 node is defined to describe DRAM error detection and correction.
+
+ https://static.docs.arm.com/100000/0200/corelink_dmc520_trm_100000_0200_01_en.pdf
+
+properties:
+ compatible:
+ items:
+ - const: brcm,dmc-520
+ - const: arm,dmc-520
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 1
+ maxItems: 10
+
+ interrupt-names:
+ minItems: 1
+ maxItems: 10
+ items:
+ enum:
+ - ram_ecc_errc
+ - ram_ecc_errd
+ - dram_ecc_errc
+ - dram_ecc_errd
+ - failed_access
+ - failed_prog
+ - link_err
+ - temperature_event
+ - arch_fsm
+ - phy_request
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-names
+
+examples:
+ - |
+ dmc0: dmc@200000 {
+ compatible = "brcm,dmc-520", "arm,dmc-520";
+ reg = <0x200000 0x80000>;
+ interrupts = <0x0 0x349 0x4>, <0x0 0x34B 0x4>;
+ interrupt-names = "dram_ecc_errc", "dram_ecc_errd";
+ };
--
2.17.1


2020-02-05 17:49:37

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v11 1/2] dt-bindings: edac: dmc-520.yaml

On Mon, 27 Jan 2020 08:23:08 -0800, Shiping Ji wrote:
> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>
> From: Lei Wang <[email protected]>
>
> Signed-off-by: Lei Wang <[email protected]>
> Signed-off-by: Shiping Ji <[email protected]>
> Reviewed-by: James Morse <[email protected]>
>
> ---
> Changes in v11:
> - Fix issues reported by make dt_binding_check
>
> ---
> .../devicetree/bindings/edac/dmc-520.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/dmc-520.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2020-02-17 18:29:30

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH v11 1/2] dt-bindings: edac: dmc-520.yaml

On Mon, Jan 27, 2020 at 08:23:08AM -0800, Shiping Ji wrote:
> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>
> From: Lei Wang <[email protected]>
>
> Signed-off-by: Lei Wang <[email protected]>
> Signed-off-by: Shiping Ji <[email protected]>
> Reviewed-by: James Morse <[email protected]>
>
> ---
> Changes in v11:
> - Fix issues reported by make dt_binding_check
>
> ---
> .../devicetree/bindings/edac/dmc-520.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/dmc-520.yaml

I have only this v11 patch 1/2 in my inbox and not the actual driver,
i.e., patch 2/2.

For the driver, I have v10 here:

https://lkml.kernel.org/r/[email protected]

Did you send a v11 of the driver itself or should I have a look at v10?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

2020-02-18 17:13:31

by Shiping Ji

[permalink] [raw]
Subject: Re: [PATCH v11 1/2] dt-bindings: edac: dmc-520.yaml

On 2/17/2020 10:10 AM, Borislav Petkov wrote:
> I have only this v11 patch 1/2 in my inbox and not the actual driver,
> i.e., patch 2/2.
>
> For the driver, I have v10 here:
>
> https://lkml.kernel.org/r/[email protected]
>
> Did you send a v11 of the driver itself or should I have a look at v10?

Actually I didn't send v11 of the driver since it will be identical to
v10, sorry for keeping you waiting on this. Please review v10, thanks!

--
Best regards,
Shiping Ji


2020-02-19 20:04:19

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH v11 1/2] dt-bindings: edac: dmc-520.yaml

On Tue, Feb 18, 2020 at 09:12:15AM -0800, Shiping Ji wrote:
> Actually I didn't send v11 of the driver since it will be identical to v10,
> sorry for keeping you waiting on this. Please review v10, thanks!

Ok, both patches queued and will appear in linux-next soon.

Thanks for the effort and persistence!

:-)

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

2020-02-19 23:27:35

by Shiping Ji

[permalink] [raw]
Subject: Re: [PATCH v11 1/2] dt-bindings: edac: dmc-520.yaml

On 2/19/2020 12:03 PM, Borislav Petkov wrote:
> On Tue, Feb 18, 2020 at 09:12:15AM -0800, Shiping Ji wrote:
>> Actually I didn't send v11 of the driver since it will be identical to v10,
>> sorry for keeping you waiting on this. Please review v10, thanks!
>
> Ok, both patches queued and will appear in linux-next soon.
>
> Thanks for the effort and persistence!
>
> :-)

Thanks a lot for the prompt action! This is great learning process for me :)

--
Best regards,
Shiping Ji