2024-05-07 09:13:38

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH net v5 2/4] ax25: Fix reference count leak issues of ax25_dev

> The ax25_addr_ax25dev() and ax25_dev_device_down() exist a reference
> count leak issue of the object "ax25_dev".

Please improve this wording.

Suggestion:
Two function implementations contained programming mistakes.
Thus …


> Memory leak issue in ax25_addr_ax25dev():
>
> The reference count of the object "ax25_dev" can be increased multiple
> times in ax25_addr_ax25dev(). This will cause a memory leak so far.


* How do you think about to work with indentation in such a description
for item enumeration?

* Would you like to add imperative wordings for improved changelogs?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94

Regards,
Markus