2020-12-04 09:19:17

by Huang, Ying

[permalink] [raw]
Subject: [PATCH -V7 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

Signed-off-by: "Huang, Ying" <[email protected]>
---
man2/set_mempolicy.2 | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
index 68011eecb..fb2e6fd96 100644
--- a/man2/set_mempolicy.2
+++ b/man2/set_mempolicy.2
@@ -113,6 +113,15 @@ A nonempty
.I nodemask
specifies node IDs that are relative to the set of
node IDs allowed by the process's current cpuset.
+.TP
+.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
+When
+.I mode
+is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if
+it is supported by kernel.
+If the flag isn't supported by Linux kernel, or is used with
+.I mode
+other than MPOL_BIND, return -1 and errno is set to EINVAL.
.PP
.I nodemask
points to a bit mask of node IDs that contains up to
@@ -293,6 +302,11 @@ argument specified both
.B MPOL_F_STATIC_NODES
and
.BR MPOL_F_RELATIVE_NODES .
+Or, the
+.B MPOL_F_NUMA_BALANCING
+isn't supported by the Linux kernel, or is used with
+.I mode
+other than MPOL_BIND.
.TP
.B ENOMEM
Insufficient kernel memory was available.
--
2.29.2


2020-12-04 13:30:03

by Alejandro Colomar

[permalink] [raw]
Subject: Re: [PATCH -V7 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

Hi Huang Ying,

Please, see a few fixes below.

Thanks,

Alex

On 12/4/20 10:15 AM, Huang Ying wrote:
> Signed-off-by: "Huang, Ying" <[email protected]>
> ---
> man2/set_mempolicy.2 | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
> index 68011eecb..fb2e6fd96 100644
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -113,6 +113,15 @@ A nonempty
> .I nodemask
> specifies node IDs that are relative to the set of
> node IDs allowed by the process's current cpuset.
> +.TP
> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
> +When
> +.I mode
> +is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if

.B MPOL_BIND

> +it is supported by kernel.
> +If the flag isn't supported by Linux kernel, or is used with
> +.I mode> +other than MPOL_BIND, return -1 and errno is set to EINVAL.

.BR MPOL_BIND ,

A minus sign should be escaped:
\-1
See man-pages(7)::STYLE GUIDE::Generating optimal glyphs)

.I errno
.BR EINVAL .

> .PP
> .I nodemask
> points to a bit mask of node IDs that contains up to
> @@ -293,6 +302,11 @@ argument specified both
> .B MPOL_F_STATIC_NODES
> and
> .BR MPOL_F_RELATIVE_NODES .
> +Or, the
> +.B MPOL_F_NUMA_BALANCING
> +isn't supported by the Linux kernel, or is used with
> +.I mode
> +other than MPOL_BIND.

.BR MPOL_BIND .

> .TP
> .B ENOMEM
> Insufficient kernel memory was available.
>

2020-12-07 00:54:56

by Huang, Ying

[permalink] [raw]
Subject: Re: [PATCH -V7 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

Hi, Alex,

"Alejandro Colomar (man-pages)" <[email protected]> writes:

> Hi Huang Ying,
>
> Please, see a few fixes below.
>
> Thanks,
>
> Alex
>
> On 12/4/20 10:15 AM, Huang Ying wrote:
>> Signed-off-by: "Huang, Ying" <[email protected]>
>> ---
>> man2/set_mempolicy.2 | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
>> index 68011eecb..fb2e6fd96 100644
>> --- a/man2/set_mempolicy.2
>> +++ b/man2/set_mempolicy.2
>> @@ -113,6 +113,15 @@ A nonempty
>> .I nodemask
>> specifies node IDs that are relative to the set of
>> node IDs allowed by the process's current cpuset.
>> +.TP
>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
>> +When
>> +.I mode
>> +is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if
>
> .B MPOL_BIND
>
>> +it is supported by kernel.
>> +If the flag isn't supported by Linux kernel, or is used with
>> +.I mode> +other than MPOL_BIND, return -1 and errno is set to EINVAL.
>
> .BR MPOL_BIND ,
>
> A minus sign should be escaped:
> \-1
> See man-pages(7)::STYLE GUIDE::Generating optimal glyphs)
>
> .I errno
> .BR EINVAL .
>
>> .PP
>> .I nodemask
>> points to a bit mask of node IDs that contains up to
>> @@ -293,6 +302,11 @@ argument specified both
>> .B MPOL_F_STATIC_NODES
>> and
>> .BR MPOL_F_RELATIVE_NODES .
>> +Or, the
>> +.B MPOL_F_NUMA_BALANCING
>> +isn't supported by the Linux kernel, or is used with
>> +.I mode
>> +other than MPOL_BIND.
>
> .BR MPOL_BIND .
>
>> .TP
>> .B ENOMEM
>> Insufficient kernel memory was available.
>>

Thanks a lot for your comments! Will change them in the next version.

Best Regards,
Huang, Ying