2022-04-29 11:53:37

by Alex Elder

[permalink] [raw]
Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

On 4/27/22 5:49 PM, Guilherme G. Piccoli wrote:
> This patch renames the panic_notifier_list to panic_pre_reboot_list;
> the idea is that a subsequent patch will refactor the panic path
> in order to better split the notifiers, running some of them very
> early, some of them not so early [but still before kmsg_dump()] and
> finally, the rest should execute late, after kdump. The latter ones
> are now in the panic pre-reboot list - the name comes from the idea
> that these notifiers execute before panic() attempts rebooting the
> machine (if that option is set).
>
> We also took the opportunity to clean-up useless header inclusions,
> improve some notifier block declarations (e.g. in ibmasm/heartbeat.c)
> and more important, change some priorities - we hereby set 2 notifiers
> to run late in the list [iss_panic_event() and the IPMI panic_event()]
> due to the risks they offer (may not return, for example).
> Proper documentation is going to be provided in a subsequent patch,
> that effectively refactors the panic path.
>
> Cc: Alex Elder <[email protected]>

For "drivers/net/ipa/ipa_smp2p.c":

Acked-by: Alex Elder <[email protected]>

> Cc: Alexander Gordeev <[email protected]>
> Cc: Anton Ivanov <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: Boris Ostrovsky <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: Christian Borntraeger <[email protected]>
> Cc: Corey Minyard <[email protected]>
> Cc: Dexuan Cui <[email protected]>
> Cc: "H. Peter Anvin" <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: Heiko Carstens <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: Ivan Kokshaysky <[email protected]>
> Cc: "James E.J. Bottomley" <[email protected]>
> Cc: James Morse <[email protected]>
> Cc: Johannes Berg <[email protected]>
> Cc: Juergen Gross <[email protected]>
> Cc: "K. Y. Srinivasan" <[email protected]>
> Cc: Mathieu Poirier <[email protected]>
> Cc: Matt Turner <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Max Filippov <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Richard Henderson <[email protected]>
> Cc: Richard Weinberger <[email protected]>
> Cc: Robert Richter <[email protected]>
> Cc: Stefano Stabellini <[email protected]>
> Cc: Stephen Hemminger <[email protected]>
> Cc: Sven Schnelle <[email protected]>
> Cc: Tony Luck <[email protected]>
> Cc: Vasily Gorbik <[email protected]>
> Cc: Wei Liu <[email protected]>
> Signed-off-by: Guilherme G. Piccoli <[email protected]>
> ---
>

. . .