2024-01-15 05:36:53

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] clocksource: arm_global_timer: fix non-kernel-doc comment

Use a common C comment "/*" instead of a kernel-doc marker "/**"
to prevent kernel-doc warnings:

arm_global_timer.c:92: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* To ensure that updates to comparator value register do not set the
arm_global_timer.c:92: warning: missing initial short description on line:
* To ensure that updates to comparator value register do not set the

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: [email protected]
Cc: Daniel Lezcano <[email protected]>
Cc: Thomas Gleixner <[email protected]>
---
drivers/clocksource/arm_global_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -88,7 +88,7 @@ static u64 gt_counter_read(void)
return _gt_counter_read();
}

-/**
+/*
* To ensure that updates to comparator value register do not set the
* Interrupt Status Register proceed as follows:
* 1. Clear the Comp Enable bit in the Timer Control Register.


2024-02-21 09:04:33

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH] clocksource: arm_global_timer: fix non-kernel-doc comment

On 15/01/2024 06:36, Randy Dunlap wrote:
> Use a common C comment "/*" instead of a kernel-doc marker "/**"
> to prevent kernel-doc warnings:
>
> arm_global_timer.c:92: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * To ensure that updates to comparator value register do not set the
> arm_global_timer.c:92: warning: missing initial short description on line:
> * To ensure that updates to comparator value register do not set the
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Patrice Chotard <[email protected]>
> Cc: [email protected]
> Cc: Daniel Lezcano <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


Subject: [tip: timers/core] clocksource: arm_global_timer: fix non-kernel-doc comment

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 97454a65d56b240013ed8d396427b85e34384238
Gitweb: https://git.kernel.org/tip/97454a65d56b240013ed8d396427b85e34384238
Author: Randy Dunlap <[email protected]>
AuthorDate: Sun, 14 Jan 2024 21:36:41 -08:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Wed, 21 Feb 2024 09:56:06 +01:00

clocksource: arm_global_timer: fix non-kernel-doc comment

Use a common C comment "/*" instead of a kernel-doc marker "/**"
to prevent kernel-doc warnings:

arm_global_timer.c:92: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* To ensure that updates to comparator value register do not set the
arm_global_timer.c:92: warning: missing initial short description on line:
* To ensure that updates to comparator value register do not set the

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: [email protected]
Cc: Daniel Lezcano <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/arm_global_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 8dd1e46..d749dee 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -88,7 +88,7 @@ static u64 gt_counter_read(void)
return _gt_counter_read();
}

-/**
+/*
* To ensure that updates to comparator value register do not set the
* Interrupt Status Register proceed as follows:
* 1. Clear the Comp Enable bit in the Timer Control Register.