Subject: [PATCH 0/2] arm64: defconfig: Enable multimedia clocks on SC7180

Device trees for SC7180 Trogdor machines are enabling DPU1 and Venus, but
these are never getting up due to missing clock drivers; after a test, it
was discovered that both of them are fairly ok, except for the Venus
encoder, which doesn't seem to work fine, but it's anyway not introducing
any unstability (the device won't crash), so there is no reason to keep
them out of the game.

Since both of these clock drivers aren't boot-critical and can be inserted
later, it's proposed to enable them as module: this will avoid increasing
the kernel image size, which is especially important to keep lower loading
times (from the bootloader).

AngeloGioacchino Del Regno (2):
arm64: defconfig: Add SC7180 GPUCC and DISPCC as module
arm64: defconfig: Add SC7180 VIDEOCC as module

arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)

--
2.33.0


Subject: [PATCH 2/2] arm64: defconfig: Add SC7180 VIDEOCC as module

This is required in order to be able to probe the Venus hardware
video decoder/encoder driver on the SC7180 SoC: being this driver
not boot-critical, it's sufficient to have it as a module.

This is being done as there are SC7180 device trees enabling
support for this hardware, but not being probed due to these
drivers not being built.

Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index bb97baa5f1d8..c20885f6d9bf 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -995,6 +995,7 @@ CONFIG_QCS_GCC_404=y
CONFIG_SC_DISPCC_7180=m
CONFIG_SC_GCC_7180=y
CONFIG_SC_GPUCC_7180=m
+CONFIG_SC_VIDEOCC_7180=m
CONFIG_SDM_CAMCC_845=m
CONFIG_SDM_GCC_845=y
CONFIG_SDM_GPUCC_845=y
--
2.33.0

Subject: [PATCH 1/2] arm64: defconfig: Add SC7180 GPUCC and DISPCC as module

SC_DISPCC_7180 and SC_GPUCC_7180 are not boot-critical clock
controller drivers, but these are required in order to get
DPU1/display support (so, to allow probing DRM_MSM) and Adreno
GPU support, which are modules as well.

This is being done as there are SC7180 device trees enabling
support for this hardware, but not being probed due to these
drivers not being built.

Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 171848ace3ac..bb97baa5f1d8 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -992,7 +992,9 @@ CONFIG_MSM_GCC_8994=y
CONFIG_MSM_MMCC_8996=y
CONFIG_MSM_GCC_8998=y
CONFIG_QCS_GCC_404=y
+CONFIG_SC_DISPCC_7180=m
CONFIG_SC_GCC_7180=y
+CONFIG_SC_GPUCC_7180=m
CONFIG_SDM_CAMCC_845=m
CONFIG_SDM_GCC_845=y
CONFIG_SDM_GPUCC_845=y
--
2.33.0

2021-10-29 08:33:02

by Guillaume Tucker

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: defconfig: Add SC7180 GPUCC and DISPCC as module

On 13/10/2021 11:56, AngeloGioacchino Del Regno wrote:
> SC_DISPCC_7180 and SC_GPUCC_7180 are not boot-critical clock
> controller drivers, but these are required in order to get
> DPU1/display support (so, to allow probing DRM_MSM) and Adreno
> GPU support, which are modules as well.
>
> This is being done as there are SC7180 device trees enabling
> support for this hardware, but not being probed due to these
> drivers not being built.
>
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>

Tested-by: "kernelci.org bot" <[email protected]>

https://staging.kernelci.org/test/plan/id/6177be0c2554c2fd1ba6c464/

Thanks,
Guillaume

> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 171848ace3ac..bb97baa5f1d8 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -992,7 +992,9 @@ CONFIG_MSM_GCC_8994=y
> CONFIG_MSM_MMCC_8996=y
> CONFIG_MSM_GCC_8998=y
> CONFIG_QCS_GCC_404=y
> +CONFIG_SC_DISPCC_7180=m
> CONFIG_SC_GCC_7180=y
> +CONFIG_SC_GPUCC_7180=m
> CONFIG_SDM_CAMCC_845=m
> CONFIG_SDM_GCC_845=y
> CONFIG_SDM_GPUCC_845=y
>

2021-10-29 08:34:52

by Guillaume Tucker

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: defconfig: Add SC7180 VIDEOCC as module

On 13/10/2021 11:56, AngeloGioacchino Del Regno wrote:
> This is required in order to be able to probe the Venus hardware
> video decoder/encoder driver on the SC7180 SoC: being this driver
> not boot-critical, it's sufficient to have it as a module.
>
> This is being done as there are SC7180 device trees enabling
> support for this hardware, but not being probed due to these
> drivers not being built.
>
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>

Tested-by: "kernelci.org bot" <[email protected]>

https://staging.kernelci.org/test/plan/id/6177be0c2554c2fd1ba6c464/

Thanks,
Guillaume

> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index bb97baa5f1d8..c20885f6d9bf 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -995,6 +995,7 @@ CONFIG_QCS_GCC_404=y
> CONFIG_SC_DISPCC_7180=m
> CONFIG_SC_GCC_7180=y
> CONFIG_SC_GPUCC_7180=m
> +CONFIG_SC_VIDEOCC_7180=m
> CONFIG_SDM_CAMCC_845=m
> CONFIG_SDM_GCC_845=y
> CONFIG_SDM_GPUCC_845=y
>