2017-06-20 20:44:39

by Arnd Bergmann

Subject: [PATCH] drivers/fsi: fix fsi_slave_mode prototype

gcc warns about the return type of this function:

drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

This removes the 'const' attribute, as suggested by the warning.

Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/fsi/fsi-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index a485864cb512..f2e08932e2d9 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -532,7 +532,7 @@ static inline uint32_t fsi_smode_sid(int x)
return (x & FSI_SMODE_SID_MASK) << FSI_SMODE_SID_SHIFT;
}

-static const uint32_t fsi_slave_smode(int id)
+static uint32_t fsi_slave_smode(int id)
{
return FSI_SMODE_WSC | FSI_SMODE_ECRC
| fsi_smode_sid(id)
--
2.9.0

2017-06-21 00:49:58

by Jeremy Kerr

Subject: Re: [PATCH] drivers/fsi: fix fsi_slave_mode prototype

Hi Arnd,

> gcc warns about the return type of this function:
>
> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>
> This removes the 'const' attribute, as suggested by the warning.

Acked-by: Jeremy Kerr <[email protected]>

Cheers,


Jeremy

2017-07-04 10:29:44

by Geert Uytterhoeven

Subject: Re: [PATCH] drivers/fsi: fix fsi_slave_mode prototype

On Tue, Jun 20, 2017 at 10:43 PM, Arnd Bergmann <[email protected]> wrote:
> gcc warns about the return type of this function:
>
> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>
> This removes the 'const' attribute, as suggested by the warning.
>
> Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds