2022-08-29 13:20:43

by Maxime Ripard

Subject: [PATCH v2 25/41] drm/vc4: vec: Convert to atomic helpers

The VC4 VEC driver still uses legacy enable and disable hook

implementation. Let's convert to the atomic variants.



Signed-off-by: Maxime Ripard <[email protected]>



diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c

index d521ffd8d75c..72eee0cbb615 100644

--- a/drivers/gpu/drm/vc4/vc4_vec.c

+++ b/drivers/gpu/drm/vc4/vc4_vec.c

@@ -375,7 +375,8 @@ static int vc4_vec_connector_init(struct drm_device *dev, struct vc4_vec *vec)

return 0;

}



-static void vc4_vec_encoder_disable(struct drm_encoder *encoder)

+static void vc4_vec_encoder_disable(struct drm_encoder *encoder,

+ struct drm_atomic_state *state)

{

struct drm_device *drm = encoder->dev;

struct vc4_vec *vec = encoder_to_vc4_vec(encoder);

@@ -406,7 +407,8 @@ static void vc4_vec_encoder_disable(struct drm_encoder *encoder)

drm_dev_exit(idx);

}



-static void vc4_vec_encoder_enable(struct drm_encoder *encoder)

+static void vc4_vec_encoder_enable(struct drm_encoder *encoder,

+ struct drm_atomic_state *state)

{

struct drm_device *drm = encoder->dev;

struct vc4_vec *vec = encoder_to_vc4_vec(encoder);

@@ -508,9 +510,9 @@ static int vc4_vec_encoder_atomic_check(struct drm_encoder *encoder,

}



static const struct drm_encoder_helper_funcs vc4_vec_encoder_helper_funcs = {

- .disable = vc4_vec_encoder_disable,

- .enable = vc4_vec_encoder_enable,

.atomic_check = vc4_vec_encoder_atomic_check,

+ .atomic_disable = vc4_vec_encoder_disable,

+ .atomic_enable = vc4_vec_encoder_enable,

.atomic_mode_set = vc4_vec_encoder_atomic_mode_set,

};





--

b4 0.10.0-dev-65ba7

2022-08-30 15:50:23

by Noralf Trønnes

Subject: Re: [PATCH v2 25/41] drm/vc4: vec: Convert to atomic helpers

Den 29.08.2022 15.11, skrev Maxime Ripard:
> The VC4 VEC driver still uses legacy enable and disable hook
>
> implementation. Let's convert to the atomic variants.
>
>
>
> Signed-off-by: Maxime Ripard <[email protected]>
>

Reviewed-by: Noralf Trønnes <[email protected]>

2022-09-07 08:50:38

by Maxime Ripard

Subject: Re: (subset) [PATCH v2 25/41] drm/vc4: vec: Convert to atomic helpers

On Mon, 29 Aug 2022 15:11:39 +0200, Maxime Ripard wrote:
> The VC4 VEC driver still uses legacy enable and disable hook
> implementation. Let's convert to the atomic variants.
>
>

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime