2008-02-20 08:59:17

by Ingo Molnar

Subject: Re: [PATCH 1/1] x86: Coding style fixes to arch/x86/mach-generic/probe.c

* Paolo Ciarrocchi <[email protected]> wrote:

> - for (i = 0; apic_probe[i]; ++i) {
> - if (apic_probe[i]->mps_oem_check(mpc,oem,productid)) {
> + for (i = 0; apic_probe[i]; ++i) {
> + if (apic_probe[i]->mps_oem_check(mpc, i oem, productid)) {

you typoed that one. Please build-test files you change.

Ingo

2008-02-20 09:11:22

by Paolo Ciarrocchi

Subject: Re: [PATCH 1/1] x86: Coding style fixes to arch/x86/mach-generic/probe.c

On Feb 20, 2008 9:58 AM, Ingo Molnar <[email protected]> wrote:
>
> * Paolo Ciarrocchi <[email protected]> wrote:
>
> > - for (i = 0; apic_probe[i]; ++i) {
> > - if (apic_probe[i]->mps_oem_check(mpc,oem,productid)) {
> > + for (i = 0; apic_probe[i]; ++i) {
> > + if (apic_probe[i]->mps_oem_check(mpc, i oem, productid)) {
>
> you typoed that one. Please build-test files you change.

Yup, sorry about that!
Won't happen in the future.

Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/