On 05/10/2023 06:31, Devi Priya wrote:
> Describe the PWM block on IPQ6018.
>
> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
> &pwm as child of &tcsr.
>
> Add also ipq6018 specific compatible string.
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Co-developed-by: Baruch Siach <[email protected]>
> Signed-off-by: Baruch Siach <[email protected]>
> Signed-off-by: Devi Priya <[email protected]>
> ---
> v14:
>
> Moved ranges just after reg as suggested by Krzysztof
>
> Picked up the R-b tag
>
> v13:
>
> No change
>
> v12:
>
> No change
>
> v11:
>
> No change
>
> v10:
>
> No change
>
> v9:
>
> Add 'ranges' property (Rob)
>
> v8:
>
> Add size cell to 'reg' (Rob)
>
> v7:
>
> Use 'reg' instead of 'offset' (Rob)
>
> Add qcom,tcsr-ipq6018 (Rob)
>
> Drop clock-names (Bjorn)
>
> v6:
>
> Make the PWM node child of TCSR (Rob Herring)
>
> Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
>
> v5: Use qcom,pwm-regs for TCSR phandle instead of direct regs
>
> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index e59b9df96c7e..565e61ce382f 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -390,8 +390,21 @@ tcsr_mutex: hwlock@1905000 {
> };
>
> tcsr: syscon@1937000 {
> - compatible = "qcom,tcsr-ipq6018", "syscon";
> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
> reg = <0x0 0x01937000 0x0 0x21000>;
> + ranges = <0x0 0x0 0x01937000 0x21000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + pwm: pwm@a010 {
Broken indentation.
Best regards,
Krzysztof
On 10/5/2023 1:00 PM, Krzysztof Kozlowski wrote:
> On 05/10/2023 06:31, Devi Priya wrote:
>> Describe the PWM block on IPQ6018.
>>
>> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
>> &pwm as child of &tcsr.
>>
>> Add also ipq6018 specific compatible string.
>>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>> Co-developed-by: Baruch Siach <[email protected]>
>> Signed-off-by: Baruch Siach <[email protected]>
>> Signed-off-by: Devi Priya <[email protected]>
>> ---
>> v14:
>>
>> Moved ranges just after reg as suggested by Krzysztof
>>
>> Picked up the R-b tag
>>
>> v13:
>>
>> No change
>>
>> v12:
>>
>> No change
>>
>> v11:
>>
>> No change
>>
>> v10:
>>
>> No change
>>
>> v9:
>>
>> Add 'ranges' property (Rob)
>>
>> v8:
>>
>> Add size cell to 'reg' (Rob)
>>
>> v7:
>>
>> Use 'reg' instead of 'offset' (Rob)
>>
>> Add qcom,tcsr-ipq6018 (Rob)
>>
>> Drop clock-names (Bjorn)
>>
>> v6:
>>
>> Make the PWM node child of TCSR (Rob Herring)
>>
>> Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
>>
>> v5: Use qcom,pwm-regs for TCSR phandle instead of direct regs
>>
>> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>>
>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index e59b9df96c7e..565e61ce382f 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -390,8 +390,21 @@ tcsr_mutex: hwlock@1905000 {
>> };
>>
>> tcsr: syscon@1937000 {
>> - compatible = "qcom,tcsr-ipq6018", "syscon";
>> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>> reg = <0x0 0x01937000 0x0 0x21000>;
>> + ranges = <0x0 0x0 0x01937000 0x21000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + pwm: pwm@a010 {
>
> Broken indentation.
Oops, sorry! will fix it up
Thanks,
Devi Priya
>
> Best regards,
> Krzysztof
>