2022-11-02 15:05:09

by Arthur Simchaev

Subject: [PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

len argument is not used anymore in ufshcd_set_active_icc_lvl function.

Signed-off-by: Arthur Simchaev <[email protected]>
---
drivers/ufs/core/ufshcd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index aa46292..9cc3abd 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -7386,7 +7386,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
* Returns calculated ICC level
*/
static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
- const u8 *desc_buf, int len)
+ const u8 *desc_buf)
{
u32 icc_level = 0;

@@ -7444,8 +7444,7 @@ static void ufshcd_set_active_icc_lvl(struct ufs_hba *hba)
goto out;
}

- icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf,
- QUERY_DESC_MAX_SIZE);
+ icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf);
dev_dbg(hba->dev, "%s: setting icc_level 0x%x", __func__, icc_level);

ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
--
2.7.4

2022-11-14 13:22:05

by Bean Huo

Subject: Re: [PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

Arthur,

On 02.11.22 3:29 PM, Arthur Simchaev wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index aa46292..9cc3abd 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7386,7 +7386,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
> * Returns calculated ICC level
> */
> static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> - const u8 *desc_buf, int len)
> + const u8 *desc_buf)


'len' description of 'ufshcd_find_max_sup_active_icc_level()' should be
removed as well.

Kind regards,

Bean

2022-11-15 13:01:48

by Arthur Simchaev

Subject: RE: [PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

>
>
> 'len' description of 'ufshcd_find_max_sup_active_icc_level()' should be
> removed as well.
>
> Kind regards,
>
> Bean
Done.

Regards
Arthur