2020-04-22 00:16:04

by Michel Lespinasse

Subject: [PATCH v5 02/10] MMU notifier: use the new mmap locking API

This use is converted manually ahead of the next patch in the series,
as it requires including a new header which the automated conversion
would miss.

Signed-off-by: Michel Lespinasse <[email protected]>
Reviewed-by: Daniel Jordan <[email protected]>
Reviewed-by: Davidlohr Bueso <[email protected]>
---
include/linux/mmu_notifier.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index 736f6918335e..2f462710a1a4 100644
--- a/include/linux/mmu_notifier.h
+++ b/include/linux/mmu_notifier.h
@@ -5,6 +5,7 @@
#include <linux/list.h>
#include <linux/spinlock.h>
#include <linux/mm_types.h>
+#include <linux/mmap_lock.h>
#include <linux/srcu.h>
#include <linux/interval_tree.h>

@@ -277,9 +278,9 @@ mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
{
struct mmu_notifier *ret;

- down_write(&mm->mmap_sem);
+ mmap_write_lock(mm);
ret = mmu_notifier_get_locked(ops, mm);
- up_write(&mm->mmap_sem);
+ mmap_write_unlock(mm);
return ret;
}
void mmu_notifier_put(struct mmu_notifier *subscription);
--
2.26.1.301.g55bc3eb7cb9-goog

2020-05-18 09:31:53

by Vlastimil Babka

Subject: Re: [PATCH v5 02/10] MMU notifier: use the new mmap locking API

On 4/22/20 2:14 AM, Michel Lespinasse wrote:
> This use is converted manually ahead of the next patch in the series,
> as it requires including a new header which the automated conversion
> would miss.
>
> Signed-off-by: Michel Lespinasse <[email protected]>
> Reviewed-by: Daniel Jordan <[email protected]>
> Reviewed-by: Davidlohr Bueso <[email protected]>

Reviewed-by: Vlastimil Babka <[email protected]>

> ---
> include/linux/mmu_notifier.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index 736f6918335e..2f462710a1a4 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -5,6 +5,7 @@
> #include <linux/list.h>
> #include <linux/spinlock.h>
> #include <linux/mm_types.h>
> +#include <linux/mmap_lock.h>
> #include <linux/srcu.h>
> #include <linux/interval_tree.h>
>
> @@ -277,9 +278,9 @@ mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
> {
> struct mmu_notifier *ret;
>
> - down_write(&mm->mmap_sem);
> + mmap_write_lock(mm);
> ret = mmu_notifier_get_locked(ops, mm);
> - up_write(&mm->mmap_sem);
> + mmap_write_unlock(mm);
> return ret;
> }
> void mmu_notifier_put(struct mmu_notifier *subscription);
>

2020-05-18 13:21:41

by Laurent Dufour

Subject: Re: [PATCH v5 02/10] MMU notifier: use the new mmap locking API

Le 22/04/2020 à 02:14, Michel Lespinasse a écrit :
> This use is converted manually ahead of the next patch in the series,
> as it requires including a new header which the automated conversion
> would miss.
>
> Signed-off-by: Michel Lespinasse <[email protected]>
> Reviewed-by: Daniel Jordan <[email protected]>
> Reviewed-by: Davidlohr Bueso <[email protected]>

Reviewed-by: Laurent Dufour <[email protected]>

> ---
> include/linux/mmu_notifier.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index 736f6918335e..2f462710a1a4 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -5,6 +5,7 @@
> #include <linux/list.h>
> #include <linux/spinlock.h>
> #include <linux/mm_types.h>
> +#include <linux/mmap_lock.h>
> #include <linux/srcu.h>
> #include <linux/interval_tree.h>
>
> @@ -277,9 +278,9 @@ mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
> {
> struct mmu_notifier *ret;
>
> - down_write(&mm->mmap_sem);
> + mmap_write_lock(mm);
> ret = mmu_notifier_get_locked(ops, mm);
> - up_write(&mm->mmap_sem);
> + mmap_write_unlock(mm);
> return ret;
> }
> void mmu_notifier_put(struct mmu_notifier *subscription);
>