2019-03-07 16:29:45

by Tomohiro Mayama

Subject: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

This patch makes USB ports functioning again.

Signed-off-by: Tomohiro Mayama <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 21107d0f4378..7f365e448867 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -45,8 +45,7 @@

vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
compatible = "regulator-fixed";
- enable-active-high;
- gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&usb20_host_drv>;
regulator-name = "vcc_host1_5v";
--
2.21.0

2019-03-09 02:53:31

by Katsuhiro Suzuki

Subject: Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

Hello Mayama-san,

On 2019/03/08 1:18, Tomohiro Mayama wrote:
> This patch makes USB ports functioning again.
>
> Signed-off-by: Tomohiro Mayama <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 21107d0f4378..7f365e448867 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -45,8 +45,7 @@
>
> vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
> compatible = "regulator-fixed";
> - enable-active-high;
> - gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> + gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&usb20_host_drv>;
> regulator-name = "vcc_host1_5v";
>

After this patch applied, USB and S/PDIF both work well.

Tested-by: Katsuhiro Suzuki <[email protected]>


$ lsusb
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: ID 046d:c526 Logitech, Inc. Nano Receiver
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub


Best Regards,
Katsuhiro Suzuki

2019-03-09 15:20:58

by Tomohiro Mayama

Subject: Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

On 2019/03/09 11:52, Katsuhiro Suzuki wrote:
> Hello Mayama-san,
>
> On 2019/03/08 1:18, Tomohiro Mayama wrote:
>> This patch makes USB ports functioning again.
>>
>> Signed-off-by: Tomohiro Mayama <[email protected]>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> index 21107d0f4378..7f365e448867 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> @@ -45,8 +45,7 @@
>>         vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
>>           compatible = "regulator-fixed";
>> -        enable-active-high;
>> -        gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
>> +        gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
>>           pinctrl-names = "default";
>>           pinctrl-0 = <&usb20_host_drv>;
>>           regulator-name = "vcc_host1_5v";
>>
>
> After this patch applied, USB and S/PDIF both work well.
>
> Tested-by: Katsuhiro Suzuki <[email protected]>
>
>
> $ lsusb
> Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 001 Device 002: ID 046d:c526 Logitech, Inc. Nano Receiver
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
>
>
> Best Regards,
> Katsuhiro Suzuki
>
> _______________________________________________
> Linux-rockchip mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

Thank you for testing my patch, Suzuki-san!

Regards,
Tomohiro Mayama

2019-03-09 16:10:54

by Tomohiro Mayama

Subject: [PATCH v2] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

This patch makes USB ports functioning again.

Suggested-by: Robin Murphy <[email protected]>
Signed-off-by: Tomohiro Mayama <[email protected]>
Tested-by: Katsuhiro Suzuki <[email protected]>
---
v2:
* Added Suggested-by and Tested-by tags
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 21107d0f4378..7f365e448867 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -45,8 +45,7 @@

vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
compatible = "regulator-fixed";
- enable-active-high;
- gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&usb20_host_drv>;
regulator-name = "vcc_host1_5v";
--
2.21.0

2019-03-12 10:09:02

by Heiko Stuebner

Subject: Re: [PATCH v2] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

Am Samstag, 9. M?rz 2019, 17:10:12 CET schrieb Tomohiro Mayama:
> This patch makes USB ports functioning again.
>
> Suggested-by: Robin Murphy <[email protected]>
> Signed-off-by: Tomohiro Mayama <[email protected]>
> Tested-by: Katsuhiro Suzuki <[email protected]>

added Fixes and Cc-stable tags and applied as fix for 5.1

Thanks
Heiko