2020-08-31 22:55:59

by Alain Volmat

Subject: [PATCH] reset: sti: reset-syscfg: fix struct description warnings

Fix formating of struct description to avoid warning highlighted
by W=1 compilation.

Fixes: e5d76075d930 ("drivers: reset: STi SoC system configuration reset controller support")
Signed-off-by: Alain Volmat <[email protected]>
---
drivers/reset/sti/reset-syscfg.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/reset/sti/reset-syscfg.c b/drivers/reset/sti/reset-syscfg.c
index 91215bb88f62..99b63035fe72 100644
--- a/drivers/reset/sti/reset-syscfg.c
+++ b/drivers/reset/sti/reset-syscfg.c
@@ -17,7 +17,7 @@
#include "reset-syscfg.h"

/**
- * Reset channel regmap configuration
+ * struct syscfg_reset_channel - Reset channel regmap configuration
*
* @reset: regmap field for the channel's reset bit.
* @ack: regmap field for the channel's ack bit (optional).
@@ -28,8 +28,9 @@ struct syscfg_reset_channel {
};

/**
- * A reset controller which groups together a set of related reset bits, which
- * may be located in different system configuration registers.
+ * struct syscfg_reset_controller - A reset controller which groups together
+ * a set of related reset bits, which may be located in different system
+ * configuration registers.
*
* @rst: base reset controller structure.
* @active_low: are the resets in this controller active low, i.e. clearing
--
2.17.1

2020-09-23 12:39:22

by Philipp Zabel

Subject: Re: [PATCH] reset: sti: reset-syscfg: fix struct description warnings

Hi Alain,

On Mon, 2020-08-31 at 22:38 +0200, Alain Volmat wrote:
> Fix formating of struct description to avoid warning highlighted
> by W=1 compilation.
>
> Fixes: e5d76075d930 ("drivers: reset: STi SoC system configuration reset controller support")
> Signed-off-by: Alain Volmat <[email protected]>

Thank you, applied to reset/next.

regards
Philipp

2020-11-19 07:59:08

by Patrice CHOTARD

Subject: Re: [PATCH] reset: sti: reset-syscfg: fix struct description warnings

Hi Alain

On 8/31/20 10:38 PM, Alain Volmat wrote:
> Fix formating of struct description to avoid warning highlighted
> by W=1 compilation.
>
> Fixes: e5d76075d930 ("drivers: reset: STi SoC system configuration reset controller support")
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> drivers/reset/sti/reset-syscfg.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/reset/sti/reset-syscfg.c b/drivers/reset/sti/reset-syscfg.c
> index 91215bb88f62..99b63035fe72 100644
> --- a/drivers/reset/sti/reset-syscfg.c
> +++ b/drivers/reset/sti/reset-syscfg.c
> @@ -17,7 +17,7 @@
> #include "reset-syscfg.h"
>
> /**
> - * Reset channel regmap configuration
> + * struct syscfg_reset_channel - Reset channel regmap configuration
> *
> * @reset: regmap field for the channel's reset bit.
> * @ack: regmap field for the channel's ack bit (optional).
> @@ -28,8 +28,9 @@ struct syscfg_reset_channel {
> };
>
> /**
> - * A reset controller which groups together a set of related reset bits, which
> - * may be located in different system configuration registers.
> + * struct syscfg_reset_controller - A reset controller which groups together
> + * a set of related reset bits, which may be located in different system
> + * configuration registers.
> *
> * @rst: base reset controller structure.
> * @active_low: are the resets in this controller active low, i.e. clearing

Reviewed-by: Patrice Chotard <[email protected]>

Thanks

Patrice