2023-12-21 14:30:04

by Ahelenia Ziemiańska

[permalink] [raw]

Subject: [PATCH] kernfs: fix reference to renamed function

---

commit c637b8acbe079edb477d887041755b489036f146 ("kernfs:
s/sysfs/kernfs/ in internal functions and whatever is left")
renamed kernfs_file_open to kernfs_fop_open, but didn't update the
comment referencing it.

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
---
fs/kernfs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index f0cb729e9a97..ffa4565c275a 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -447,7 +447,7 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma)
* warnings and we don't want to add spurious locking dependency
* between the two. Check whether mmap is actually implemented
* without grabbing @of->mutex by testing HAS_MMAP flag. See the
- * comment in kernfs_file_open() for more details.
+ * comment in kernfs_fop_open() for more details.
*/
if (!(of->kn->flags & KERNFS_HAS_MMAP))
return -ENODEV;
--
2.39.2

---

Attachments:

(No filename) (999.00 B)
signature.asc (849.00 B)
Download all attachments

2023-12-21 21:22:21

by Tejun Heo

[permalink] [raw]

Subject: Re: [PATCH] kernfs: fix reference to renamed function

---

On Thu, Dec 21, 2023 at 03:15:42PM +0100, Ahelenia Ziemiańska wrote:
> commit c637b8acbe079edb477d887041755b489036f146 ("kernfs:
> s/sysfs/kernfs/ in internal functions and whatever is left")
> renamed kernfs_file_open to kernfs_fop_open, but didn't update the
> comment referencing it.
>
> Signed-off-by: Ahelenia Ziemiańska <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Thanks.

--
tejun