2024-04-29 12:53:59

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 07/12] arm64: dts: qcom: sm8450: move PHY's orientation-switch to SoC dtsi

On 29/04/2024 14:43, Dmitry Baryshkov wrote:
> The orientation-switch of the USB+DP QMP PHY is not a property of the
> board, it is a design property of the QMP PHY itself. Move the property
> from board DTS to SoC DTSI.
>
> Signed-off-by: Dmitry Baryshkov <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 2 --
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 9926294e4f84..71dc06db7736 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -1120,8 +1120,6 @@ &usb_1_qmpphy {
>
> vdda-phy-supply = <&vreg_l6b_1p2>;
> vdda-pll-supply = <&vreg_l1b_0p91>;
> -
> - orientation-switch;
> };
>
> &usb_1_qmpphy_out {
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index d138b90bb280..3494d5076368 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2304,6 +2304,8 @@ usb_1_qmpphy: phy@88e8000 {
> #clock-cells = <1>;
> #phy-cells = <1>;
>
> + orientation-switch;
> +
> status = "disabled";
>
> ports {
>

Reviewed-by: Neil Armstrong <[email protected]>